commit 29cd3022ac4348d1e9ebe7063518fdff10167217 Author: Andrew Fuerste Henry Date: Thu Apr 10 14:09:55 2025 +0000 Bug 38994: Add classes to circulation module homepage To test: 1: inspect /koha/circ/circulation-home.pl, see most elements lack distinct classes 2: apply patch, reload page 3: inspect page again, confirm nothing has changed in display 4: confirm page elements have distinct classes now and can be accurately targetted with CSS Signed-off-by: Jason Robb Signed-off-by: David Cook Signed-off-by: Katrin Fischer commit 1c3bc68e9c4abcb4e72e886322b5e1a51f318a3e Author: Stefan Berndtsson Date: Fri Mar 7 12:59:14 2025 +0100 Bug 39467: Fix patron "View restrictions" link in messages Currently nothing happens when clicking the "View restrictions" link in patron messages. Using the bootstrap api to open it resolves the issue. To test: 1) Go to a patrons details page, click "Restrictions" and add amanual restriction. 2) A message with a "View restrictions" link should appear. 3) Clicking this link does not open the "Restrictions" tab as it should. 4) Apply patch 5) Now this "View restrictions" link should open the "Restrictions" tab Sponsored-by: Gothenburg University Library Signed-off-by: Jesse Maseto Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer commit 1d6017bbd8e8e54151cf2c787fbfeaf022f08f1c Author: Pedro Amorim Date: Tue Mar 25 15:41:08 2025 +0000 Bug 39449: Fix table sort arrows Test plan: 1) Look at the same biblio on both OPAC and Staff: http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=76 http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=76 2) Click on the 'current library' column header for OPAC and 'Home library' for staff. Notice that on Staff when it's DESC, arrow points down (as expected), but on OPAC when it's DESC, the arrows points up. 3) Apply patch. Reset CSS: yarn css:build 4) Do a hard refresh on the OPAC. Repeat test plan. Notice they now behave the same. Signed-off-by: Owen Leonard Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer commit ae069f57ec1da90e73c330be3fdce91ade7b785e Author: Johanna Räisä Date: Mon Mar 17 12:34:00 2025 +0200 Bug 38905: change permissions for item creation and modification This patch changes the permissions to edit_items for item creation and modification via the API. Test plan: 1) Apply the patch 2) prove t/db_dependent/api/v1/biblios.t Sponsored-by: Koha-Suomi Oy Signed-off-by: Jan Kissig Signed-off-by: Paul Derscheid Signed-off-by: Katrin Fischer commit 0473abdd624dc48f894a7c2e56b809cc1c9550c5 Author: Baptiste Wojtkowski Date: Tue Mar 4 16:13:55 2025 +0100 Bug 39238: Add links toward private lists in biblio TEST PLAN: 1 - Create a public list, add a book in the list 2 - Notice there is a link on biblio's details on the intranet 3 - Add the book in a private list, notice there is no link on biblio's details 4 - Apply patch 5 - Notice there is now a link to the list Signed-off-by: Karolina Sumara Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer commit 7ee729af4dd28f49e47b9bbc2c40b6d9cd498ff8 Author: Katrin Fischer Date: Tue Apr 22 06:45:45 2025 +0000 Bug 39171: DBRev 24.12.00.027 Signed-off-by: Katrin Fischer commit 833ad77a8fec3cc50b8950f600774f29dde5e798 Author: David Gustafsson Date: Wed Feb 19 18:27:17 2025 +0100 Bug 39171: Rename IS02709 ElasticsearchMARCFormat to base64ISO2709 To test: 1) Apply patch 2) Make sure tests in t/db_dependent/Koha/SearchEngine/Elasticsearch.t pass Signed-off-by: David Cook Signed-off-by: Thomas Klausner Signed-off-by: Katrin Fischer commit a8cb53a045f1397bd42e2c12dfe764ab3d030956 Author: Katrin Fischer Date: Tue Apr 22 06:45:42 2025 +0000 Bug 39062: DBRev 24.12.00.026 Signed-off-by: Katrin Fischer commit 4f2ee1640d4f9f916d4d4e30b20000309c874779 Author: Andrew Fuerste Henry Date: Thu Feb 6 21:51:09 2025 +0000 Bug 39062: Increase stocknumber length in items and deleteditems Signed-off-by: David Cook Signed-off-by: Baptiste Wojtkowski Signed-off-by: Katrin Fischer commit 41d781648ffcec33432753729d5e5a161a36fd59 Author: Andrew Fuerste Henry Date: Thu Feb 6 21:26:03 2025 +0000 Bug 39062: increase length of items.stocknumber and deleteditems.stocknumber in kohastructure.sql To test: 1: try to save a value in the 952$i that is more than 32 characters 2: It does not work. 3: apply patch 4: try to save a value in the 952$i that is more than 32 characters 5: it does work! 6: delete your item and use a report to confirm the full string is in deleteditems.stocknumber 7: Maybe use DESCRIBE from mysql commandline to see the length and confirm it's changed? Signed-off-by: David Cook Signed-off-by: Baptiste Wojtkowski Signed-off-by: Katrin Fischer commit 35e00aa69a2be2026a2623fe2a53bafa97d3079a Author: Owen Leonard Date: Tue Mar 4 14:40:18 2025 +0000 Bug 37907: Add column to user summary to show date an item was checked out on This patch adds a "Checked out on" column to the table of checkouts and the table of overdues on the OPAC user summary page. To test, apply the patch and log in to the OPAC as a user who has overdue items. - On the user summary page confirm that the "Checked out" table shows a column for "Checked out on" and that the information is displayed correctly. - Make the same check of the "Overdue" tab. Sponsored-by: Athens County Public Libraries Signed-off-by: Olivier V Signed-off-by: Baptiste Wojtkowski Signed-off-by: Katrin Fischer commit 346bef792ecf471bdbebcb901bd909235edfdecf Author: Pedro Amorim Date: Mon Jan 20 13:44:23 2025 +0000 Bug 38669: (QA follow-up): Prevent multiple occurrences of 'op' in the form This may happen if getting to the ILL auto screen from the type disclaimer screen for example Which causes the 'return to request'm form submission to have 2 'op's, causing error. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer commit ff4bdb1ef5055dd5238c28aae9fb344d31a36e64 Author: Pedro Amorim Date: Wed Jan 15 13:40:00 2025 +0000 Bug 38669: (QA follow-up): Fix find-missing-op-in-forms.t failure prove xt/find-missing-op-in-forms.t Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer commit bf0309b4eed6a7e1f3d8ecba230f9e4c5a58f5e9 Author: Pedro Amorim Date: Tue Dec 10 17:16:21 2024 +0000 Bug 38669: Add 'Return to form' button at top of auto backend screen Follow test plan from bug 35604, but notice you now have the possibility to return to the form Sponsored-by: UKHSA - UK Health Security Agency Sponsored-by: PTFS Europe Ltd Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer commit 858134df9f75c4693464a6907877ee00f6dfd8af Author: Pedro Amorim Date: Thu Dec 12 13:12:03 2024 +0000 Bug 38685: Add missing ops to breadcrumbs Breadcrumbs added to the following op pages: - confirm - delete_confirm - generic_confirm - edititem - edit_action - check_out - cud-cancel - availability Test plan: 1) Enable ILLModule 2) Create a new ILL request: /cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 3) Try various actions like 'Edit request', 'Confirm request', 'Place request with partners', etc. 4) Notice the breadcrumbs were previously missing. They are now there. 5) If you want to test the breadcrumbs on the batches pages or availability check stage let me know and I'll help setting up the required plugins to have them work. Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit b02d4c42cc346a4c577ea373ce90b32bf381f3da Author: Pedro Amorim Date: Thu Dec 12 13:11:21 2024 +0000 Bug 38685: Preparation: DRY code This is in preparation of the next patch, to avoid big copy + pastes Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 7ed014dd1e42d81dbbef29f7d1fcd19fe5644603 Author: Pedro Amorim Date: Thu Dec 12 13:01:23 2024 +0000 Bug 38685: Only render breadcrumb item if content not empty This ensures the '>' caret is only rendered if there is indeed some breadcrumb content. Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit eee149e5a7e3331e2aa3dd95a4eab0cb41f98e2b Author: Pedro Amorim Date: Thu Dec 12 12:40:05 2024 +0000 Bug 38685: Remove useless batch_create code This is not used and not needed. Noticed when evaluating every potential 'op'. Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 0323d147dd11b4da7f9a2ab949a40d6199dab12b Author: Brendan Lawlor Date: Thu Apr 17 14:11:34 2025 +0000 Bug 37050: (follow-up) Fix invalid html syntax in tt Signed-off-by: Katrin Fischer commit a00693d26353888ad4b5d9272ac853684d2810b0 Author: Brendan Lawlor Date: Wed Jan 29 20:27:27 2025 +0000 Bug 37050: Add select2 to SQL reports multiselect This patch adds select 2 to multi-select parameter fields in SQL reports. If no selections are made for a multi-select all authorised values will be used by default. This allows reports to be written where a multi select parameter is optional. To test: 1. Apply patch 2. Go to Reports and create a report from SQL select * from items where homebranch in <> and itype in <> 3. Run the report making multiple selections for each parameter and making single selections for each parameter 4. Run the report making multiple selections for one parameter and no selections in another parameter 5. Check that the results are as you would expect 6. On the results page click 'Show SQL code' 7. Confirm that the codes are included according to your selections 8. Note that when no selections are made for a parameter all codes are used by defaut Sponsored-by: CLAMS Signed-off-by: Michaela Sieber Signed-off-by: Pedro Amorim Signed-off-by: Katrin Fischer commit 34870b7d6a7f9b2e2aa5987e612db103964146c0 Author: Janusz Kaczmarek Date: Mon Mar 31 14:03:50 2025 +0000 Bug 39500: Subfield 111 $n is badly displayed in OPAC (MARC21) If the main heading is 111 and id contains subfield $n, the content of this subfield is badly displayed in OPAC: at the beginning of the heading text (right after "By:"), and then correctly, as the part of the link. Test plan: ========== 1. Check if the 111 $n subfield is available in the framework you are using. If not, activate it (Editor checkbox). 2. Take any bibliographic record and replace the main heading with a conference heading (111), e.g.: 111 $a Annual Koha Hackfest $n (13 : $c Marseille : $d 2025) Control in OPAC that the $n subfield is displayed twice (first time at the beginning) 3. Apply the patch ; restart_all 4. Check the result in OPAC: the main heading should be displayed correctly now. Signed-off-by: Thomas Klausner Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer commit 6b8aeda66e8163d37ec726f125d659ba12023c43 Author: Marcel de Rooy Date: Tue Apr 15 13:27:23 2025 +0000 Bug 39624: (follow-up) Fix deleting the All line Test plan: Add a line for All categories. Delete it again. Check when refreshing the page. Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer commit ea73b35cf2c0409a129a910af4fd8b100b9bfb1d Author: Marcel de Rooy Date: Mon Apr 14 08:03:58 2025 +0000 Bug 39624: Add patron category * (All) to open_article_requests limit Test plan: Go to smart rules. Add a limit for All. Refresh and check if it is still there. Enable ArticleRequests and verify if the limit is working. Signed-off-by: Marcel de Rooy Signed-off-by: Brendan Gallagher Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer commit 663830d9edfd50637d8bf71ce959f2001b57de92 Author: Marcel de Rooy Date: Fri Apr 18 09:51:30 2025 +0200 Bug 25015: (QA follow-up) Slide together We do not need 1 or 0 here btw. We just check for true. Signed-off-by: Katrin Fischer commit 6bfcd23bdbf00f55b5402ccc5f65429af7494700 Author: Emily Lamancusa Date: Fri Mar 21 09:42:25 2025 -0400 Bug 25015: Allow staff with edit_items permissions to edit fast add items To test: 1. Set up a user with only catalogue and edit_items permissions 2. Create a Fast Add record with item a. Go to Cataloging b. Click on Fast Cataloging c. Fill in mandatory fields and save the record d. Fill in mandatory item fields and click Add item 3. Log in as the user you set up in step 1 4. Search for the record you created in step 2 5. Click Edit > Manage items in the menu at the top of the record ==> You do not have permission to access this page! 6. Go back to biblio record page 7. Apply patch and restart_all 8. Click Edit > Manage items again ==> Edit items page loads normally 9. Make a few edits and confirm that they save correctly Signed-off-by: Phil Ringnalda Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer commit 44b50d9d4406806688bb8a73e5ea3d5746d99a23 Author: David Cook Date: Mon Apr 14 23:50:48 2025 +0000 Bug 39635: Update required version for List::MoreUtils in cpanfile This change updates the required version for List::MoreUtils following the inclusion of "zip6" function introduced in List::MoreUtils version 0.423 Signed-off-by: Brendan Gallagher Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer commit 59ced52d8bde99070061277b59fdd3dd1ddfa065 Author: Katrin Fischer Date: Tue Apr 22 06:45:37 2025 +0000 Bug 39374: DBRev 24.12.00.025 Signed-off-by: Katrin Fischer commit d53f82ce888a08062773d2a8f58d9962ce52b64f Author: David Cook Date: Thu Mar 20 02:05:26 2025 +0000 Bug 39374: Database changes Signed-off-by: Brendan Gallagher Signed-off-by: Baptiste Wojtkowski Signed-off-by: Katrin Fischer commit 8e9a3d851d21429b583e69b5b3c88bd253899d89 Author: David Cook Date: Thu Mar 20 01:41:26 2025 +0000 Bug 39374: Add feature to block sending of lists from OPAC This change adds a system preference OPACDisableSendList which disables the ability to send lists from the OPAC, and hides the "Send list" link on the opac-shelves.pl page. This is useful in situations where you do not want OPAC users to be able to generate emails to arbitrary addresses with arbitrary comments. Test plan: 0. Apply the patch and koha-plack --restart kohadev 1. Create a public list with at least one record and view it in the OPAC 2. Click "Send list" and note you can fill out boxes for "Email address" and "Comment" 3. Change syspref OPACDisableSendList to "Don't allow" and click "Send list" again 4. Note the popup window now says "You do not have permission to send this list." 5. Reload the list web page and notice "Send list" no longer appears on the toolbar next to "Print list" Signed-off-by: Brendan Gallagher Signed-off-by: Baptiste Wojtkowski Signed-off-by: Katrin Fischer commit 8538c885f620d9ff50852b2042280f1348fcfa7a Author: Pedro Amorim Date: Thu Apr 17 08:42:25 2025 +0000 Bug 39663: Fix header element for Patrons Commit https://github.com/Koha-Community/Koha/commit/f42df40 renamed 'Members' to 'Patrons' but didnt adjust h3->h2 as it did with every other entry in this page Signed-off-by: Pedro Amorim Signed-off-by: David Nind Signed-off-by: Katrin Fischer commit 248013a2a96ab363d032d486529c666332491907 Author: Baptiste Wojtkowski Date: Wed Mar 12 14:42:42 2025 +0100 Bug 39317: Fix CSRF protection for letters TEST PLAN: 1 - go to /cgi-bin/koha/tools/letter.pl 2 - click on New notice -> claim serial issue (or any other one) 3 - Fill required fields with random string 4 - Save -> if it breaks, go to 5 - Open a network panel (F12 -> network) 6 - Filter on letter.pl 7 - Fill another new notice -> the arguments of the form page have been passed in the address of the POST request. 8 - Apply patch 9 - Repeat the whole process and see it works now Signed-off-by: Magnus Enger I can't recreate the problem, but the change seems sensible enough and does not seem to introduce a regression, I can still save a new letter/notice. Signed-off-by: David Cook Signed-off-by: Katrin Fischer commit 4a6d097c310285a35c14803542c88d869789ce27 Author: Andreas Roussos Date: Mon Mar 31 14:17:42 2025 +0000 Bug 39501: add "value=" attributes to the HTML select element In the current main branch, when linking authorities with other authorities, if you select a relationship you no longer get the associated letter (i.e. the "relationship code") copied to the appropriate subfield. Rather, the whole description gets copied. This patch fixes that. Test plan: 0) [PREREQUISITES in order for the authority finder plugin to come up] a) You must have at least one authority type besides the 'Default'. b) View the MARC structure of the 'Default' auth type, then click on 'Actions->Subfields' for tag 500; click on 'Edit subfields'. Select the subfield 'a' tab, then pick an auth type from the 'Thesaurus:' dropdown menu; click 'Save changes' at the top. 1) In the Staff client, go to Authorities, then click 'New Authority' and pick the 'Default' authority type (or edit an existing auth). 2) When the authority editor comes up, go to tag 500 and expand it. 3) Click on the ellipsis (...) next to subfield $a. 4) When the authority finder comes up, search for an authority, pick a relator code from the 'Special relationship:' dropdown, and then click on the 'Choose' button for one of the authorities you found. 5) Notice that the whole description for the relationship you selected gets copied (instead of just the single letter relationship code). 6) Apply this patch. 7) Repeat steps 1-4. Notice that, this time, only the relationship code gets copied over. Signed-off-by: Laurence Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer commit 715006bd86a5f73936a373f3140daa18bcd9e2b6 Author: Owen Leonard Date: Mon Mar 10 16:23:02 2025 +0000 Bug 39274: Non public notes are low contrast in the issues table - Previous checkouts This patch reflects some rethinking on my part about how the Bootstrap color classes are meant to be used, and makes some changes which I hope will be more consistent with the Bootstrap 5 documentation while keeping our interface usable. The main difference is in the use of the classes "text-bg-*" and "bg-*-subtle." For example the class "bg-info-subtle" will give an element a subtle colored background. "text-bg-info" will have a more saturated background color. The "text-" part of the class is a reference to the fact that elements with that category of classes will have text color which adapts to provide correct contrast. This patch also makes a minor adjustment to the color used for "warning" type elements (e.g.
. I've adjusted the color slightly in order to differentiate it from the "primary" class color we use for submit buttons. To test, apply the patch and rebuil the staff interface CSS. Clear your browser cache if necessary. Checkouts: 1. Have an item with a non-public note. 2. Check it out, it looks fine while under "Today's issues" 3. Set the issuedate to some time in the past `update issues set issuedate = '2025-03-04 15:58:46';` 4. The non-public note should appear in legible red. Return claims: 1. The "Claims" tab on the patron detail and checkout pages already used the "text-bg-*" classes but the "-success" class didn't work well with the tab background color so I removed it. I notice there is a bug in the way the classes change as the tab is activated, but that will have to be dealt with on another bug. Bibliographic details: 1. Place at least one hold and at least one article request on a title. 2. The detail view should show "Holds: 1", and "Article requests: 1" with the numbers in legible Bootstrap badges. Holds: 1. Perform a catalog search which will return multiple titles. 2. Select multiple titles and click "Place hold." 3. Select a patron to place a hold for. 4. Confirm the holds by clicking "Place hold." 5. The holds should now be shown under the heading "Existing holds," with Bootstrap badgets showing the hold count on each. Patrons requesting modification: 1. Submit an update to a patron record via the OPAC. 2. On the patrons home page in the staff interface there should be a "Patrons requesting modifications" link at the top, with a count of pending modifications shown in a Bootstrap badge. Check-ins: 1. Check in an item from a patron account with multiple other checkouts. 2. In the table of checked-in items the patron's remaining checkout count should be shown in a Bootstrap badge. SMTP servers: 1. Go to Administration -> SMTP Servers. 2. Edit at least one server so that debug mode is enabled and it is marked as a default server. 3. In the view of servers, the debug mode and default status should be shown in Bootstrap badges. Plugins: 1. Go to Administration -> Plugins. 2. Upload a plugin if necessary, and check the list of installed plugins when the plugin is disabled and when it is enabled. In both cases the status should appear in a Bootstrap badge. About page: 1. Go to the About page. 2. Under the "Server information" tab, the status of Memcached and Message broker should be shown with a background color--pale blue for okay statuses. Tools home page: 1. If necessary, go to the OPAC and submit at least one comment on a bibliographic record and tag at least one record. 2. In the staff interface, on the Tools home page, the number of tags pending approval and the number of comments awaiting moderation should show in Bootstrap badges. Sponsored-by: Athens County Public Libraries Signed-off-by: Andrew Fuerste Henry Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer commit 9f16b085b5b4c7fedc18b92a902527a931b66821 Author: Lucas Gass Date: Sun Mar 30 07:11:36 2025 +0000 Bug 39484: Fix external sounds in self checkout module To test: 1. Enable AudioAlerts 2. Set something up in the SCO to play a sound from an external source. ( I used #sco_main as my selector ) 3. Go to SCO and try to trigger the sound, nothing plays. 4. APPLY PATCH 5. Try steps 2 and 3 again, this time you should hear the sound from an external source. Signed-off-by: Andrew Signed-off-by: Brendan Lawlor Signed-off-by: Katrin Fischer commit 198f9d77385c8a33896f8ccdbc176e5325307673 Author: Alexander Blanchard Date: Mon Apr 7 11:33:02 2025 +0000 Bug 39490: Table Columns Missing Headings An accessibility audit highlighted that the purchase suggestions and search history tables in the 'My Account' section do not have headings in the tickbox column. The report suggests headings should be added to support those using screen readers. To Test: 1) In the opac, navigate to 'Your Account' 2) Navigate to 'Purchase Suggestions' 3) Add a purchase suggestion if you currently have none 4) Note that the left column does not have a heading and you cannot tab to it 5) Navigate to 'Search History' 6) Note, you must have searched the catalogue at least once for this table to display 7) Note that the left column does not have a heading and you cannot tab to it 8) Apply the patch 9) Repeat the steps above 10) Note that the tables now have a tooltip with information relevant to the column 11) Note that this column heading can now be tabbed to Signed-off-by: Brendan Gallagher Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer commit 9292b076ac164dc9a2b3d33f433783f651731ae4 Author: Fridolin Somers Date: Mon Apr 14 16:21:39 2025 +0200 Bug 39626: Use patron-title.inc in pendingreserves.tt In "Holds to pull" page, patron column should use patron-title.inc like in other pages (like waiting holds). This allows to use surname first to allow better sorting/finding. Test plan : 1) Place an hold on some record 2) Go to Circulation > Holds to pull 3) Check you see in column "First patron" : surname then firstname Signed-off-by: Emmanuel Bétemps Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer commit 342c1d599391035efa7ab52b754ceb7f35e12d16 Author: Nick Clemens Date: Tue Mar 11 11:08:26 2025 +0000 Bug 39301: pseudonymize_statistics.pl script generates too many background jobs This patch changes the script to use 'Koha::PseudonymizedTransaction->new_from_statistic' directly rather than calling 'Koha::Statistic->pseudonymize()' which generates a background job. Additionally, some of the checks from 'pseudonymnize' and the background job are moved into the search so we don't fetch any to pseudonymize that should not be. To test: 1 - Generate some entries in statistics (checkin, checkout, renew, etc) 2 - Enable pseudonymization (see bug 28911 if you need bcrypt settings) 3 - perl misc/maintenance/pseudonymize_statistics.pl -v -c 4 - Statistics pseudonymized 5 - Check the background jobs table, note jobs were generated 6 - Apply patch 7 - perl misc/maintenance/pseudonymize_statistics.pl -v -c 8 - You get same count as before, and are warned of existing pseudonymized transactions 9 - enter 'Y' to continue 10 - Check the pseudonymized_transacations table 11 - Confirm same rows were generated twice 12 - Check the background jobs 13 - Confirm there were no new jobs generated (for pseudonymization) Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer commit 13b813a4f975e9aff7a46959e95aaaad7d42795f Author: Andrew Fuerste Henry Date: Thu Mar 13 13:32:59 2025 +0000 Bug 39321: Hide subfield tag information for control fields in bib and authority editing This applies only to the basic editor, but for both bibs and authorities To test: 1 - Open a bib in the basic editor, see that the control fields show the subfield tag value label and that the value of 00 is slightly cut off in the display 2 - Open an authority in the basic editor and confirm same 3 - apply patch 4 - reload your records and see that the subfield value and label are now hidden for control fields in both bib and authrority editing Signed-off-by: Phil Ringnalda Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer commit 42ec5d36c2364ee709e7b63c5c19a777031f74c6 Author: Lukas Koszyk Date: Mon Feb 17 08:39:04 2025 +0000 Bug 38760: Add support for database connection encryption parameters in koha-mysql The koha-mysql didn't work when the instance was set up to use an encrypted database connection. Please note: this testplan is for ktd, not for a production environment! Unfortunately, there are some issues with the database TLS configuration in koha-testing-docker. This is described comment 14 of bug 36026 (https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36026#c14) As a workaround, you can add "mysql_ssl_optional=1" in Koha/Database.pm. See point (g) in comment 15 of bug 36026 (https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36026#c15) Testing Database Connection Encryption: 1. Apply the patch. 2. Configure koha-conf.xml to use a TLS connection (see comment 10 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36026#c10, follow steps 3a-g + 4 ) 3. Run: koha-mysql 4. Verify that the MySQL console opens successfully. 5. Check the encryption settings in the MySQL console: - run: SHOW VARIABLES LIKE '%ssl%'; - run: STATUS; Ensure that the following conditions are met: - have_openssl and have_ssl are set to "YES". - The SSL cipher in use is displayed. Testing MySQL Timezone Configuration: 1. Apply the patch. 2. Configure the timezone in koha-conf.xml, for example: Antarctica/South_Pole 3. Run: koha-mysql 4. Verify that the MySQL console opens successfully. 5. Check the timezone setting in the MySQL console by running: SELECT @@session.time_zone; 6. Confirm that the output matches the timezone configured in koha-conf.xml. Sponsored-by: Karlsruhe Institute of Technology (KIT) Signed-off-by: Jan Kissig Signed-off-by: Thomas Klausner Signed-off-by: Katrin Fischer commit 19d51a7f363b499be0940e544eeb30774976de4f Author: Owen Leonard Date: Mon Feb 3 13:40:15 2025 +0000 Bug 39015: Fix sorting by date on cash register statistics page This patch adds a "data-sort" attribute to the columns in the results table which contain dates. This allows DataTables to sort using the unformatted date. The patch also adds the "anti-the" class to the column containing titles, ensuring that the sort excludes articles. To test, apply the patch and go to Reports -> Statistics wizards -> Cash register. You must have multiple entries in the results, which could be generated by using the "Create manual invoice" form under a patron's account tab. Unfortunately that won't create entries with multiple dates to sort on. I assume a proper test will require some manual SQL updates. To test title sorting you should have some transactions which are tied to an item. To generate this data: - Set the 'WhenLostChargeReplacementFee' system preference to "Charge" - Add a replacement cost to some items in the catalog. - Check those items out ot a patron. - From the "Item details" tab for those records, mark each item lost. - The charges should now be on the patron's account. - On the Cash register statistics page, submit the form using parameters which will return multiple results. - Test that the "Transaction date" and "Updated" columns work correctly with various settings of the "dateformat" system preference. - Test that the "Bibliographic record title" column sorts correctly, excluding initial articles (a, an, the) from the sort. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind Signed-off-by: Baptiste Wojtkowski Signed-off-by: Katrin Fischer commit 77079b17ef8b6de25a32bb99d4df4a1c16c0c6fa Author: Jonathan Druart Date: Wed Apr 2 13:44:03 2025 +0200 Bug 38984: Uniformize noSort NoExport NoExport Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 739adc5593f1f9ef685d8047c93fe166d1bc99c5 Author: Owen Leonard Date: Fri Feb 7 17:19:15 2025 +0000 Bug 38984: (follow-up) Replace obsolete "paginate" option with "paging" Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 476a991376431d070339a429cde8d944fe3ded30 Author: Owen Leonard Date: Fri Feb 7 16:44:06 2025 +0000 Bug 38984: (follow-up) Fix nosort class on first column Changing "nosort" to "NoSort". Also adding an "order" option to the table configuration so that the table isn't sorted by default on the first column (overriding the NoSort option). Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 6a9716c00dd0ef0b9807e351295cf9216e28f054 Author: Owen Leonard Date: Fri Feb 7 12:26:15 2025 +0000 Bug 38984: (follow-up) Fix syntax error in invoice-files table Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit a39d1e2421588ea0c6aa99c9523b1cb1d3ca0774 Author: Jonathan Druart Date: Tue Jan 28 11:45:49 2025 +0100 Bug 38984: Specific - tools/batch_extend_due_dates.tt Why no sort on item type? Why no sort on #checkouts_result? Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit acfd7223e2763dcad7344083d96de37970bd8332 Author: Jonathan Druart Date: Tue Jan 28 11:40:22 2025 +0100 Bug 38984: Also make 'Actions' translatable Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit a57e1ca90bdb60c00a4e93b9df0815fdc4ba5bc0 Author: Jonathan Druart Date: Tue Jan 28 11:33:50 2025 +0100 Bug 38984: Allow sort on all fields - club-enrollments it does not make sense to remove sorting only for the last 2 fields Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit af48a917fcd884d2fd9e910dd2e81b22ac465c03 Author: Jonathan Druart Date: Tue Jan 28 11:32:21 2025 +0100 Bug 38984: Add NoSort when can replace targets In those occurrences we can simply use NoSort. It fixes some bugs, where the display of the column depends on some pref's values Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 9b39cddab31e1816b26989fc5d882d333bcf30c3 Author: Jonathan Druart Date: Tue Jan 28 11:05:39 2025 +0100 Bug 38984: Remove anti-the Same as previouly for anti-the Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit b3650372fe454b8ae559e1064b01467e58568a0a Author: Jonathan Druart Date: Tue Jan 28 10:56:41 2025 +0100 Bug 38984: Replace nosort with NoSort We don't need nosort and NoSort, use NoSort everywhere Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer