commit d194f195b9623aea50c4f7ade865583b2edcd1bb Author: Tomás Cohen Arazi Date: Thu May 22 10:51:43 2025 -0300 Bug 37334: Adjust mocked _status data (bug 39932 follow-up) Signed-off-by: Tomas Cohen Arazi commit 7045e6b558d2a2c5d18c2cc93a31f85296dbe9d8 Author: Katrin Fischer Date: Tue May 20 14:51:08 2025 +0000 25.05.00: Update .mailmap Signed-off-by: Katrin Fischer commit fa557624e98d4beaed2cff1ea019edaa8b1be27a Author: Owen Leonard Date: Mon May 19 11:16:43 2025 +0000 Bug 39680: "Clear" menu item doesn't delete search history This patch fixes the behavior of the OPAC's "Clear" link, which was not updated to work with CSRF protection. To test: - If necessary, go to Administration -> System preferences in the staff interface and set the EnableOpacSearchHistory preference to "Keep." - Log in to the OPAC. - If necessary, perform several catalog searches in order to populate your search history. - Expand the user menu in the upper right-hand corner and click the "Clear" link next to "Search history." - You should be prompted to confirm. - After confirming your search history should be empty. Sponsored-by: Athens County Public Libraries Signed-off-by: Roman Dolny Signed-off-by: Julian Maurice Signed-off-by: Katrin Fischer commit 4564ed5ef1c63551b0cffc8416d3033b23f4fc1e Author: Martin Renvoize Date: Mon Apr 28 09:57:07 2025 +0100 Bug 39754: Enable fixed height and overflow on EDIFACT dropdown This patch updates the 'Create EDIFACT order' menu dropdown for cases where multiple EANs are available for the library. We set the dropdown to a max-height of 75% of the window height and then we enable y scrolling and hide the x scrollbar. Signed-off-by: Nick Clemens Signed-off-by: Paul Derscheid Signed-off-by: Katrin Fischer commit fdf3b4e799857b2bd9221ced67fa6f88905dff59 Author: Owen Leonard Date: Wed May 21 15:34:10 2025 +0000 Bug 39957: Fix JS error on credit and debit types administration pages This patch fixes an JS error in several administration pages, introduced by Bug 39099 and 39810. We can't access a DOM node without checking for its existence first. To test, apply the patch and go to Administration. - Check the following pages: - Authorized values - Credit types - Debit types - Item types - Patron categories. - On each page check the JavaScript console on the initial page. There should be no errors. - Check the add/edit page for each and confirm that the library limitation Select2 widget works correctly. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind Signed-off-by: Katrin Fischer commit d7af2cacff2692c803579117953f3cd13c94c878 Author: Katrin Fischer Date: Tue May 20 13:11:47 2025 +0000 Bug 26869: (QA follow-up) Fix missed sysprefs.sql Signed-off-by: Katrin Fischer commit f51ec304382e5ec83afd898eef0f6bae622a3190 Author: Matthias Meusburger Date: Tue May 20 09:53:52 2025 +0000 Bug 38142: (follow-up) Choose language to report from authority to bibliographic record - Rename LanguageToReportOnMerge system preference to LanguageToUseOnMerge - Use "use" instead of "report" in system preference description - Mark this feature as UNIMARC-only. Signed-off-by: Katrin Fischer commit 0c027e9db11c90ffb0ef23efe8f85ed7a8aed680 Author: Matt Blenkinsop Date: Tue May 20 09:22:24 2025 +0100 Bug 30301: (follow-up) Fix API spec Signed-off-by: Katrin Fischer commit fb2136bc293508d9f3dbb533dc3c4ae3e4221d58 Author: Jonathan Druart Date: Tue May 20 14:27:15 2025 +0200 Bug 37334: Fix conflict with bug 39473 Bug 39473 added ^ and $ to options of the dropdown lists from the column filters. They are removed and replaced with "exact" later in the code (using build_query). But in the case of "_status", we do no get this code as it's not a regular column (it does not have "data" attribute), but an additional filters. I don't think this fix is ideal, but we are too close to the release to rework datatables.js Signed-off-by: Katrin Fischer commit c184893a5337962a0622b9cd58bf09ccb3d8479b Author: Raphael Straub Date: Thu Apr 3 09:55:02 2025 +0000 Bug 39540: Add a warning to the circulation rules page if CalcFine is overwritten. This patch adds a warning to the "Circulation and fine rules" page in "Koha administration" if there is an enabled plugin that implements the overwrite_calc_fine plugin hook. To test: 1) Apply the patch. 2) In your browser go to /cgi-bin/koha/admin/smart-rules.pl and check that there is no warning on the top of the page. 3) Install a plugin that implements overwrite_calc_fine. 4) Reload /cgi-bin/koha/admin/smart-rules.pl and check that now there is a warning that displays the installed plugin's name. Sponsored-by: Karlsruhe Institute of Technology (KIT) Signed-off-by: Roman Dolny Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 8d9bdbde076f0d622178a273a2db9dedfa281a76 Author: Tomás Cohen Arazi Date: Mon May 19 08:58:17 2025 -0300 Bug 39932: Remove split in template Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 4609ffd7156bfe64cb5f337acc0b7a2eb76b20b9 Author: Tomás Cohen Arazi Date: Sat May 17 09:30:41 2025 -0300 Bug 39932: Add POD for Koha::Item->_status() Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit ffab355be08f8c70decab98af33f00a462c9cfd1 Author: Tomás Cohen Arazi Date: Mon May 19 08:57:27 2025 -0300 Bug 39932: Make Koha::Item->_status return an arrayref This patch makes the method return an actual array instead of a comma-separated string. The API spec is adjusted so it also expects an array in the response. Tests are adjusted for the new return value. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ yarn api:bundle k$ prove t/db_dependent/Koha/Item.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit d17f6552a1ce6d905a284b2411075ae54bd1199b Author: Katrin Fischer Date: Mon May 19 16:28:53 2025 +0000 Bug 30301: DBRev 24.12.00.046 Signed-off-by: Katrin Fischer commit 32b829ace176dc5412b276eca1e096eb262e1026 Author: Nick Clemens Date: Fri May 16 13:10:01 2025 +0000 Bug 30301: (QA follow-up) Restore terminology in messaging preferences Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer commit 0f2b79c44457bfbe8faebe0ce3b9ba0a3b531292 Author: Matt Blenkinsop Date: Fri May 16 13:44:36 2025 +0100 Bug 30301: (QA follow-up) Restore correct terminology and add to columns settings Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer commit 9a57c7c8f84af9d24780594d8b9052ca44669163 Author: Matt Blenkinsop Date: Thu Apr 17 16:16:39 2025 +0100 Bug 30301: Allow for forcing of print notices Although we're reverting 32216, we still want to be able to force print notices as per the original intent. This patch adds that into queue_notices, rather than in the cronjob Co-authored-by: Jake Deery Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer commit 9b5da196c47efcd53f6aa5544b35d98d99f3cefa Author: Matt Blenkinsop Date: Thu Apr 17 15:41:09 2025 +0100 Bug 30301: Restore check for mandatory notice Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer commit c54a14a43f39eda320d09e2a18768ecd2d07e0a4 Author: Matt Blenkinsop Date: Thu Apr 17 15:37:20 2025 +0100 Bug 30301: Revert "Bug 32216: Add print notices to membership_expiry.pl" This reverts commit 3040f46d5efc73454e6a1558891a65ae8b0ea2c0. Bug 30300 adds a patron messaging preference for the expiration notice and abstracts this logic into queue_notice Bug 32216 removes this call to enable print notice functionality but this would be handled already by queue_notice based on the patron's messaging preferences Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer commit db9f3126ef94c593f54eeea224fe6713d07e376f Author: Matt Blenkinsop Date: Tue Dec 3 16:51:46 2024 +0000 Bug 30301: Update cronjob to check for mandatory notice The patches on this bug add the ability for staff members to set the patron expiry notice as mandatory at the category level. When set, the cronjob will automatically send an expiry notice regardless of existing messaging preferences. If it is turned off, the old messaging preferences will still be in place and actioned Test plan: 1) Apply patch and run updatedatabase 2) In system preferences set MembershipExpiryDaysNotice to 5 3) Choose a patron and edit their expiry date to today's date, ensuring they have a primary email set 4) Create a MEMBERSHIP_EXPIRY notice (content of the notice is irrelevant, just needs to exist) 5) Run perl misc/cronjobs/membership_expiry.pl -c -v -before 10 -after 10 6) Check the patron's messages, there should be no expiry notice queued 7) Set the patron's category 'enforce expiry notice' field to Yes 8) Repeat step 5, there should be a notice queued 9) Set that patron's primary contact method to primary email and run step 5 again 10) There should be a notice queued for an email 11) Set the category level enforce expiry notice back to No 12) Choose a second patron and set an email address, expiry date to today and set the patron expiry messaging preference for that patron to 'email' 13) Repeat step 5 - this time only one notice should be queued on the second patron, no new notice should queue for the first 14) Re-set the category level option to Yes 15) Repeat step 5 - this time both patron's should have notices queued 16) Unset the category level option again, the behaviour should be the same as step 13 17) Set the category level option back to Yes and check the patron messaign preferences menus in both the OPAC and Staff client - the patron expiry option should not be visible while the cateogry level enforcement is set to Yes Signed-off-by: Hanna Leiker Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer commit 84076d5169e295dcc114b9277bdbbec2ed0a275d Author: Matt Blenkinsop Date: Tue Dec 3 16:51:14 2024 +0000 Bug 30301: Update templates Signed-off-by: Hanna Leiker Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer commit a319d7052b45c9f22d2fa39326b93c94a95cd6a2 Author: Matt Blenkinsop Date: Tue Dec 3 16:50:59 2024 +0000 Bug 30301: DBIC file Signed-off-by: Hanna Leiker Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer commit c882117b95e14c8d0e365c06df7bfd43b0cefebe Author: Matt Blenkinsop Date: Tue Dec 3 16:50:43 2024 +0000 Bug 30301: Add a new column to enforce the expiry notice Signed-off-by: Hanna Leiker Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer commit c0b3310ab8a6d0700bcd858da0fb2e3973f28189 Author: Janusz Kaczmarek Date: Tue Apr 1 14:16:04 2025 +0000 Bug 38925: Update record 'date entered on file' when duplicating a record -- in advanced editor (MARC21) With Bug 36552 we set 'date entered on file' (MARC21: 008/0-5) of a record created by duplication of an existing record to the current date instead of having there the value from the original record. The same should be done for the advanced editor (for now, it retains the date of the original record). Test plan: ========== 1. Enable EnableAdvancedCatalogingEditor systempreference. 2. Open any record in advanced editor to make it default. Go back to record normal display. 3. Make a duplicate: Edit > Edit as new (duplicate) 4. Note that the date in 008/0-5 is of the original record, not of today. 5. Apply the patch ; restart_all. 6. Repeat p. 3. The date in 008/0-5 should be of the today. If not, refresh browser's cache (Ctrl+Shift+R etc.) to get the fresh version of the JS. Signed-off-by: Roman Dolny Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer commit b37d107aa306f76a65a2a2d6927683621e8190f0 Author: Hammat Wele Date: Wed Jul 31 21:29:16 2024 +0000 Bug 35434: (follow-up) Unit test Test plan: 1. Tests should pass: prove t/db_dependent/Koha/Item.t Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer commit 03fc8b4057224c666eb35fd72f6fec127337d8dc Author: Hammat Wele Date: Wed Jul 31 21:28:41 2024 +0000 Bug 35434: (follow-up) Added canreservefromotherbranches When IndependentBranches is enabled, canreservefromotherbranches set to don't allow is also required to prevent non-superlibrarians from placing holds in other libraries. Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer commit 15988d1a6a03efdc7043a049e0a79d2d85300fda Author: Emily-Rose Francoeur Date: Wed Nov 29 10:42:54 2023 -0500 Bug 35434: Prevent non-superlibrarians from placing holds in other libraries when using IndependentBranches When IndependentBranches is enabled and canreservefromotherbranches is set to don't allow, then non-superlibrarians should not be able to place holds for other libraries. Test plan: 1. Appy the patch. 2. In Koha administration > System preferences, set: - IndependentBranches: Yes - canreservefromotherbranches: Don't allow 3. In Koha administration > Circulation and fines rules, check that you have a rule for all patron categories and all item types, with unlimited holds. 4. Find (or create) a staff patron for a library other than Centerville: - Change the username and password so you can log in as the staff patron. - Add permissions to the staff patron (More > Set permissions): . Staff access, allows viewing of catalogue in staff interface . Add, modify and view patron information . Place and modify holds for patrons 5. Find (or create) a patron with the same home library as the staff patron in step 4. 6. Find (or create) a record with an item where the home and current library are the same as the staff patron in step 3 and the patron in step 5. 7. As a superlibrarian place a hold for the record from step 6 using the patron from step 5: - If placing a hold for the next available item, the "Pickup at" dropdown list should list all libraies. - If placing a hold on a specific item, the dropdown list for the "Allowed pickup locations" column for each item should also list all libraries. - After placing the hold, in the "Existing holds" table, the dropdown list for each hold in the "Pickup library" column should also list all libraries. 8. Log out from the staff interface and login with the staff patron from step 4. 9. Find the record from step 6 and place a hold using the patron from step 5 - the library dropdown list should be limited to the item's home library: - If placing a hold for the next available item, the "Pickup at" dropdown list should only list the item's home library. - If placing a hold on a specific item, the dropdown list for the "Allowed pickup locations" column for each item should also only list the item's home library. - After placing the hold, in the "Existing holds" table, the "Pickup library" column should now only show the item's home librayr, with no dropdown list. Signed-off-by: Anni Rajala Signed-off-by: baptiste Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer commit 8dfb19a45a1ff513c2a73e198840e9f579631a2c Author: Jonathan Druart Date: Wed Mar 12 16:20:00 2025 +0100 Bug 34070: Display the 'jobs will be processed anyway' message from worker ->connect does not raise an exception, so we didn't reached the catch block. Adjusting the code but I am not really happy with it, but more changes will derail the original bug Now we log: Cannot connect to broker (Access refused for user 'guest') at /kohadevbox/koha/Koha/BackgroundJob.pm line 96. Cannot connect to the message broker, the jobs will be processed anyway at /kohadevbox/koha/misc/workers/background_jobs_worker.pl line 100. Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer commit 6ee689c7c6688002fc59ffed47b5f86a266f5477 Author: Jonathan Druart Date: Mon Mar 10 11:22:23 2025 +0100 Bug 34070: Add tests Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer commit c407ce021e84127a6ca93e8d4c6c2348ace5a93a Author: Jonathan Druart Date: Mon Mar 10 10:54:25 2025 +0100 Bug 34070: Deal with broker connection issues This patch suggests to deal with connection issues at Koha::BackgroundJob->connect level. It incorrectly returned a Net::Stomp object when the connection failed. With this patch, if the CONNECT does not return a CONNECTED frame then Koha::BackgroundJob->connect returns nothing and the caller is not fooled. It also fixes the about page, we now have: "Using SQL polling (Fallback, Error connecting to RabbitMQ)" instead of "Using RabbitMQ" Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer commit 4dc4a232c4ad282f126b5c963812724944d8dbed Author: David Cook Date: Fri Mar 7 01:43:25 2025 +0000 Bug 34070: Add error handling for ERROR frames for background worker This change adds error handling for ERROR frames to background_jobs_worker.pl. A previous patch added it to es_indexer_daemon.pl which is a different background jobs worker. To test ERROR handling for background_jobs_worker.pl: 1. Change your RabbitMQ connection details in koha-conf.xml or the hard-coded ones in Koha/BackgroundJob.pm to include an invalid password. For example, if you don't have a message_broker already defined, use the following: bad 2. sudo koha-worker --restart --quiet kohadev 3. View the errors in the logs: tail -f /var/log/koha/kohadev/worker-output.log tail -f /var/log/koha/kohadev/worker-error.log To test MESSAGE handling for background_jobs_worker.pl: 1. Ensure RabbitMQ connection details are correct 2. Go to Batch item modification and add the following barcodes: 39999000001310 39999000004571 3. Add a z - Public Note of the following and click Save: THEBACKGROUNDWORKERWORKED 4. Search the catalogue using THEBACKGROUNDWORKERWORKED in the top catalogue search 5. Note that you get 2 results in your search 6. Look in the logs just to make sure there are no new messages there Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer commit 2c1314ead6a0abbfbbbbf1e7a8a85df218b58c93 Author: David Cook Date: Fri Feb 14 02:39:28 2025 +0000 Bug 34070: Add error handling for ERROR frames This change causes es_indexer_daemon.pl to die on ERROR frames instead of spinning in an infinite loop. It also adds a content-type STOMP frame header to help consumers know what data type is in the MESSAGE frame body. To test ERROR handling for es_indexer_daemon.pl: 1. Switch to using Elasticsearch 2. Change your RabbitMQ connection details in koha-conf.xml or the hard-coded ones in Koha/BackgroundJob.pm to include an invalid password. For example, if you don't have a message_broker already defined, use the following: bad 3. sudo koha-es-indexer --restart kohadev 4. View the errors in the logs: tail -f /var/log/koha/kohadev/es-indexer-output.log tail -f /var/log/koha/kohadev/es-indexer-error.log To test MESSAGE handling for es_indexer_daemon.pl: 1. Switch to using Elasticsearch (and ensure RabbitMQ connection details are correct) 2. Change the title of a bib record to something new and unique 3. Try to search for the bib using the new title 4. Note you can find it 5. Look in the logs just to make sure there are no messages there Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer commit d669cab7a2c149c40cba8333f926fa7bfe8ec830 Author: Matt Blenkinsop Date: Mon May 19 08:39:59 2025 +0000 Bug 33430: (follow-up) Prevent anonymous suggestions from breaking the table Signed-off-by: Katrin Fischer commit 8a4394130b55b7105eacfe55886c795caa034c24 Author: Matt Blenkinsop Date: Mon May 19 09:27:10 2025 +0100 Bug 33430: (follow-up) Fix API spec terminology Signed-off-by: Katrin Fischer commit 097e6fa410985f2b1913da6db0548fc909cca50e Author: Matt Blenkinsop Date: Thu May 15 09:53:47 2025 +0100 Bug 33430: (follow-up) Handle undefined data in column renders Signed-off-by: Fridolin Somers Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer commit a0fec40b0237578e4782dd9541b02444ee7ded77 Author: Matt Blenkinsop Date: Wed May 14 11:00:09 2025 +0100 Bug 33430: (follow-up) Fix the data filtering from the left menu Signed-off-by: Fridolin Somers Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer commit b9c5a10a11b428b334884c82e38711def16107eb Author: Matt Blenkinsop Date: Tue May 13 16:25:42 2025 +0000 Bug 33430: (follow-up) Restore sorting to table Signed-off-by: Fridolin Somers Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer commit 1d469d59982cacf4cc7c66a7fd4cad71f39be605 Author: Matt Blenkinsop Date: Thu May 8 17:10:14 2025 +0100 Bug 33430: Enable datatables for suggestion tabs Test plan: 1) Either add loads of suggestions to your KTD or use the script in the data script patch uploaded to the bug 2) Navigate to Acquisitions > Suggestions 3) Depending on how many suggestions you have loaded (the script does 2000), the page will load very slowly 4) Apply patches 5) yarn build && restart_all 6) Hard refresh the page, the page should load much faster and the first tab should load a paginated datatable 7) Click into another tab, the tab should also load a paginated datatable 8) Click back into the first tab, the original table should persist and should not reload 9) Use the edit tools at the bottom of the page, they should work as expected 10) Click on the links in various table cells, they should redirect as expected 11) Use the actions buttons in the far right column, then should work as expected Signed-off-by: Fridolin Somers Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer commit 5e19c3fce195c8ba792469016cc6675f6308fef8 Author: Matt Blenkinsop Date: Thu May 8 11:05:05 2025 +0100 Bug 33430: Pass search parameters to the template This patch removes the existing process intensive searches and moves the search logic to a single group query that returns the values that will be the counts in the tabs. It then formats the parameters for each type and passes them to the template for the datatables ajax requests Signed-off-by: Fridolin Somers Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer commit 84ad0488e106eb1d58f9574026cca58f19dc333c Author: Matt Blenkinsop Date: Tue May 6 18:41:37 2025 +0100 Bug 33430: Update API specs to include required embeds Signed-off-by: Fridolin Somers Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer commit 31364ab89825310be21dc418f73ef8d7bcd84dc9 Author: Matt Blenkinsop Date: Thu May 8 11:02:29 2025 +0100 Bug 33430: Add strings_map method This patch adds a strings_map method to allow the API to return the required authorised values needed for table displays Signed-off-by: Fridolin Somers Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer commit 244ce5396bd34645597cc07c6d475e54d923575b Author: Jonathan Druart Date: Mon May 19 09:17:45 2025 +0200 Bug 38457: (follow-up) Update record_id to VARCHAR(80) Signed-off-by: Katrin Fischer commit d49e7392bcc13a1ecd19f81fa4a3686fafaf1ab6 Author: Aleisha Amohia Date: Thu May 15 04:49:10 2025 +0000 Bug 39406: Make serial issues sort from new to old on collection page This patch fixes the serial collection table to sort in descending order on the date published column. To test: 1. Create a subscription if you don't already have one. 2. Go to the Serial Collection tab using the left navigation. 3. Click the Generate Next button a bunch of times to generate some serial issues. Note that the issues are displaying in the table in ascending order, with the oldest date published at the top. 4. Apply the patch and refresh the page 5. Confirm the issues are now displaying in the table in descending order, with the newest date published at the top. 6. Click the Generate Next button again and confirm the issue is inserted at the top of the table. Sponsored-by: Pymble Ladies' College Signed-off-by: David Nind Signed-off-by: Katrin Fischer commit 0868f260c63e6bf439a9b1c2acccf7a1632ab8c6 Author: Emily Lamancusa Date: Fri May 16 16:14:22 2025 -0400 Bug 39904: (QA follow-up) Fix a few other cases Signed-off-by: Emily Lamancusa Signed-off-by: Katrin Fischer commit 26e7c07302842eaca9942ac7f0a74db5e3abd07f Author: Kyle M Hall Date: Wed May 14 14:52:07 2025 +0000 Bug 39904: EDIFACT error messages are malformed Perl can interpolate hashrefs but not method calls. This results in messages like "Cannot connect to Koha::Schema::Result::VendorEdiAccount=HASH(0xaaab059252f0)->host: Name or service not known: My Test at ./misc/cronjobs/edi_cron.pl line 58." when running the edi_cron.pl cronjob. Test Plan: 1) Enable EDIFACT 2) Create a fake EDI account with a bad FTP server in it 3) Run edi_cron.pl 4) Note the errors like: Cannot connect to Koha::Schema::Result::VendorEdiAccount=HASH(0xaaab059252f0)->host: Name or service not known: My Test at ./misc/cronjobs/edi_cron.pl line 58. 5) Apply this patch 6) Run edi_cron.pl 7) Note the errors are now like: Cannot connect to test.example.com: Name or service not known: My Test at ./misc/cronjobs/edi_cron.pl line 58. Signed-off-by: David Nind Signed-off-by: Emily Lamancusa Signed-off-by: Katrin Fischer commit 0bfad63507f62b857de4960ffcb39cb3b472d228 Author: Hammat Wele Date: Wed May 14 14:43:54 2025 +0000 Bug 39800: Error 500 when trying to delete patron card template Test plan: 1. Go to Tools > Patron card creator 2. Click Manage > Card templates 3. Click Delete next to the HB-PC0001 template --> Error 500 4. Go back to Tools > Patron card creator 5. Click Manage > Printer profiles 6. Click Delete next to the '16' printer profile --> Error 500 7. Apply the patch 8. Repeat step 1, 2, 3 --> Card template is deleted 9. Repeat step 4, 5, 6 --> Printer profilesis deleted Signed-off-by: Owen Leonard Signed-off-by: Emily Lamancusa Signed-off-by: Katrin Fischer commit 8c814d46d9d2aabc07b345dd167d29263e7713a6 Author: Emily Lamancusa Date: Fri May 16 16:01:44 2025 -0400 Bug 39914: (QA follow-up) Correct the footer colspan on the correct column Signed-off-by: Emily Lamancusa Signed-off-by: Katrin Fischer commit cdf88e023777c32455dc1e1206a3291422cd145f Author: Lucas Gass Date: Thu May 15 20:42:03 2025 +0000 Bug 39914: Correct the footer colspan To test: 1. Have some orders that are late. 2. Go to the late orders page ( http://localhost:8081/cgi-bin/koha/acqui/lateorders.pl ) 3. Try to use the export function, nothing happens. 4. APPLY PATCH 5. Try steps 1 and 3 again, this time the export function should work. Signed-off-by: Owen Leonard Signed-off-by: David Nind Signed-off-by: Emily Lamancusa Signed-off-by: Katrin Fischer commit d3469640f055fa4f65c1a5cf9c8b9db22a797a0c Author: Lucas Gass Date: Fri May 16 19:55:13 2025 +0000 Bug 37334: Update Holdings_spec.ts test Signed-off-by: Tomas Cohen Arazi commit 3a694bdf4236ab8d82a9aa4a22ec33bd7678d4dd Author: Owen Leonard Date: Tue May 6 12:40:56 2025 +0000 Bug 39099: (follow-up) Re-word library limitation hint Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer