commit ce0dc4d04de12fd4138299fbc35d8294d9d1aa6f Author: Matt Blenkinsop Date: Fri May 9 09:39:38 2025 +0100 Bug 38061: Add a checkbox to determine whether collection table issues should be pre-selected Test plan: Apply the patches and update the database 1) Create a new subscription with items, there should be a checkbox at the bottom of the form to pre-select collection table issues - make sure this is checked 2) Receive some items against the subscription 3) Navigate to the collections table 4) The checkboxes should be pre-selected as per previous behaviour in Koha 5) Edit the subscription and uncheck the checkbox 6) Return to the collections table and the checkboxes should all be unchecked commit e1887875544ccb8577dbb7e05bf971566b4bfccd Author: Matt Blenkinsop Date: Wed Oct 2 10:54:50 2024 +0000 Bug 38061: Remove pre-selection of serials in the table Test plan: 1) Navigate to the serials-collection table 2) None of the checkboxes in the left hand column should be selected Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: Nathalie commit 660965bfc1f581446bbcff01fe669dcdfcccb27a Author: Matt Blenkinsop Date: Wed Oct 2 09:59:30 2024 +0000 Bug 38061: Add item column to serial collections table This patch adds a column to the table to link to the item Test plan: 1) Add a new subscription to a serial record (with the option 'create an item record' selected) 2) Receive several issues and create the linked items 3) Navigate to the serials collection table 4) There should be a column for the linked item 5) Click on one of the links, it should display the item Signed-off-by: Nathalie commit a2f190f01f368ed715db2b28f768cacab114c715 Author: Emmi Takkinen Date: Thu May 8 12:37:18 2025 +0300 Bug 38356: (follow-up) Add code block to handle CURRENTISSUE message Package C4::SIP::ILS::Transaction::Checkout was missing block to handle new "CURRENTISSUE" message. This patch adds this block so tests should no longer fail. To test prove t/db_dependent/SIP/Message.t Signed-off-by: Katrin Fischer commit 6e01b1a731c8c884b586e8e890606c6b1bfb3a3e Author: Emmi Takkinen Date: Thu May 8 11:27:13 2025 +0300 Bug 38356: (follow-up) Fix failing Circulation.t tests After pushing bug 38356 to main, Circulation.t tests started to fail. Fail happened randomly and was related to sub is_serial trying to fetch biblios metadata. This patch changes the way test item is build in "CanBookBeIssued + needsconfirmation message" tests. It seems more reliable to use build_sample_item rather than building item using biblio and biblioitem data. To test prove t/db_dependent/Circulation.t. Signed-off-by: Katrin Fischer commit 69df45721a265c11933a1a478083a5ff2c0ef290 Author: Katrin Fischer Date: Thu May 8 06:22:13 2025 +0000 Bug 30200: DBRev 24.12.00.040 Signed-off-by: Katrin Fischer commit c2cfd92b3cde3cc52653d3f67e293893cde1a35f Author: Martin Renvoize Date: Wed May 7 10:19:59 2025 +0100 Bug 30200: (QA follow-up) Keep multiselect in sync This patch updates the multiselect status picker handling to ensure it remains in sync with the active tab. On tab change we now disable statuses that are not part of the tab select options, deselect any other status filters and then select all tab statuses. We allow further refinement of the filters still by allowing the user to deselect any of the available statuses. The filters should continue to work as before except using the 'Clear' button will now reapply the tab defined status set in full as apposed to removing all status filtering entirely. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 038cf1dca4dd8c3f41e59271154cd1ab7b8836bd Author: Magnus Enger Date: Fri Nov 22 13:50:51 2024 +0100 Bug 30200: Add pref to right file Signed-off-by: Magnus Enger Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit f1ad32ebe249cd20024f89ee9de99c51d5f99ae8 Author: Katrin Fischer Date: Mon Aug 8 21:18:19 2022 +0000 Bug 30200: (follow-up) Update database update and pref description * Rephrases the system preference description a bit * Adds IGNORE to the database statement * Update output message of database statement to include pref name Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Magnus Enger Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 543c5fab0a876dd5a54298355783c8bf3df83da5 Author: Lari Taskula Date: Thu Mar 3 02:18:58 2022 +0000 Bug 30200: Add custom tabs to View ILL requests page To test: 0: yarn css:build:prod 1. Set system preference ILLRequestsTabs: - name: New status: - NEW - name: Requested or reverted status: - REQ - REQREV - name: Queued status: - QUEUED - name: Empty status: - NONEXISTENT 2. Add some ILL requests with the following SQL: INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'NEW', 'Standard'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'NEW', 'Standard'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'REQ', 'Standard'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'REQREV', 'Standard'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'QUEUED', 'Standard'); INSERT INTO `illrequests` (borrowernumber, branchcode, status, backend) VALUES (1, 'CPL', 'KILL', 'Standard'); 3. Go to cgi-bin/koha/ill/ill-requests.pl 4. After the page loads, you should now see 4 different tabs: "All", "New", "Requested or reverted", "Queued", and "Empty" 5. Confirm all ILL requests are present under "All" tab 6. Confirm only ILL requests with the statuses you defined in system preference ILLRequestsTabs are under tabs "New", "Requested or reverted" and "Queued" 7. Confirm no ILL requests are under tab "Empty" 8. Clear system preference ILLRequestsTabs 9. Observe only one tab "All" under which correct ILL requests are presented 10. Try some other status values in ILLRequestsTabs and observe expected behavior Signed-off-by: Magnus Enger Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 9fabd8cac3fb66c5b3fd9af582b97ad7efdd7ea9 Author: Lari Taskula Date: Thu Mar 3 00:02:17 2022 +0000 Bug 30200: Add a new system preference ILLRequestsTabs Signed-off-by: Magnus Enger Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize Signed-off-by: Magnus Enger Signed-off-by: Katrin Fischer commit 23eab5df2fd0f280d262d51a54e97287d1221799 Author: Katrin Fischer Date: Thu May 8 06:06:47 2025 +0000 Bug 39579: DBRev 24.12.00.039 Signed-off-by: Katrin Fischer commit f9fef03cb928ff08316516dbc72b45589cecea63 Author: Lisette Scheer Date: Wed May 7 20:01:31 2025 +0000 Bug 39579: (QA follow-up) Update atomic update This patch updates the atomic update to fix an error when the database was updated and the permissions for the atomic update file. Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer commit 1f6e2c8f3c94a7bfbad9f0956e35b7c618ba3db8 Author: Alexander Blanchard Date: Tue Apr 8 12:55:03 2025 +0000 Bug 39579: Restrict Patron Self Reg Date of Birth Some libraries are getting dates of birth from the self-registration form that make patrons impossible ages, e.g. year of birth 1900. To Test: 1) Navigate to the oPac 2) Ensure you are not logged in 3) Below the log in, see 'Create an Account' 4) Click the link and complete the relevant fields 5) Add an unrealistic d.o.b e.g 1900 6) Complete the verification and click 'Submit' 7) Your acount has been created 8) Apply the patch 9) Navigate to the staff site 10) Navigate to Administration > SystemPreferences 11) Navigate to OPAC preferences 12) Identify PatronSelfRegistrationAgeRestriction 13) Add a maximum age in numberals e.g. 100 14) Repeat steps 1 - 6 15) An error message that you have exceeded max age will appear. 16) Alter your date of birth to make your age below that of the max age you set 17) Complete the verification 18) Your account should be created as normal Sponsored-by: Cheshire Signed-off-by: Emmanuel Bétemps Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer commit 2d484d326beaeb9aea62b45e40a50c8845009edf Author: Lucas Gass Date: Wed Apr 30 15:58:30 2025 +0000 Bug 39582: Syndetics support for UPC and OCLC numbers on OPAC results page To test: 1. Enable Syndetics 2. Have a record with an 024 and 1st indicator. 3. Do a search to return the record from step 3. 4. The image does not display. 5. APPLY PATCH 6. Try step 3 again, this time the cover image should display properly on the OPAC results page. Signed-off-by: Barbara Johnson Signed-off-by: Brendan Lawlor Signed-off-by: Katrin Fischer commit ff403dcfb3e2972597a49b447f4d55c208f13f4d Author: David Cook Date: Wed Dec 4 21:10:55 2024 +0000 Bug 36586: Define self-checkin timer using Javascript class This patch rewrites the self-checkin timer code to be defined in a Javascript class which is then instantiated in once in sci-main.pl depending on certain conditions (ie a barcode has been entered, or an item has been checked in by barcode). To test: 1 - Set SelfCheckinTimeout to a small value like 5 2 - Go to the self checkin: http://localhost:8080/cgi-bin/koha/sci/sci-main.pl 3 - Sign in as the SCI user 4 - Watch the page, it should refresh every 5 seconds 5 - Confirm that moving the mouse/typing prevents the reset 6 - Check in an item 7 - Wait and confirm reload of main page happens when idle 8 - Confirm mouse/typing prevents refresh 9 - Sign off! Signed-off-by: David Nind Signed-off-by: Martin Renvoize Bug 36586: Add sc-timer to sco This patch implements the timer form the last patch on the sco To test: 1 - Set SelfCheckTimout to 5 or something low for testing 2 - Go to the self checkout module 3 - Either sign in or confirm you have AutoSelfCheck user setup 4 - Observe the page reloads every 5 seocnds (or as you set above) 5 - Sign in as a patron 6 - Confirm on idle you are logged out to home page 7 - Sign off! Signed-off-by: David Nind Signed-off-by: Martin Renvoize Bug 36586: Fix tidy Signed-off-by: Katrin Fischer commit ee32b5aa7bb82b02df849a496214132f8c4ddc92 Author: David Nind Date: Sat Apr 26 03:28:22 2025 +0000 Bug 38532: (follow-up) Add missing space for credits message Fix credit message to add a missing space: - Previously: Credits: Patron has outstanding creditsof - Now: Credits: Patron has outstanding credits of Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 6b66e4e309a02388a5746d3790c8a09574947dfc Author: Martin Renvoize Date: Tue Apr 22 16:58:07 2025 +0100 Bug 38532: (follow-up) Use Koha::Patron->account methods Update the patch to use Koha::Account and it's associated 'outstanding' methods to ensure we accurately portray outstanding amounts rather than 'all credits' totals. I also remove the unused `$balance` variable from the members/moremember.pl controller. Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 337ef11cb36d3424d791c812956700f7b3d83f37 Author: Andrew Fuerste Henry Date: Tue Nov 26 18:23:14 2024 +0000 Bug 38532: Show both debits and credits on patron's check out and details pages To test: 1: Have patrons with a variety of credit/debit combinations 2: Confirm Koha shows the total debit amount in patron_messages if any debits exist 3: Confirm Koha does not show anything about creditd in patron_messages if any debits exist 4: Apply patch, restart_all 5: Confirm all patrons show both debit total and credit total Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 0fcb3b5bb6a93df444dba1f4b0e31b9db44081b7 Author: Jonathan Druart Date: Tue May 6 15:49:56 2025 +0200 Bug 39814: Restore filtering to the serials search table Similar to bug 39775, but for the serials search. Test plan: Create some serials then go to http://localhost:8081/cgi-bin/koha/serials/serials-search.pl and confirm that the filters now appear at the top of the table (which is consistent with the other tables) and that they work correctly. Signed-off-by: Roman Dolny Signed-off-by: David Nind Signed-off-by: Baptiste Wojtkowski Signed-off-by: Katrin Fischer commit 1df229719c8cec9ec249d825e1cb4efd2a87971d Author: Nick Clemens Date: Mon Dec 9 20:23:11 2024 +0000 Bug 38650: Only fill title level holds, or holds on the exact item We change the conditions for filling holds to require that either: - the hold is title level - the hold is on the exact item To test: 1 - Place a hold for patron A on item #1 of a record 2 - Place a hold for patron B on item #2 of a record 3 - Issue item #2 to patron A - their hold on item #1 is filled incorrectly, check the item in 4 - Apply patch, restart all 5 - Place hold for patron A on item #1 6 - Issue item #2 to patron A - their hold on item #1 is not filled, check the item in 7 - Cancel that hold 8 - Place a title level hold for the record for patron A 9 - Check item #1 in at a different branch and confirm transfer 9 - Issue item #2 to patron A 10 - The hold is filled as title level, even though item #1 was selected for the hold, check the item in 11 - Place an item level hold for item #2 for patron A 12 - Issue item #2 to patron A, hold is filled Signed-off-by: Stephanie Petruso Signed-off-by: Pedro Amorim Signed-off-by: Katrin Fischer commit 5cdfea2d5fc1c1848963236e3d16a95287a2e00d Author: Nick Clemens Date: Mon Dec 9 20:22:49 2024 +0000 Bug 38650: Unit tests Signed-off-by: Stephanie Petruso Signed-off-by: Pedro Amorim Signed-off-by: Katrin Fischer commit 64b4e7cc27c18b73bf738889a8cbbfdf1b8e52b4 Author: Martin Renvoize Date: Fri May 2 13:28:46 2025 +0100 Bug 39322: (follow-up) Further improvements This patch updates the query logic of create_from_statistic for borrower attributes. We replace the count of attributes types with a query to fetch all attributes type codes where keep_for_pseudonymization is set. We then check for content in that array before using it to perform a filtered search on the patrons extended_attributes to only return attributes set for pseudonymization. This should result in the same skip of extended_attributes fetch should no attribute types be set to pseudonymization, but it should also reduce the 1 call to attribute types per attribute the patron has to just a single filtered call for patron attributes attributes followed by the store call for each pseudonymizated attribute. Test plan: As before, except there should be even fewer sql calls to the database than before for the case where there are attributes. Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer commit 10b84d9df4fc5a85941a34cd204a5c3550177648 Author: Nick Clemens Date: Thu Mar 13 13:09:59 2025 +0000 Bug 39322: Don't fetch borrower attributes if none kept for pseudonymization This patch simply checks the count of pseudonymized borrower attributes before looping through them To test: 1 - Define several borrower attributes, none kept for pseudonymization 2 - Add some values for those attributes to some patrons 3 - Generate some statistics for those patrons (checkin, checkout, renew, etc) 4 - Enable pseudonymization 5 - On command line: export DBIC_TRACE=1 6 - Run the pseudonymization script with a date in the future to ensure all transactions are captured: perl misc/maintenance/pseudonymize_statistics.pl -v -c --before 2026-01-01 7 - Note the borrower attributes are fetched 8 - Apply patch 9 - repeat 6 10 - Note the attributes are only counted, not fetched 11 - Make one of the attributes kept 12 - repeat 6 13 - Note the attributes are counted and fetched Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 85f9e30ed5d5831913145715068dad84cd483dc4 Author: Jonathan Druart Date: Mon May 5 10:57:41 2025 +0200 Bug 38010: Restore ordering on the contracts table Signed-off-by: Katrin Fischer commit edf94b9f7eaae59810a6e52533579eee3eda3674 Author: Jonathan Druart Date: Wed May 7 13:48:59 2025 +0200 Bug 39835: Adjust some boolean flags Signed-off-by: Katrin Fischer commit aea3b3c7002630489190fe6ea582757e1497b692 Author: Matt Blenkinsop Date: Wed May 7 09:37:49 2025 +0100 Bug 39835: (follow-up) Fix API specs to check for boolean Amended-by: Jonathan Druart Removed changes to item.yaml Signed-off-by: Katrin Fischer commit ea6e31c39b723e34579a435adb9cbf6e48557e98 Author: Fridolin Somers Date: Fri Apr 25 11:21:18 2025 +0200 Bug 39746: Fix wrong system preference 'AutoLocation' in test suite Bug 26176 renamed 'AutoLocation' to 'StaffLoginRestrictLibraryByIP' Needs to be fixed in test suite Test plan: Enable 'StaffLoginRestrictLibraryByIP' in prefs Run : prove Auth.t Should pass Signed-off-by: Roman Dolny Signed-off-by: Katrin Fischer commit b79fb6aedf09eb9dd934bd7d35e1c572e97b3221 Author: Fridolin Somers Date: Fri Apr 25 11:35:24 2025 +0200 Bug 39747: Fix wrong system preference 'DefaultHoldExpirationUnitOfTime' in test suite Correct preference is 'DefaultHoldExpirationdateUnitOfTime'. Also no reason for ";". Test by running : prove t/db_dependent/Reserves.t Signed-off-by: Roman Dolny Signed-off-by: Katrin Fischer commit 66074093c0be3f80b54a902b41b10c40815bd508 Author: Andrew Fuerste Henry Date: Wed Apr 2 12:39:41 2025 +0000 Bug 39525: Label policy as 'Hold and booking pickup library match' To test: Apply patch, go to circ rules, confirm it says "Hold and booking library pickup match" under both "Defaul checkout, hold and return policy" and under "Default holds and bookings policies by item type" at both the all libraries and library-specific levels. Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer commit 79a6bca596187617e0c0c42393ef2c17ca26746c Author: Caroline Cyr La Rose Date: Fri Apr 4 04:11:28 2025 -0400 Bug 39550: RestrictPatronsWithFailedNotices system preference should not be in Patron relationships section This patch changes the RestrictPatronsWithFailedNotices system preference from the Patron relationships subsection of the Patron preferences to a newly created Patron restrictions subsection. To test: 1. Apply patch 2. Go to Administration > System preferences > Patrons --> There should be a new section called 'Patron restrictions' with RestrictPatronsWithFailedNotices in it Signed-off-by: David Nind Signed-off-by: Katrin Fischer commit 2d75f7aa914a6dfa45e18153a506c3d5c2b6f0f3 Author: Lucas Gass Date: Tue Apr 1 09:47:59 2025 +0000 Bug 39491: Change all note inputs to textarea To test: 1. APPLY PATCH 2. Try adding notes to the following actions from the patron transaction page: -Payout -Refund -Apply discount -Void -Cancel charge 3. Also try 'Pay amount', 'Pay selected', 'Write off selected' yellow buttons 4. Try the individual buttons for 'Pay' and 'Write off' Signed-off-by: Caroline Cyr La Rose Removed stray 0 from id attribute. Signed-off-by: Katrin Fischer commit f79aec38b8bb06af5f7977b5cdf4a99f3ef40c5e Author: Lucas Gass Date: Thu Apr 10 15:47:28 2025 +0000 Bug 39603: Make sure authorised value category is ITEMTYPECAT To test: 1. Add some AVs for ITEMTYPECAT and set some of your item types to be in that Search category. I made one called OTHER 2. Go to the OPAC advanced search page, the item types should be correctly displaying under ITEMTYPECAT with the correct description from ITEMTYPECAT. 3. Create a new AV called OTHER in a different category like 'ERM_AGREEMENT_CLOSURE_REASON'. Make the description something different like 'Wrong description'. 4. Now go back to the OPAC advanced search. 5. Notice your OTHER option now reads 'Wrong description'. 6. APPLY PATCH and restart_all 7. Try again, the OPAC descriptions should now be correct. Signed-off-by: Eric Phetteplace Signed-off-by: Katrin Fischer commit 0dcfde757ec2f804cab8be0c992f7b2e8c8d0b9b Author: nina martinez Date: Tue Mar 4 15:22:03 2025 +0100 Bug 39237: Change opac-user title to "Your summary" test plan : 1- login to opac 2- check the browser window title name 3- It should start with " Your Summary " Signed-off-by: Phil Ringnalda Signed-off-by: Katrin Fischer commit 650a2b7bca922941699319743fb98e1c4b50c687 Author: Owen Leonard Date: Mon Feb 10 19:31:28 2025 +0000 Bug 39083: Fix title sorting on list of tagged titles This patch adds the "anti-the" class to the title column on the tagged titles page. This allows DataTables to ignore articles when sorting. To test you should add the same tag to multiple titles. In the staff interface, go to Tools -> Tags, and click a term which has been added to multiple titles. In the list of titles, test title sorting. Articles like "a", "an", and "the" should be ignored when sorting. Sponsored-by: Athens County Public Libraries Signed-off-by: Phil Ringnalda Signed-off-by: Katrin Fischer commit 989924e9634e4fa807372cfb04d9a756c1a1f5be Author: Tomás Cohen Arazi Date: Thu Apr 24 17:25:31 2025 -0300 Bug 39379: Only display Edit patron button if enough permissions This patch adds a check for the current user permissions in order to display the 'Edit' button on the patron search screen. To test: 1. Have a patron with staff access and only `list_borrowers` permission (I picked Henry Acevedo, henry - Acevedo123) 2. Login as that user 3. Perform a patron search at http://kohadev-intra.localhost/cgi-bin/koha/members/members-home.pl => FAIL: There's an 'Edit' button 4. Click on the 'Edit' button => SUCCESS: You are told you don't have enough permissions 5. Apply this patch 6. Repeat 3 => SUCCESS: The button is not displayed 7. Login with a superlibrarian user 8. Repeat 3 => SUCCESS: You can see the button 9. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Roman Dolny Signed-off-by: Katrin Fischer commit 6d133e0d4b9182d086ceaa1faaf83d10685aa9eb Author: David Nind Date: Fri May 2 10:01:47 2025 -0300 Bug 39815: (follow-up) Make sentences more concise Changes "The following items" to "These items" (and singular equivalents). Removes "currently", as it is unnecessary. End result: - These items are overdue - This item is overdue Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer commit f94b2c173cbe45ef7d04f212b963e0d933a0eb23 Author: Tomás Cohen Arazi Date: Fri May 2 09:07:17 2025 -0300 Bug 39815: Simplify translation of sample ODUE notice Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer commit 46bb6d9dd684f148e809edfe9d7a93e62678b390 Author: Laura Escamilla Date: Fri Apr 25 14:32:57 2025 +0000 Bug 39689: Fixed Course Reserve typo To test: 1. Visit http://localhost:8080/cgi-bin/koha/opac-course-reserves.pl 2. Note the heading is "Courses reserves" which is grammatically incorrect. 3. Apply the patch and refresh the Course Reserves page. 4. Note that the heading is now grammatically correct. 5. Sign off and have a great day! :D Signed-off-by: Michelle Signed-off-by: Katrin Fischer commit 3d41b61a445ce7d25bca0e363b09d104ca6fbe3f Author: Caroline Cyr La Rose Date: Fri Apr 18 17:05:01 2025 -0400 Bug 39685: Typo: authorised value in item search fields This patch corrects a typo in the item search field table. Terminology indicates it should be "authorized" and not "authorised". https://wiki.koha-community.org/wiki/Terminology To test: 1. Apply patch 2. Go to Administration > Item search fields > New search field 3. Fill out the form 4. Click 'Submit' --> The column header in the table should be 'Authorized value category' Signed-off-by: Roman Dolny Signed-off-by: Katrin Fischer commit e78e9a4c4c6e30eec63797eff7ef3ba1ff722888 Author: Caroline Cyr La Rose Date: Fri Apr 18 16:32:52 2025 -0400 Bug 39685: Typo: authorised value in item search fields This patch corrects a typo in the item search field form. Terminology indicates it should be "authorized" and not "authorised". https://wiki.koha-community.org/wiki/Terminology To test: 1. Apply patch 2. Go to Administration > Item search fields > New search field --> The label for the authorized value category dropdown menu should say "Authorized value category" Signed-off-by: Roman Dolny Signed-off-by: Katrin Fischer commit 0a32b7371f7cab7a055d8f14f8b7b5dee7b21ae1 Author: Fridolin Somers Date: Thu Apr 24 11:40:24 2025 +0200 Bug 39735: Fix typo in system preference call 'OPACFineNoRenewalsIncludeCredit' Typo in system preference call 'OPACFineNoRenewalsIncludeCredit' => 'OPACFineNoRenewalsIncludeCredits' Test plan : Run : prove t/db_dependent/Circulation.t Run test plan of Bug 23293 Signed-off-by: Roman Dolny Signed-off-by: Katrin Fischer commit 2dea829ba46fe6d297094eca2c62d9adf73ea13c Author: Owen Leonard Date: Mon May 5 12:37:43 2025 +0000 Bug 39831: Correct typo in manage-marc-import.tt This patch corrects a typo in the staged MARC record management template: "xAction" -> "Action". To test: - Go to Cataloging -> Stage records for import. - Import a batch of MARC records for staging. - Import the staged batch. - Go to Cataloging -> Manage staged records. - Click the file name of the import to view its details. - The label "Action if matching record found:" should be correct. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind Signed-off-by: Katrin Fischer commit 0fc9f4d9607836cff9134be934b7b962b54a4e03 Author: Tomás Cohen Arazi Date: Thu Apr 24 11:45:43 2025 -0300 Bug 39741: Make valid-templates.t handle dirs This patch changes the regex so it doesn't expect the exclusion parameters to only be files but accept directories too. The risk of this is we might at some point catch more than we want. I don't think it is worth spending more time in it, though. To test: 1. Run: $ ktd --shell k$ prove xt/author/valid-templates.t => SUCCESS: Tests pass! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! We don't need to list each individual file anymore and it will still work! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer commit 1d2813b60194ec46a6155365df4096b0531bee14 Author: Lucas Gass Date: Fri May 2 17:44:00 2025 +0000 Bug 38356: (QA follow-up) Fix spelling mistake Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer commit abf74c4a26f0d257d56082bf4d190cd4d405b40c Author: Emmi Takkinen Date: Wed Mar 12 14:37:11 2025 +0200 Bug 38356: Check patrons current checkouts separately If syspref CheckPrevCheckout is enabled, Koha checks if patron has previously checked out item within timeperiod set in syspref CheckPrevCheckoutDelay. This however doesn't take into account cases where item is currently checked out for patron and they are trying to check out another item from same record (can be done if syspref AllowMultipleIssuesOnABiblio is enabled). We should always check if item is currently checked out for the patron if CheckPrevCheckout is enabled. To test: 1. Enable syspref CheckPrevCheckout and set CheckPrevCheckoutDelay as e.g. 10. Also enable syspref AllowMultipleIssuesOnABiblio. 2. Find a record that has been checked out for patron over 10 days ago. 3. Attempt to check out item from same record for same patron. => Note that you have to confirm if you want to check out item for the patron. 4. Find record that is currently checked out for a patron. 5. Attempt to check out item from same record for same patron. => Note that item is checked out for patron without confirm message. 6. Apply this patch and restart services if needed. 7. Repeat steps 2. and 3. => Confirm that you still have to confirm if you want to check out item for the patron. 8. Repeat steps 4. and 5. => New confirm message "Patron has this title currently checked out:..." should be displayed and you have to confirm if you want to check out item for the patron. Also prove t/db_dependent/Patron/Borrower_PrevCheckout.t Sponsored-by: Koha-Suomi Oy Signed-off-by: Felicie Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer commit 648d5a5c432fdb1478d9056f5a71293f4b55fad3 Author: Jonathan Druart Date: Tue Apr 29 16:43:06 2025 +0200 Bug 39775: Remove no-sort def Not needed. Signed-off-by: Jonathan Druart Signed-off-by: David Nind Signed-off-by: Katrin Fischer commit d323fa44676da4c24bfce4ce83274a1f7f2a3581 Author: Matt Blenkinsop Date: Tue Apr 29 15:22:15 2025 +0100 Bug 39775: Restore filtering to the serials claims table This patch implements the 'add_filters' argument for kohaTable() to restore filtering to the serials claims table Test plan: 1) Navigate to Serials and then Claims (if prompted to create a notice, please do this) 2) If you have no claims listed, return to the serials page and create a new serial (the details of this aren't too important) 3) Return to the serials claims page, try to use one of the filters at the bottom of the table 4) Nothing will happen and the table won't filter 5) Apply patch 6) Hard refresh the browser 7) The filters will now be at the top of the table and should work Signed-off-by: Jonathan Druart Signed-off-by: David Nind Signed-off-by: Katrin Fischer commit 1da28b221a204c30b684e5899e36032169673b99 Author: Tadeusz „tadzik” Sośnierz Date: Wed Apr 30 12:09:46 2025 +0200 Bug 39772: Extend background_tasks API to allow for human-readable job names Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit c2eb2625b2317496ff013cf79bb138554a6172ec Author: Tadeusz „tadzik” Sośnierz Date: Tue Apr 29 14:20:39 2025 +0200 Bug 39772: Display package names for plugin jobs rather than "unknown" messages This slightly improves the current situation, where on background_jobs.pl each plugin job would be displayed as "Unknown job type 'plugin_...'". After this patch, we display the implementing package name (sourced from plugins' background_tasks()), which is slightly more human-friendly and significantly less error-looking. Test plan: 1. In KTD, install a plugin implementing background jobs (e.g. the KitchenSink) 2. On http://localhost:8081/cgi-bin/koha/plugins/plugins-home.pl, enable the plugin and run a tool/report from it 3. Observe ugly job types column on http://localhost:8081/cgi-bin/koha/admin/background_jobs.pl 4. Apply the patch 5. Observe the improved job types on http://localhost:8081/cgi-bin/koha/admin/background_jobs.pl Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer