commit 022e90292201d16811b1b7a3367e02a0bcf3d799 Author: Owen Leonard Date: Thu Feb 12 12:54:54 2026 -0500 Bug 41841: Update some patron admin templates to use grid layout for forms This patch updates patron-related administration templates with new markup and CSS for layout forms using CSS grids. To test, apply the patch rebuild the staff interface CSS. Check the following pages, confirming that the "New" and "Edit" versions of the form look correct in each case: - Patron categories - Patron attribute types - Patron restriction types Sponsored-by: Athens County Public Libraries commit f97b5831929704d755afaaad4adc9f491a8fc392 Author: Jonathan Druart Date: Fri Apr 3 11:38:12 2026 +0200 Bug 42280: Tidy all script tags - admin (auto tidy) Signed-off-by: Paul Derscheid commit 91b67793472d9828ab040ad6151e88cdc3d20ec9 Author: Jonathan Druart Date: Fri Apr 3 11:24:41 2026 +0200 Bug 42280: Tidy all script tags - admin In order to tidy all the script tags of the .tt files we isolate the interpolation of Template::Toolkit variables in a separate script tag. This patch focuses on the administration module. The 2 main changes are in the following files: * aqplan.tt "0" should be correctly formatted * categories.tt trivial change about table settings Signed-off-by: Paul Derscheid commit 18dad35de45ef8658f0ded401a7513986cae88c9 Author: David Cook Date: Thu Apr 16 01:34:02 2026 +0000 Bug 42361: Fix SQL injection in catalogue_out.pl This change removes an SQL injection vulnerability from catalogue_out.pl Test plan: 0. Apply the patch 1. Go to koha-conf.xml and change the following: 1 to: 0 2. sudo koha-plack --restart kohadev 3. Go to /cgi-bin/koha/reports/catalogue_out.pl 4. Try out the various options and note no errors occur Signed-off-by: Sanjar Tulkinov Anvar o'g'li Signed-off-by: Jonathan Druart Signed-off-by: Pedro Amorim commit 3c67759548dc61127f1621fb060a45c0a7cc3278 Author: Jonathan Druart Date: Tue Jun 9 14:45:19 2026 +0200 Bug 42802: Update kohastructure.sql Test plan: root@kohadevbox:koha$ perl /kohadevbox/misc4dev/run_tests.pl --run-db-compare-only --compare-with v24.05.00 should pass with this patch Without this patch you get: Running [diff /tmp/current_db.sql /tmp/upgraded_db.sql && diff -q /tmp/current_db.sql /tmp/upgraded_db.sql || { echo "ERROR - DB structures are not identical" && exit 1; }]... 7207c7207 < /*!40111 SET SQL_NOTES=@OLD_SQL_NOTES */; Signed-off-by: Pedro Amorim commit 28c94aeb1512bbe57d91636d7bd418b10e8443f8 Author: Pedro Amorim Date: Mon Jun 8 11:18:29 2026 +0000 Bug 42783: Fix ManageMarcImport_spec.ts If import_batch_profiles is slow to respond, it'll trigger select.change() in stage-marc-import.tt and change the format to ISO2709 before the form is submitted, causing the error. cypress run --spec t/cypress/integration/Tools/ManageMarcImport_spec.ts Signed-off-by: Jonathan Druart Signed-off-by: Pedro Amorim commit 8efbd99ef81a2b5ed91bfe3a7be400162167a19d Author: Pedro Amorim Date: Mon Jun 8 13:54:46 2026 +0000 Bug 42764: (RM Follow-up): typo fix dbic Signed-off-by: Pedro Amorim commit bad922332b9a91e7bfa4691d3ea4337b4645a187 Author: Pedro Amorim Date: Mon Jun 8 13:54:04 2026 +0000 Bug 42764: (QA Follow-up): Fix DB update mismatch perl /kohadevbox/misc4dev/run_tests.pl --run-db-compare-only --compare-with v24.05.00 Signed-off-by: Pedro Amorim commit 34d708b93051f99d7bc012b4a7caab70be08d921 Author: Janusz Kaczmarek Date: Thu May 7 20:09:59 2026 +0200 Bug 42555: (Bug 25314 follow-up) Destroyed labels for customized facets After applying Bug 25314, customized facets generated from mappings.yaml are displayed with the technical type_id instead of the proper label. Test plan: ========== 1. In KTD with Elasticsearch enabled, add the following to admin/searchengine/elasticsearch/mappings.yaml su-gen: facet_order: 33 label: Genre/Form mappings: - facet: 1 marc_field: 655a marc_type: marc21 sort: 1 suggestible: '' opac: 1 staff_client: 1 type: '' Reindex with: koha-elasticsearch --rebuild -r -d -b kohadev 2. In the OPAC, at the bottom of the facets area, you should see a facet labeled su-gen_id instead of Genre/Form. 3. Apply the patch ; restart_all. 4. The facet should now display the correct label: Genre/Form. Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Pedro Amorim commit c183beefac42991f634c43c1aff42455c8e22a0c Author: Lucas Gass Date: Tue Jun 2 17:26:35 2026 +0000 Bug 42757: Use default suggestor or fallback to librarian To test: 1. Find a patron 2. From the patron account click the "Purchase suggestions" button 3. Make a suggestion 4. That suggestion is not associated with the patron from step 1 5. APPLY PATCH and restart_all 6. Repeart steps 1 -3. The purchase suggestion suggesedby should be the patron from step 1 7. Go Acquisitions -> Suggestions -> Add suggestion 8. Make sure when you do it this way the suggestedby is set to the logged-in-user by default Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Pedro Amorim commit 391d9f461c7fcfc15a4c9319b921a984d74b9ff9 Author: Lucas Gass Date: Tue Jun 2 16:24:10 2026 +0000 Bug 42750: Add redirect params back and exit after redirect To test: 1. Find a patron 2. From the patron account click the "Purchase suggestions" button 3. Make a suggestion 4. Your are redirected to suggestion/suggestion.pl 5. APPLY PATCH, restart_all 6. Try again, this time you should be properly redirected back to the patron account: ( members/purchase-suggestions.pl?borrowernumber=X ) Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Pedro Amorim commit db044d8552f967cf73b545e5cdd29f6ca9723c68 Author: Emily Lamancusa Date: Thu May 28 09:40:37 2026 -0400 Bug 42701: Fix editable class on additem.pl When editing the items on a biblio record, you should be able to select an item to edit by clicking anywhere on the item row. This functionality was lost because the "editable" class was not getting added correctly to the table row. This patch fixes that issue. To test: 1. Find a biblio record that has at least one item 2. Click on Edit > Manage items 3. In the table that lists editable items, click on any cell of any item (other than the Actions button) --> Nothing happens; the buttons to "Edit item" and "Delete item" do not appear as expected 4. Apply patch and refresh the page 5. Repeat step 3 --> The buttons to "Edit item" and "Delete item" appear Signed-off-by: Barbara Johnson Signed-off-by: Laura_Escamilla Signed-off-by: Pedro Amorim commit 86b2eb9a3a2fc9678a83915d5271099d6b85ca1a Author: Lucas Gass Date: Mon Jun 1 20:47:00 2026 +0000 Bug 42740: Fix suggestion status when editing To test: 1. Make a purchase suggestion. 2. Set the status to something, anything. 3. Edit that suggestion, notice that the "Status:" is set to 'No Status' 4. Now when you save, they actual status is lost. 5. APPLY PATCH, restart_all 6. Try steps 1 - 3. This time at step 3 the suggestion status should be properly set. 7. Save the suggestion, make sure it saves with the correct status. Signed-off-by: Jonathan Druart Signed-off-by: Tomás Cohen Arazi Signed-off-by: Pedro Amorim commit d1476c8184289a82f0164e2945024475b804a46d Author: Baptiste Wojtkowski Date: Thu Mar 5 12:19:39 2026 +0000 Bug 41998: Fix redirect_with_params Test plan (main only): 1 - Create a suggestion 2 - Delete the suggestion -> error 3 - Apply patch 4 - Repeat 1&2 Signed-off-by: Lucas Gass Signed-off-by: Pedro Amorim commit 9c994035fe405479f6d61816b3b66366e215c2e5 Author: Eric Phetteplace Date: Fri May 29 18:57:46 2026 -0700 Bug 42723: Purchase suggestion 500 when EmailPurchaseSuggestions is set to BranchEmailAddress Testing plan: - Set EmailPurchaseSuggestions to BranchEmailAddress - Go to create suggestion on the staff side /suggestion/suggestion.pl?op=add_form - Create a suggestion with Library: Any - 500 error: inbound_email_address is not a method of undef - Apply patch & repeat - Suggestion created Signed-off-by: David Nind Signed-off-by: Lucas Gass Signed-off-by: Pedro Amorim commit d6f1bdbe633a6c04c0f2c05b73ebdddc92788217 Author: Julian Maurice Date: Tue Jun 2 06:47:53 2026 +0000 Bug 42741: Fix plural form in lists Test plan: 1. Go to Lists 2. Create three lists called: - Test 0 items - Test 1 item - Test 2 items 3. Add one item in the "Test 1 item" list and add two items in the "Test 2 items" list 4. Go to lists and view the list of lists --> In the Contents column, "Test 0 items" should be "0 items" --> "Test 1 item" should be "1 item" --> "Test 2 items" should be "2 items" Signed-off-by: Jonathan Druart Signed-off-by: Pedro Amorim commit 8798f1a7a7a8aa83d746c9985366b761c8921a8c Author: Tomás Cohen Arazi Date: Mon Jun 1 15:18:44 2026 -0300 Bug 42739: Add CSRF-TOKEN header to OPAC ratings.js fetch call The ratings.js file uses raw fetch() to POST to the REST API without including the CSRF-TOKEN header. This will fail once CSRF enforcement is enabled on the REST API. Test plan: 1. Apply patch 2. Enable star ratings in OPAC (StarRatings syspref) 3. Log in to the OPAC 4. Rate a biblio using the star widget => SUCCESS: Rating is saved without errors 5. Sign off :-D Signed-off-by: Tomás Cohen Arazi Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Pedro Amorim commit 0c5a53a8d0a72aa6c0d10292d7d31eff2ae48933 Author: Nick Clemens Date: Wed May 20 19:09:48 2026 +0000 Bug 42659: Use biblio-title.inc for displaying title at checkin Currently at checking we display the number and parts all grouped,this is different than other places in Koha, we should use the same include here To test: 1 - Edit a record and set the title like: 245 1 4 ‡aThe passion according to G.H. ‡bsubtitle ‡nnumber1 ‡ppart1 ‡nnumber2 ‡ppart2 /‡cClarice Lispector ; translation by Ronald W. Sousa. 2 - Enable syspref 'ShowAllCheckins' 3 - Checkin an item from that record, display is like: The passion according to G.H. subtitle number1 number2 part1 part2 / 4 - Apply patch 5 - Check in again 6 - Display is now: The passion according to G.H. subtitle number1 part1 number2 part2 / 7 - Sign off! Signed-off-by: Eric Garcia Signed-off-by: David Nind Signed-off-by: Pedro Amorim commit f2735f73ef2a68f27c39c17437a00c4b9eabe956 Author: Lucas Gass Date: Thu May 28 16:38:00 2026 +0000 Bug 42710: Set library to logged in library for new suggestions To test: 1. Acquisitions -> Suggestions ->Add suggestion 2. Notice the under Acquisition information the library is set to Any 3. APPLY PATCH 4. Try again, library should be set to the logged in library. 5. Make a suggestion and set it to some branch other then the logged in branch 6 Edit the suggestion from step 5, ensure that the "Library:" is properly set Signed-off-by: David Nind Signed-off-by: Baptiste Wojtkowski Signed-off-by: Pedro Amorim commit af711ae7c0107d5fe7522a60bb8da1faa604640c Author: David Nind Date: Thu Apr 23 10:10:13 2026 +0000 Bug 42454: Terminology: Use "and" instead of "&" for curbside pickups tab The "Staged & ready (0)" tab for curbside pickups (Circulation > Holds and bookings > Curbside pickup) should use "and" instead of "&". See terminology guidelines for "& (ampersand)" - Only use "&" when part of a proper noun or a common abbreviation,... Otherwise, use "and": https://wiki.koha-community.org/wiki/Terminology#characters Test plan: 1. Enable the CurbsidePickup system preference. 2. Configure curbside pickup for Centerville: - Go to Administration > Patrons and circulation > Curbside pickup - Set values: . Enable: selected . Pickup interval: 5 . Maximum patrons per interval: 1 . Patron-scheduled pickup: selected . Enable for waiting holds only: selected . Curbside pickup hours: add from and to hours for some days . Click Save configuration 3. Go to Circulation > Holds and bookings > Curbside pickup. 4. Note that there is an '&' in the "Staged & ready (0)" tab title. 5. Apply the patch. 6. Refresh the page. 7. Note that and is spelt in full "Stage and ready (0)". Signed-off-by: David Nind Signed-off-by: Alex Carver [Acerock7] Signed-off-by: Pedro Amorim commit c57cb6c6d53d15c28d7aa1cac457a92663eea687 Author: Owen Leonard Date: Tue May 5 11:47:58 2026 +0000 Bug 42498: Fix invalid aria attribute in OPAC search results pagination This patch corrects the aria-current attribute in OPAC search results pagination. There should be no aria-current attribute on the list item, and the aria-current value on the link should be "page." To test, apply the patch and perform a catalog search in the OPAC which will return multiple pages of results. View the page source or use the developer console to inspect the HTML of the active pagination link. It should have an aria-current label with the value "page." The containing list item should not have an aria-current label. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind Signed-off-by: Laura_Escamilla Signed-off-by: Pedro Amorim commit b71b2bbc98a3fae6e68ef19f04b6f4a8fd331a9a Author: Owen Leonard Date: Tue May 26 11:22:10 2026 -0400 Bug 42691: Typo: automaticaly Signed-off-by: David Nind Signed-off-by: Laura_Escamilla Signed-off-by: Pedro Amorim commit 813c292957897506b2d9dc2130584217e5333cb2 Author: Owen Leonard Date: Tue May 26 11:24:43 2026 -0400 Bug 42692: Typo: regarless Signed-off-by: David Nind Signed-off-by: Laura_Escamilla Signed-off-by: Pedro Amorim commit b021ad4a2eddd0b6a9da3f42bffb8107c37c0fb6 Author: Owen Leonard Date: Tue May 26 13:03:39 2026 -0400 Bug 42518: Capitalization: Refund Payout Receipt Signed-off-by: David Nind Signed-off-by: Laura_Escamilla Signed-off-by: Pedro Amorim commit 94e9d14151d1516d02aa8e7989b7b49cc8af09c7 Author: Owen Leonard Date: Thu May 28 10:26:41 2026 -0400 Bug 42707: Malformed Bootstrap dropdown in reports output This patch updates the SQL report results markup in order to make sure Bootstrap dropdowns are formatted correctly. To test, apply the patch and locate or create a report which returns patron card number, e.g. SELECT cardnumber, borrowernumber FROM borrowers LIMIT 10 In the results, test the menus triggered when you click a card number or a borrowernumber. The menu in the cardnumber column should be formatted like the menu for borrowernumber. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind Signed-off-by: Laura_Escamilla Signed-off-by: Pedro Amorim commit 5036ff8eddb26cd8687a72c1d1796d2b79b37261 Author: David Nind Date: Thu May 28 17:16:40 2026 +0000 Bug 42695: (follow-up) Format paragraph Moves the explanation sentence into its own paragraph. Signed-off-by: David Nind Signed-off-by: Laura_Escamilla Signed-off-by: Pedro Amorim commit 7dce6c266fc2921bac1f9cc090572abfaf98b72e Author: Owen Leonard Date: Tue May 26 13:50:15 2026 -0400 Bug 42695: Minor language and markup corrections to reports error messages This patch makes a vew minor corrections to guided_reports_start.tt. To test apply the patch and go to Reports. - Try to create an SQL report which uses UPDATE, e.g. UPDATE items SET barcode = 1 WHERE itemnumber = 1 - Confirm that the text of the error message reads well and is formatted well. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind Signed-off-by: Laura_Escamilla Signed-off-by: Pedro Amorim commit 833937d6d2bb2a00aa1b37b0d28b61041fc1ccf2 Author: Jonathan Druart Date: Thu May 28 16:48:44 2026 +0200 Bug 42708: (bug 41566 follow-up) Restore display of itemtype images > - [% UNLESS noItemTypeImages %] > + if (prefs.noItemTypeImages){ This is wrong! Test plan: Go to /cgi-bin/koha/catalogue/detail.pl?biblionumber=4 Notice that with this patch the "Book" icon is displayed Turn off noItemTypeImages and reload => It's now hidden! Without this patch the behavior is reversed Signed-off-by: David Nind Signed-off-by: Laura_Escamilla Signed-off-by: Pedro Amorim commit 2970d728800077d0077ae76cd0f151b4971cf664 Author: Andrew Nugged Date: Wed May 27 23:58:33 2026 +0300 Bug 42702: Fix malformed cancel links on parcel.pl The pending orders table builds the two cancel order links with the link text concatenated immediately after the invoice_id value. This leaves the href attribute unclosed and makes the browser absorb the link text and following escaped HTML into the href. Add the missing separator after invoice_id for both cancel link builders. Test plan: 1. Create a closed acquisition basket with a pending order. 2. Open an invoice receive page for the vendor. 3. Inspect the Cancel order link in the pending orders table. 4. Confirm the href ends after invoiceid and the link text is outside the href. Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Pedro Amorim commit 56075a587ceb1e9c2455823736d5df22224fff5f Author: Jonathan Druart Date: Thu Mar 19 10:35:32 2026 +0100 Bug 42130: ERM - Index biblio when local title is created/updated The indexation step has been removed by commit d2820f57d6a738786a243e558e43ba640eaf7165 Bug 34788: (QA follow-up) Koha/ERM/EHoldings/Title.pm - C4::Biblio::ModBiblio( $record, $self->biblio_id, '' ); + C4::Biblio::ModBiblio( $record, $self->biblio_id, '', { skip_record_index => 1 } ); From the commit message: 2) The background job now uses skip_record_index to avoid queuing indexing jobs for every new biblio and instead queues one job at the end it's then missing when we add or edit a local title. Test plan: 1 - Enable ERMModule 2 - Go to ERM 3 - eHoldings->Titles 4 - New title 5 - Populate the form 6 - Check the create bibliographic record box 7 - Save => Confirm that the biblio is now indexed 8. Edit the title, modify a value, tick the box, save => Confirm that the biblio is now indexed with the new value Signed-off-by: David Nind Signed-off-by: Nick Clemens Signed-off-by: Pedro Amorim commit 2a655af08900278e692ae6ad10e757e0a3ec0bc1 Author: Kevin Carnes Date: Wed Mar 25 16:28:19 2026 +0100 Bug 42178: Fix close button for remove from bundle The close button for remove from bundle has not type, so it submits the form. This patch adds a button type. Test plan: 1. Apply bug 42177 or add a local use preference for bundlesEnabled set to 1. 2. Edit a record. 3. Modify the leader so that it has a collection bibliographic level. 4. Ensure that is has at least one item. 5. Click Manage bundle next to the item. 6. Click Remove from bundle. 7. Click the Close button. 8. Observe that the form is submitted. 9. Apply the patch. 10. Repeat steps 5-7. 11. Observe that the form is not submitted. 12. Sign off. Sponsored-by: Lund University Library Signed-off-by: Laura_Escamilla Signed-off-by: Marcel de Rooy Signed-off-by: Pedro Amorim commit 0023371a4ea973c6abd067804242f0cd8cff6de4 Author: Maryse Simard Date: Thu Mar 26 10:23:50 2026 -0400 Bug 42193: Fix the "Suspend Hold" modal in the OPAC In the OPAC, the "Suspend Hold" modal sometimes shows up as (and acts like) a "Resume Hold" modal. The reason for this is a left over "HOLD.suspend" in the template. "HOLD" should not be used in this template and is set as a side effect of the processing of "holds-table.inc". Since there is a separate form that exist for the "Resume" action and the modal is only needed for suspension, this patch simply removes the inacurate conditional in the modal definition. To test : 1. Have at least 2 holds. 2. In the holds table in the OPAC, make sure all holds are active and have a "Suspend" link. 3. Click the "Suspend" link on the newest hold (with the highest reserve_id). => The modal is titled "Suspend hold" and submitting it correctly suspends the hold. 4. Click the "Suspend" link on any of the other hold. => The modal is titled "Resume hold" and submitting it doesn't suspends the hold. 5. Apply patch 6. Repeat step 4. => The modal is titled "Suspend hold" and submitting it correctly suspends the hold. Signed-off-by: Roman Dolny Signed-off-by: Marcel de Rooy Signed-off-by: Pedro Amorim commit 9898bca5d0ea79c16b4875947680aa7314ed6f98 Author: Julian Maurice Date: Thu Mar 26 14:38:39 2026 +0000 Bug 42194: Fix redirect after sharing a report to Mana Bug 34478 removed a '&' by mistake in the redirect URL Test plan: 1. Setup a local instance of Mana (https://gitlab.com/koha-community/koha-mana) with disabled email validation (skip_email_validation in config.yml) 2. Connect Koha to this local instance (mana_config in $KOHA_CONF) 3. From Koha Admin interface, create a Mana security token 4. Share a report to Mana 5. You should be redirected to the list of reports with a message saying the report was saved successfully Signed-off-by: Emmanuel Bétemps Signed-off-by: Marcel de Rooy Signed-off-by: Pedro Amorim commit 29b71a07492278eee2559d80f4636ba942274499 Author: Martin Renvoize Date: Mon Aug 4 15:12:27 2025 +0100 Bug 32938: Add ORDRSP message display to basket page This patch extends the EDIFACT message display functionality on the basket page to include ORDRSP (Order Response) messages alongside existing QUOTE and ORDERS messages. Features added: - ORDRSP message collection and filtering - Smart button display logic: * Single button for one message type * Dropdown for multiple message types (now includes ORDRSP) - ORDRSP-specific UI elements: * Reply icon (fa-reply) indicating response nature * "View order response" labeling * Integration with existing modal and highlighting system The ORDRSP messages correctly link to baskets since they are vendor responses to the original order, following the standard EDI workflow: ORDERS → ORDRSP → INVOICE Sponsored-by: OpenFifth Signed-off-by: Hannah Dunne-Howrie Signed-off-by: Marcel de Rooy Signed-off-by: Pedro Amorim commit 8897fde297e6125a36b4c46592a646852af102b0 Author: Martin Renvoize Date: Mon Aug 4 15:11:53 2025 +0100 Bug 32938: Fix ORDRSP message linking to point to baskets instead of invoices ORDRSP (Order Response) messages are responses to ORDERS messages and should link to the related basket, not to invoices. This follows the standard EDI workflow: 1. ORDERS message sent to vendor 2. ORDRSP message received from vendor (order response/confirmation) 3. INVOICE message received later when items shipped Sponsored-by: OpenFifth Signed-off-by: Hannah Dunne-Howrie Signed-off-by: Marcel de Rooy Signed-off-by: Pedro Amorim commit 370de0a3aada6d2fbb5538cd1243ab253b5f0b25 Author: Pedro Amorim Date: Fri Jun 5 09:47:16 2026 +0000 Bug 42764: DBRev 26.06.00.001 Signed-off-by: Pedro Amorim commit 50e1739f870d576754367b1fa89912709dc485c7 Author: Pedro Amorim Date: Fri Jun 5 09:23:01 2026 +0000 Bug 42764: dbic Signed-off-by: Pedro Amorim commit 93593ce70cbaab76d405b422c8e3e9de42e38c2b Author: Pedro Amorim Date: Fri Jun 5 09:18:03 2026 +0000 Bug 42764: (QA follow-up): Update DB schema Signed-off-by: Pedro Amorim commit dcd04a26ca84982b7f641fb21a053a13cf43ce97 Author: Pedro Amorim Date: Fri Jun 5 09:17:11 2026 +0000 Bug 42764: (QA follow-up): Atomicupate: Fix typo in SQL table comment Signed-off-by: Pedro Amorim commit 2dc91dcd38055f738afb5465dae7da3c9dd05bea Author: Martin Renvoize Date: Thu Jun 4 17:50:09 2026 +0100 Bug 41705: (follow-up) Fix for new kohaTable requirements This bug sat in the queue too long and thus there's coding standard changes to resolve. Signed-off-by: Martin Renvoize commit 3ed47b65e8ca898b8ed38be771b118cd5f969e3d Author: Martin Renvoize Date: Thu Jun 4 08:06:04 2026 +0100 Bug 42764: Use inline codespell:ignore for SAN-Ouest Provence in templates Rather than excluding the entire about.tt files from codespell scanning, annotate only the specific lines containing the proper noun "Provence" (SAN-Ouest Provence, a French library co-operative and Koha sponsor) with an inline TT comment that codespell recognises as a per-line ignore. This lets codespell continue to check the rest of each file for genuine spelling mistakes, while still catching accidental "Provence" for "Province" in any other template not carrying this annotation. Replaces the file-level exceptions added to Koha::Devel::Files in favour of the more surgical inline approach. Test plan: 1. Apply patch 2. Verify "Provence" on the annotated lines produces no codespell output: codespell -d --ignore-words .codespell-ignore \ koha-tmpl/intranet-tmpl/prog/en/modules/about.tt => no output 3. Verify the rest of about.tt is still checked by introducing a deliberate typo elsewhere in the file and confirming codespell flags it 4. prove xt/author/codespell.t => All tests pass Signed-off-by: Martin Renvoize commit cc7c1aa1573237bfdf88724be25ac96415b032d7 Author: Martin Renvoize Date: Thu Jun 4 07:51:35 2026 +0100 Bug 42764: Fix false positives caused by mixed filetypes in CI failure store The ci-results repo stores all failures from a single test run as one flat JSON array, regardless of whether they came from the pl, tt, or js filetype pass. On the next incremental run, get_files_to_test('pl') reads that entire list -- including any .tt failures -- and calls remove_exceptions with the 'pl' context. Since .tt files only appear in the tt exception list, they survive the filter and get codespell'd in the pl pass where nothing is configured to exclude them. The fix filters stored failures by filetype before applying exceptions, so each pass only re-checks failures that belong to its own type. Test plan: 1. Apply all patches 2. Add a file to the tt codespell exceptions in Koha::Devel::Files that contains a word codespell would flag 3. Introduce a deliberate failure in another file so the ci-results repo records the excepted .tt file as a previous failure 4. On the next incremental run, confirm the excepted .tt file is not re-tested in the pl or js pass 5. prove xt/author/codespell.t => Tests pass; no false positives from cross-filetype re-checks Signed-off-by: Martin Renvoize commit 84536a08c93158e4569b5217a186aa8b355a35ff Author: Martin Renvoize Date: Thu Jun 4 07:38:46 2026 +0100 Bug 42764: Include filename in codespell test output Without a test comment, failures appear as bare 'not ok N' lines with no indication of which file failed or what codespell found. Passing the filename as the third argument to is() means: - Every passing test shows: ok N - path/to/file - Every failing test shows: not ok N - path/to/file Test plan: 1. Apply patch 2. Introduce a deliberate spelling error in any .pl file 3. prove xt/author/codespell.t => Failing line shows the filename and the codespell finding inline, without needing to dig into full console logs Signed-off-by: Martin Renvoize commit 5b2293c7785118639cc55e1bc39e4ad98999189d Author: Martin Renvoize Date: Wed Jun 3 16:42:43 2026 +0100 Bug 42764: Fix false positives caused by POD letter-code formatting Two patterns in the codebase produce spurious codespell hits because codespell tokenises word fragments out of formatted letter codes: - B

rovider in C4/Auth_with_shibboleth.pm produces 'rovider' - T(ransit), W(aiting), F(inished), P(rocessing) in C4/Reserves.pm produce 'ransit', 'aiting', 'inished', 'rocessing' For the shibboleth POD line the bold-letter markup cannot be simplified without losing the formatting intent, so a per-line # codespell:ignore comment is the right suppression. For the Reserves.pm status table the fix is made at source: the notation is changed from X(word) to X (Word) so codespell sees the full English word and no fragment is produced. Because the per-line comment on the shibboleth line now suppresses 'rovider' directly, the global .codespell-ignore entry for that fragment is removed as redundant. Test plan: 1. Apply patch 2. prove xt/author/codespell.t => No new codespell failures Signed-off-by: Pedro Amorim commit 04809de849b522d0bd396e1ffb8e8d3dd5e00ac2 Author: Martin Renvoize Date: Wed Jun 3 12:43:43 2026 +0100 Bug 42764: Fix spelling errors across the codebase Correct genuine spelling errors identified by the codespell 2.4.x full scan after the KTD container OS upgrade. Changes are in comments, POD, strings, and template text across 55 files. "SAN Ouest Provence" (the French library co-operative and Koha sponsor) is preserved as a proper noun. Perl copyright lines receive an inline # codespell:ignore annotation; about.tt files (contributor attribution pages) are added to the Koha::Devel::Files codespell exception list so that future uses of "Provence" as a typo for "Province" are still caught in all other files. Notable user-visible fixes: - "submiting" -> "submitting" in authority and bibliographic merge screens - "deleteable" -> "deletable" in patron exception messages - "Acquistions" -> "Acquisitions" in reports dictionary Test plan: 1. Apply patches 2. In the staff interface, go to Cataloguing > Merge records and confirm the submit button reads "Submitting" (not "Submiting") 3. In the staff interface, go to Authorities > Merge and confirm the same correction 4. Attempt to delete a patron with outstanding issues and confirm the error message reads "deletable" (not "deleteable") 5. prove xt/author/codespell.t => All tests pass Signed-off-by: Pedro Amorim commit 7538ee5cf352a0d531d9f14bbb158a3bfa0ef475 Author: Martin Renvoize Date: Wed Jun 3 12:31:14 2026 +0100 Bug 42764: Update .codespell-ignore for valid technical terms Add words to .codespell-ignore that codespell 2.4.x flags but are valid technical terms, domain vocabulary, or proper names: - checkin: core library circulation term (check-in as noun/verb) - plack: Perl PSGI middleware framework (proper software name) - requestor: COUNTER 5 standard term used in ERM usage statistics - laf: EDIFACT 3-letter segment code - vai/lamba: Unicode script and language names in character set data - aas: acronym used in Cypress test support files - carmel: contributor name in about.tt - prfile: legacy variable abbreviation in C4/Creators/PDF.pm Test plan: 1. Apply patch 2. prove xt/author/codespell.t => Test passes (or only genuine spelling errors remain) Signed-off-by: Pedro Amorim commit 8fc481e57a8e60c00533362dcaeccf094371de4e Author: Owen Leonard Date: Wed Apr 22 10:06:47 2026 -0400 Bug 42441: Remove event attributes from authority merge template This patch moves a couple of "onclick" event attributes from the authority merge template, moving the event handling to the JS block. This patch also fixes the behavior that I assume the click handlers are meant to have, changing the framework selection. A mismatch of IDs in the code meant that clicking the radio buttons didn't do anything. To test, apply the patch and go to Authorities. - Perform a search for authority records which will return multiple results, including records with different heading types (e.g. Personal Name, Topical Term, etc.) - In the "Actions" menu for one of the search results, click "Merge" - Do the same with another result which has a different heading type. - On the "Merging records" page you should see a frameowrk dropdown. - When you click the radio buttons next to your two records to merge the framework selection should change to match your selection. Sponsored-by: Athens County Public Libraries Signed-off-by: Phil Ringnalda Amended-by: Jonathan Druart Tidy Signed-off-by: Jonathan Druart Signed-off-by: Pedro Amorim commit a3569fe0c27ee397b2297aac008b741f901ee750 Author: Owen Leonard Date: Mon Mar 23 12:26:13 2026 -0400 Bug 42154: Bug 38714 hid the "New match check" link in record matching rules This patch corrects the logic used to determine whether to show the "New match check" link. I mistakenly changed it to check for the matchpoints variable instead of the matchchecks variable. To test, apply the patch and go to Administration -> Record matching rules. - Click "New record matching rule" in the toolbar. - Scroll down to the "Required match checks" section. - You should see a "New match check" link alongside a "Remove this match check" link. - Go back to the record matching rules main page. - If necessary, create a rule which doesn't have any match checks. - In the "Required match checks" section of the edit form you should see a "New match check" link, previously hidden by Bug 388714. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Pedro Amorim commit 6aa37a84300e2b5f85834e4da1208bdd44baa0b1 Author: Marcel de Rooy Date: Fri May 22 10:13:49 2026 +0200 Bug 42084: (QA follow-up) Simplify Since this is an intranet svc script (called in intranet js), there is no need to check the session. Signed-off-by: Marcel de Rooy Signed-off-by: Pedro Amorim commit cb058d68fd1d29b3cc0c251afb3f70dcd5cb8126 Author: Hammat Wele Date: Fri Mar 13 15:33:56 2026 +0000 Bug 42084: Incorrect interface shown in log viewer for system preference changes The log viewer displays the OPAC interface for system preference changes. Since system preferences cannot be modified from the OPAC, the interface displayed in the logs appears to be incorrect. To reproduce: 1- Disables plack 1- sudo koha-plack --disable kohadev 2- sudo koha-plack --stop kohadev 3- sudo service apache2 restart 2- Change a system preference from the staff interface. 1- Go to Administration -> System preferences. 2- Search for a preference such as AcqCreateItem (any system preference will reproduce the issue). 3- Change the value of the preference. 4- Click Save all Acquisitions preferences (or save the preference). 3- Go to the log viewer: 1- Navigate to Tools -> Log viewer. 2- Fill the form as follows: Librarian: leave empty Modules: uncheck everything except System preferences Actions: keep All actions selected Object: leave empty Info: leave empty Interface: keep All interfaces Display from: choose yesterday Display to: leave empty 3- Click Submit. ==>The log entry shows the OPAC interface. 4- Apply the patch 5- Repeat step 1,2,3 ==>The log entry shows the Staff interface. Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Pedro Amorim