commit f2aa1ecb536a7cecc468645038a3542599914118 Author: Pedro Amorim Date: Mon Sep 14 14:15:10 2026 +0000 Bug 31391: DBRev 26.06.00.025 Signed-off-by: Pedro Amorim commit 8ccba18691853c6aae072fe5c5aff84102440a0a Author: Pedro Amorim Date: Mon Sep 14 13:30:02 2026 +0000 Bug 31391: (RM follow-up) Enforce recalls permission when converting holds to recalls The previous follow-up only blanked the button's label via JS for users without the recalls permission; the button still rendered, was still clickable, and modrequest.pl's cud-convertall had no permission check at all, so the conversion still succeeded. Adds CAN_user_recalls to the button's template condition (matching the existing "Move selected holds" button) so it doesn't render at all without the permission, drops the now-redundant JS check in holds.js, and adds a manage_recalls check in modrequest.pl itself. checkauth()'s userid is the login username, not a borrowernumber, so this uses C4::Auth::haspermission() directly rather than Koha::Patrons->find(). Test plan: 1) Set a default recalls rule in admin/smart-rules.pl. 2) Set UseRecalls to 'staff' or 'opac_and_staff'. 3) Give a test patron 'catalogue' + 'reserveforothers' but not 'recalls'. 4) Check out an item, place a hold on it for another patron. 5) As the test patron, go to that record's Holds tab, confirm 'Convert selected to recall' doesn't appear. 6) Since the button is gone, confirm the server side is enforced too: post op=cud-convertall directly to modrequest.pl and confirm it no longer converts the hold. 7) Grant 'recalls' and confirm the button reappears and works. Co-Authored-By: Claude Sonnet 5 Signed-off-by: Pedro Amorim commit 324b4d2fbedd5f94ef9675adb6abafd281880de8 Author: Katrin Fischer Date: Mon Sep 14 12:39:33 2026 +0000 Bug 31391: (QA follow-up) Hide "Convert selected to recall" for users with no recalls permission This introduces a permission check on "recalls" for the link on the holds summary page. 1) Go to http://localhost:8081/cgi-bin/koha/admin/smart-rules.pl, and under the default rule, set: - 'Recalls allowed (total)': 5 - 'Recalls per record': 3 - 'On shelf recalls allowed': if any unavailable - 'Recall due date interval': 5 - 'Recall overdue fine amount': 5 - 'Recall pickup period': 2 2) Go to 'Administration' > 'Global system preferences' (http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=UseRecalls), set 'UseRecalls' to 'can be placed through the staff interface only'. 3) Go to Henry's patron account, borrowernumber 19, set him a password (http://localhost:8081/cgi-bin/koha/members/member-password.pl?member=19), then edit his permissions (http://localhost:8081/cgi-bin/koha/members/member-flags.pl?member=19) and give him only 'catalogue' and 'reserveforothers' (place holds), do not give him 'recalls'. 4) As a superlibrarian, check out item 39999000003154 (biblionumber 76) to borrowernumber 23, then place a hold on that same record for borrowernumber 49 5) Log out and log back in as Henry. 6) Go to http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumber=76, tick the checkbox next to the hold, click 'Convert selected to recall', confirm in the modal. 7) The hold gets cancelled and a recall gets created, even though Henry has no recalls permission at all, proving the action isn't actually gated by it. 8) Apply patch, re-run test plan to 6) - The link to convert should no longer display. 9) Toggle the recalls permission for Henry, link to convert should now reappear. Signed-off-by: Pedro Amorim commit 3df791492577c138213ec02a89facb32bebb4ab1 Author: Katrin Fischer Date: Fri Sep 11 16:00:12 2026 +0000 Bug 31391: (QA follow-up) Make sure pickup-library is kept when converting holds to recalls The code was using the patron's home library instead of passing the pickup-location of the original hold. This is a simple variable change in 2 places for record level and item level holds. A) Set 'UseRecalls' to 'staff' at http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=UseRecalls B) At http://localhost:8081/cgi-bin/koha/admin/smart-rules.pl set the default rule: 'Recalls allowed' = 5, 'Recalls per record' = 3, 'On shelf recalls allowed' = 'if any unavailable' (not 'all'). C) Use biblionumber '437' (has just one item, barcode '39999000019186'), check that item out to 'Henry Acevedo' (Patron A). D) Place a record-level hold on it for 'Johnny Bryan' (Patron B), who's from 'Midway' — but set the hold's pickup location to 'Centerville' instead. E) On http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumber=437, tick the hold, click 'Convert selected to recall', confirm. F) Check the new recall's pickup location on http://localhost:8081/cgi-bin/koha/recalls/request.pl?biblionumber=437 - Expected: 'Centerville' - Without the patch applied, it will be the patron's home library: Midway - With the patch applied, the pickup-location of the hold is kept: Centerville. G) Cancel the recall. H) Repeat the test plan, but in step D) place an item level hold instead of a record level hold. Signed-off-by: Katrin Fischer Signed-off-by: Pedro Amorim commit e128051d09cd48062b712fe374e386606b6cf32b Author: Katrin Fischer Date: Fri Sep 11 15:40:54 2026 +0000 Bug 31391: (QA follow-up) Fix check for UseRecalls for messaging preferences in OPAC We are skipping the notice, if UseRecalls == "off". This now matches the check in staff too. A) Go to the KTD staff interface at http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=UseRecalls and set 'UseRecalls' to any non-'off' value, e.g. 'can be placed through the OPAC only'. B) Log into the OPAC at http://localhost:8080/cgi-bin/koha/opac-user.pl as any patron. C) Go to http://localhost:8080/cgi-bin/koha/opac-messaging.pl D) Look for the recall-related notice row (item recalled / recall notices) — it's missing, even though recalls are enabled. E) Now flip 'UseRecalls' back to 'off' in step 1's page. F) Reload http://localhost:8080/cgi-bin/koha/opac-messaging.pl — the recall notice row now shows up, even though recalls are off. G) Steps 4 and 6 are the reverse of what should happen — confirms the condition is inverted. Signed-off-by: Katrin Fischer Signed-off-by: Pedro Amorim commit a5e8fdccbd780dd348738fa6c46d3ee543404660 Author: Katrin Fischer Date: Fri Sep 11 15:38:33 2026 +0000 Bug 31391: (QA follow-up) Adjust for changes made by bug 42443 This fixes a test to use 'opac' in transfers.t Signed-off-by: Katrin Fischer Signed-off-by: Pedro Amorim commit 77f3567b59718e838d76df2c79abd75a0e459945 Author: Katrin Fischer Date: Mon Aug 3 15:57:14 2026 +0000 Bug 31391: (QA follow-up) Fix mocked value in Holds.t The pref was mocked to '1' (the old value) in Holds.t Test now uses 'opac_and_staff' Signed-off-by: Katrin Fischer Signed-off-by: Pedro Amorim commit 5850a591bd8c1137bc6bee2212bb781611f6daea Author: Katrin Fischer Date: Fri Jul 31 15:29:25 2026 +0000 Bug 31391: (QA follow-up) Fix Recall button visibility in holdings table Fixes a problem with the template variables that made the recall button show in some places when UseRecalls was set to off. As the problem was in item-status.inc that is used in several pages, a small fix goes far here. Part 1: opac-detail.tt / opac-basket.tt (default config, useRecalls = 'off') 1) Confirm UseRecalls is at its default (off) 2) Check out item 39999000003154 to patron 'Henry Acevedo' 3) Log into the OPAC as a different patron (e.g. koha user) 4) As koha user, go to the biblio detail page for the record we just checked out: http://localhost:8080/cgi-bin/koha/opac-detail.pl?biblionumber=76 5) Look at the item's status row: next to "Checked out", a "Recall" button is visible, even though UseRecalls is off. 6) Click it, lands on opac-recall.pl, shows a "Recalls have not been enabled. Please contact your library.", which confirms it's a dead-end button that never should have rendered. 7) Same thing reproduces in the basket: as koha user, add that biblio to your cart (Add to cart on the results/detail page), then click the cart icon on the top left. The same button erroneous will show. Part 2: opac-course-details.tt — staff-only mode still leaks the OPAC link 1) Continuing from the previous instructions: Set UseRecalls to "can be placed through the staff interface only". 2) Add the same checked-out item (39999000003154) to a course reserves list — http://localhost:8081/cgi-bin/koha/course_reserves/course-details.pl?course_id=1 3) Click "Add reserves" 4) As koha user on the OPAC, view that course's page: http://localhost:8080/cgi-bin/koha/opac-course-details.pl?course_id=1 5) The "Recall" button shows here too, even though UseRecalls=staff should mean OPAC patrons can't place recalls at all. Signed-off-by: Katrin Fischer Signed-off-by: Pedro Amorim commit ca977dcd7862c95c5fe9c7dfe0fec717c2b51476 Author: Aleisha Amohia Date: Tue Jul 7 22:18:22 2026 +0000 Bug 31391: Allow cancel recall if UseRecalls enabled, remove unnecessary vars This follow-up includes the following changes: - only allow a recall cancellation via the OPAC if UseRecalls is enabled for the OPAC. - uses singleBranchMode var passed by C4::Auth in staff interface biblio recalls - drops unused attribute_type_codes var - drops unnecessary items var and uses biblio.items in template Signed-off-by: Katrin Fischer Signed-off-by: Pedro Amorim commit 65b8a6129d0418b6f2af7428ed0b25461678f8dd Author: Katrin Fischer Date: Mon Jul 6 17:52:31 2026 +0200 Bug 31391: Add "Place recall" button in detail page toolbar Adds a new entry "Place recall" to the detail page's toolbar, visible when: - UseRecalls is set to allow recalls in staff - User has recalls permission This matches the behavior for holds and bookings, so seems to increase consistency. Signed-off-by: Katrin Fischer Signed-off-by: Pedro Amorim commit 98c8add18563672c6d1935b5dde3db0a68410605 Author: Aleisha Amohia Date: Wed Jun 17 04:59:04 2026 +0000 Bug 31391: Request recalls and convert reserves on staff interface This enhancement adds the ability to place recalls via the staff interface by changing the UseRecalls system preference to have choices which describe where recalls can be placed. Recalls can either be placed via the OPAC, or the staff interface, or both. To be set to OPAC would be consistent with current 'on' behaviour. UseRecalls is turned off by default. This enhancement also adds the ability to convert existing holds to recalls easily via the staff interface. The hold will be cancelled and a recall placed using the hold's information. To test: 1) Update database and restart services 2) Set UseRecalls to OPAC and set the relevant recalls circulation rules OPAC only by default 3) Check out Item A to Patron B. 4) Log into the OPAC as Patron A. Confirm you can place, view and cancel recalls as normal. 5) In the staff interface, set UseRecalls to Staff interface only. 6) In the OPAC, confirm you can still view and cancel recalls, but can no longer place recalls. 7) In the staff interface, search for Item A and go to the Holds tab. Place a hold for Patron C. 8) Check the checkbox for your hold and confirm the counts in the buttons above the Holds table are incremented as expected. 9) Click the button to Convert selected holds to recalls, a modal should pop up. Confirm all of the information is correct. 10) Confirm the conversion and once the page refreshes, your hold should be correctly cancelled using the new RECALLED reason. 11) Go to the Recalls tab. Confirm your hold has been converted to a recall, and details like the patron, expiration, and pickup location have carried across to the recall. 12) On this Recalls page, use the patron search to find Patron D. Test placing a record-level recall by choosing to recall the next available item. 13) When the page refreshes, confirm the recall was successfully placed with the correct details stored. 14) Repeat steps 12 and 13 with Patron E, this time place an item-level recall by choosing an item in the 'place a recall on a specific item' table. When selecting one of these items, the 'recall next available item' section should become disabled. 15) Set UseRecalls back to OPAC only. Go back to the record and view the Recalls tab. 16) Confirm you cannot search for a patron to place a recall, but can still view and cancel recalls. Confirm you also cannot convert holds to recalls. 17) Set UseRecalls to both staff interface and OPAC. Confirm you can place recalls on both interfaces. 18) On the staff interface, test placing recalls that your circulation rules do not allow. For example, if 'recalls per record' is 1, ensure you're blocked from placing a second recall on a record for a patron. Another example, testing converting a hold to a recall when there are NO checked out items, as recalls can only be placed if something is checked out. 19) Place a hold for one of the patron's that already has a recall. Once complete, try to convert this hold into a recall. Confirm you are blocked and shown a message that the hold cannot be converted to a recall. 20) Confirm patron messaging preferences for recalls notices can still be configured as expected. 21) Ensure tests pass: * t/db_dependent/Circulation.t * t/db_dependent/Circulation/transferbook.t * t/db_dependent/Holds.t * t/db_dependent/Koha/Biblio.t * t/db_dependent/Koha/Item.t * t/db_dependent/SIP/Transaction.t * t/db_dependent/Search.t * t/db_dependent/XSLT.t Sponsored-by: Auckland University of Technology Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Pedro Amorim commit 8211dd8d0f779a75a8eaa9eb8a8c964a05e0bf18 Author: Aleisha Amohia Date: Tue Jun 16 02:00:42 2026 +0000 Bug 31391: Add UseRecalls to Hea Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Pedro Amorim commit 401a52b8334bac5578c1183c1c599ef9908fe9f5 Author: Aleisha Amohia Date: Tue Jun 16 00:39:38 2026 +0000 Bug 31391: Implement UseRecalls choices on staff interface Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Pedro Amorim commit b9b80b9471ac0b92556c640b3601d8317586f54c Author: Aleisha Amohia Date: Tue Jun 16 00:26:43 2026 +0000 Bug 31391: Implement UseRecalls choices in tests Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Pedro Amorim commit 6091466f51a3ac8c5be69d0aed0c014751c8f057 Author: Aleisha Amohia Date: Tue Jun 16 00:16:01 2026 +0000 Bug 31391: Implement UseRecalls choices on OPAC Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Pedro Amorim commit 0f35039974ebc6f3088236f4e6af9124fd4d54f3 Author: Aleisha Amohia Date: Tue Jun 16 00:04:28 2026 +0000 Bug 31391: Implement UseRecalls choices in modules Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Pedro Amorim commit f9c159e0a3f0627937572fae614c1707d9682bed Author: Aleisha Amohia Date: Mon Jun 15 23:57:15 2026 +0000 Bug 31391: Update the UseRecalls system preference to have choices Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Pedro Amorim commit 0ebf8a632e7207c24efd50b7126b30d5326e577a Author: Aleisha Amohia Date: Mon Jun 15 23:46:09 2026 +0000 Bug 31391: Recalled authorised value for hold cancellation Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Pedro Amorim commit d9d4c6c4fd3c3ce3c5013bb3cde04f6e1ae9cbf6 Author: Lucas Gass Date: Fri Sep 11 21:04:04 2026 +0000 Bug 36868: (follow-up) Remove 2x call of holds.js, hold-group.js Signed-off-by: Pedro Amorim commit 11012af3696af9d8e4acf5049e2268178489e2d0 Author: Lucas Gass Date: Fri Sep 11 20:58:55 2026 +0000 Bug 36868: (follow-up) Remove double instanciated hold_table_settings Signed-off-by: Pedro Amorim commit 3405bb206fcaee5be7e76bd7792f8d33d2f66888 Author: Lucas Gass Date: Fri Sep 11 20:55:21 2026 +0000 Bug 36868: (follow-up) fix failing tt_kohaTable_tidy.t test Signed-off-by: Pedro Amorim commit d1b39adfc5825d2dff1a5ff66f9a87577405d048 Author: Nina Martinez Date: Fri May 9 15:27:40 2025 +0200 Bug 39890: Add search, menu and footer skip links to the OPAC. Before starting the test plan, you have to enable the following system preferences: CurbsidePickup, useDischarge, OPACHoldsHistory, ILLModule,EnhancedMessagingPreferencesOPAC, CookieConsent, OPACPrivacy, opacreadinghistory, UseRecalls, OPACHoldRequests, RoutingSerials, EnableOpacSearchHistory, virtualshelves,suggestion, OPACViewOthersSuggestions, TagsEnabled, OpacTopissue,OPACVirtualCard. Test plan: A) Add skip link to menu 1. Apply the patch, you don't have to be logged in for this part. 2. Go to these different pages: search result page, record details page (try the different views), and Most popular page. 3. Try navigating with the keyboard, fix the focus at the top of the page 4. You should see a skip link in red, 'skip to menu' appear. After pressing enter, the focus should be on the menu. 5. Now go to these different pages: Purchase suggestions page, search history page, Lists page. 6. Repeat the third step and check if the skip link "Skip to menu" does not appear on these pages. 7. Now you have to log in to a patron account. 8. Go to your Summary page. 9. Repeat the third step with the different pages of the menu (Summary, Charges, Personal details, Consents, Tags, Change password, Search history, Checkout history, Privacy, Holds history, Recalls history, Purchase suggestions, Messaging, Lists, Ask for discharge, Interlibrary loan request, Curbside pickups, My virtual card). 10. You should see the "Skip to menu" link, after pressing enter, the focus should be on the menu. B) Add a skip link to the search box 1. Try navigating with the keyboard, fix the focus on the top of the page. 2. Check if there is a skip link "Skip to the search" in red on each page of the OPAC, except on the advanced search page. C) Add a skip link to the footer 1. Try navigating with the keyboard, fix the focus at the top of the OPAC page. 2. Check if there is a skip link 'Skip to footer' after the skip link 'Skip to main content' on each page of the OPAC. 3. Now, disable the system preferences (OPACReportProblem and KohaAdminEmailAddress, CookieConsent, OpacKohaUrl, OpacLangSelectorMode = 'both', or OpacLangSelectorMode = 'footer') to remove the OPAC footer. 4. Repeat step 2. Now, you should not have the skip link to the footer. D) If all the tests succeed, sign off ! Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Pedro Amorim commit c6bf858253beecf4bf8a4e4e8ccc9d51daff2b35 Author: Pedro Amorim Date: Mon Jul 13 10:51:33 2026 +0000 Bug 34632: (QA follow-up) Use Koha::Uploader for patron import files Large files were failing to enqueue/process because the whole CSV was embedded in the job's JSON args, hitting DB/broker size limits. This now uploads the file via Koha::Uploader first (same pattern as MARC staging) and only passes a small uploaded_file_id through the job, and fixes the enqueue-failure message to not claim nothing happened when a job was in fact created. Co-Authored-By: Claude Sonnet 5 Signed-off-by: Lisette Scheer Signed-off-by: Pedro Amorim commit 5ca53cf2bc9ed1ecf6c7fe4d1c48c0b91fac83a5 Author: Pedro Amorim Date: Wed Jun 17 10:22:42 2026 +0000 Bug 34632: Add patron_import background job display template patron_import.inc provides the report/detail/js blocks consumed by the background job viewer: a summary of counts when finished, a live progress bar while running, and the full feedback and error analysis in the detail section. background_jobs.tt gains a patron_import entry in the job type filter dropdown. Test plan: 1) Apply patches, restart plack. 2) Navigate to the patron import tool: /cgi-bin/koha/tools/import_borrowers.pl 3) Upload the provided sample CSV file and click 'Import patrons'. 4) Confirm the page shows "The patron import job has been enqueued!" with a link to view the job. 5) Follow the link to the background job. Confirm a progress bar is shown while the job is running. 6) Once finished, confirm the report shows the correct counts (imported, overwritten, already_in_db, invalid, total). 7) Confirm the imported patrons exist under 'Patrons'. 8) Re-import the same file with 'Overwrite cardnumber' unchecked. Confirm 'already_in_db' count is 5. 9) Re-import again with 'Overwrite cardnumber' checked. Confirm 'overwritten' count is 5. 10) Visit the background jobs admin and filter by type 'Import patrons': /cgi-bin/koha/admin/background_jobs.pl 11) Confirm the jobs appear in the list. 12) Run the tests: prove t/db_dependent/Koha/BackgroundJob/PatronImport.t Co-Authored-By: Claude Sonnet 4.6 Signed-off-by: Brendan Lawlor Signed-off-by: Lisette Scheer Signed-off-by: Pedro Amorim commit 88644d26af1b87b89f50cfec9c9823a8d2f26f40 Author: Pedro Amorim Date: Wed Jun 17 10:22:27 2026 +0000 Bug 34632: Use PatronImport background job in import_borrowers import_borrowers.pl now reads the uploaded file into memory and calls Koha::BackgroundJob::PatronImport->enqueue() instead of running the import synchronously. On success the template shows a confirmation with a link to the background job viewer; on failure it shows an error alert. Co-Authored-By: Claude Sonnet 4.6 Signed-off-by: Brendan Lawlor Signed-off-by: Lisette Scheer Signed-off-by: Pedro Amorim commit c8c24445afb9c9de7416e93971fbd2abc010933b Author: Pedro Amorim Date: Tue Jun 16 16:33:59 2026 +0000 Bug 34632: Add tests for Koha::BackgroundJob::PatronImport Tests cover enqueue() (status, queue, job_size, job_type) and six process() scenarios: happy path, import errors (with validation that the 25-error cap has been removed), already_in_db and overwritten, patron list creation, and cancelled job handling. Co-Authored-By: Claude Sonnet 4.6 Signed-off-by: Brendan Lawlor Signed-off-by: Lisette Scheer Signed-off-by: Pedro Amorim commit ae60b6ebaad4dbdbf1dc2d157df8cc8a0cdec97a Author: Pedro Amorim Date: Tue Jun 16 16:33:45 2026 +0000 Bug 34632: Add Koha::BackgroundJob::PatronImport Introduces a new background job class for patron imports. enqueue() reads the uploaded file content into the job_args and uses line count as job_size for progress tracking. process() reconstitutes the file handle from the stored content, delegates to Koha::Patrons::Import with step_callback wired to $self->step, handles patron list creation, stores the import results, and clears file_content from the stored data to free space. Also registers patron_import in Koha::BackgroundJob::core_types_to_classes so _derived_class can resolve the job correctly. Co-Authored-By: Claude Sonnet 4.6 Signed-off-by: Brendan Lawlor Signed-off-by: Lisette Scheer Signed-off-by: Pedro Amorim commit 770e5ca6ec3653736de0eb2949a92e83e562a833 Author: Pedro Amorim Date: Tue Jun 16 16:32:22 2026 +0000 Bug 34632: Add step_callback support to Koha::Patrons::Import Adds an optional step_callback coderef parameter to import_patrons(). When provided it is called after every row — whether the row succeeds, is skipped as a duplicate, or is rejected as invalid — so callers can track progress. Also removes the 25-error cap that was there to protect browser response size; that constraint no longer applies when results are stored in a background job's data field. Co-Authored-By: Claude Sonnet 4.6 Signed-off-by: Brendan Lawlor Signed-off-by: Lisette Scheer Signed-off-by: Pedro Amorim commit 115d26ecae060b631b1cfe454eb8c7112a9467c1 Author: Kyle M Hall Date: Mon Jul 27 13:52:52 2026 -0400 Bug 42679: (QA follow-up) Add tests for missing permissions and non-overdue checkouts The existing tests pass even if the endpoint counts all checkouts instead of overdues only. This patch adds a checkout due in the future and tests the count is unchanged. It also tests that a patron without the borrowers flag gets a 403. Signed-off-by: Kyle M Hall Signed-off-by: Pedro Amorim commit 14e4d6cb43c265fda6ca35683ba043ba5cc37d9d Author: Kyle M Hall Date: Mon Jul 27 13:52:04 2026 -0400 Bug 42679: (QA follow-up) Remove search tag that belongs to bug 42508 This tag describes the /search/patrons endpoints added by bug 42508. Nothing in this bug uses it, and if this bug is pushed alone main would carry a tag for endpoints that don't exist. Bug 42508 should add it. Signed-off-by: Kyle M Hall Signed-off-by: Pedro Amorim commit f7caec076f3eaef545b9cf47722793d8feec6036 Author: Tomás Cohen Arazi Date: Sat May 23 01:00:44 2026 -0300 Bug 42679: Add GET /patrons/{patron_id}/overdues_count endpoint Returns the count of overdue checkouts for a patron as a plain integer. Computed live from the database (date_due < NOW()) to ensure accuracy, as overdue status is time-based with no discrete event to trigger updates. This endpoint is intended for async loading in the patron search table, allowing the main search results to render immediately while overdues are fetched separately per visible page. Test plan: 1. Apply patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/patrons_overdues_count.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: David Nind Signed-off-by: Kyle M Hall Signed-off-by: Pedro Amorim commit 5d75b6fdad91102b096d2604b7131a015724c79c Author: Laura Escamilla Date: Fri Jul 24 15:29:09 2026 +0000 Bug 39420: (QA follow-up) Replace tabs with spaces Signed-off-by: Laura_Escamilla Signed-off-by: Pedro Amorim commit 97235dea0d9d83786cecdedc037e18e346222942 Author: Samuel Sowanick Date: Tue Jun 30 11:10:34 2026 -0700 Bug 39420: adjusted additem.tt breadcrumb to lead back to item Bug 39420: removed old breadcrumb - Update additem.tt Bug 39420: Removed old edit breadcrumb. Bug 39420: Fixing syntax error in END tag Signed-off-by: Pedro Amorim commit 693c447736b6240ad4749a30d297eeb750c692e0 Author: Jonathan Druart Date: Mon Sep 7 15:55:01 2026 +0200 Bug 41995: Show all entries Signed-off-by: Michaela Signed-off-by: Pedro Amorim commit fe8a9a5529fe75dfac62ad78db51c12aa7b082d3 Author: Jonathan Druart Date: Tue Sep 8 14:39:10 2026 +0200 Bug 43330: Simplify tests Signed-off-by: Pedro Amorim commit d5f522e5264b298219d25e4dfe2e7360699c381b Author: Laura Escamilla Date: Tue Aug 18 16:49:59 2026 +0000 Bug 43330: Add regression test for TagsExternalDictionary To test: 1. Set the TagsExternalDictionary system preference to a non-empty value, for example: /usr/bin/ispell 2. Restart Plack if necessary. 3. Visit a staff interface page which loads C4::Tags, such as the staff home page or a bibliographic detail page. 4. Observe: Undefined subroutine &C4::Tags::check_install called at C4/Tags.pm line 44. BEGIN failed--compilation aborted at C4/Tags.pm line 53. Compilation failed in require. BEGIN failed--compilation aborted. 5. Clear TagsExternalDictionary and clear/update the system preference cache. 6. Apply the patch. 7. Set TagsExternalDictionary to an empty value. 8. Verify that you can access the home page and other pages. 9. Set TagsExternalDictionary to a valid non-empty path such as /usr/bin/ispell 10. Verify the staff home page, catalog detail page, and Tools page load without HTTP 500 errors. 11. Prove t/db_dependent/TagsExternalDictionary.t 12. Sign off and have a great day! :D Signed-off-by: David Nind Signed-off-by: Paul Derscheid Signed-off-by: Pedro Amorim commit 29345111828d597bf5e874917f60176fdc31c361 Author: Laura Escamilla Date: Tue Aug 18 16:45:43 2026 +0000 Bug 43330: Fix C4::Tags compile failure with TagsExternalDictionary Signed-off-by: David Nind Signed-off-by: Paul Derscheid Signed-off-by: Pedro Amorim commit 7d52823ac5a596c351acedbc83ba91ca45fdc376 Author: David Nind Date: Mon Aug 31 21:54:08 2026 +0000 Bug 43432: Move ReportsExportLimit to reports category Move the ReportsExportLimit system preference from the staff interface category to the reports category, as it relates only to the reports module. 1. Go to Administration > System preferences. 2. Search for the ReportsExportLimit system preference. 3. Note that it is in the Staff interface > Options category. 4. Apply the patch. 5. Repeat step 2. 6. Note that it is now in the Reports > Options category. 7. Note that the "Reports access" section is now in sentence case. Signed-off-by: Bastien CHAUVET Signed-off-by: Pedro Amorim commit 87e8f605bbeb50a7606e649135bc3b63dc18253c Author: David Nind Date: Mon Aug 31 21:37:38 2026 +0000 Bug 43432: Update ReportsExportLimit system preference description The current description uses "records". It actually controls the number of rows (or results) exported, which may or may not be records. Additional updates were also made to improve the description notes. 1. Go to Administration > System preferences. 2. Search for the ReportsExportLimit system preference. 3. Note the use of "records" in the description - results returned may or may not necessarily be records. 4. Apply the patch. 5. Refresh the page. 6. Note the updated description: - "records" changed to "rows" - changes to the notes: . NOTE changed to bold, consistent with other descriptions . now uses an unordered list . active voice used . removed note about requiring a positive vale . added a note about the "Open in DataTables" option 7. Sign off 8-). Current description: Download a maximum of _____ records when downloading from the reports module. NOTE: Only a positive value will enforce a limit. A specific limit in the report overrides this setting. Updated description: Download a maximum of _____ rows when exporting report results. NOTE: - Using LIMIT in a report overrides this setting. - It does not limit results when using 'Open in DataTables' export options. Signed-off-by: David Nind Signed-off-by: Pedro Amorim commit efb310cda043a9fad49c672630ef7ac533c89210 Author: Andreas Jonsson Date: Thu Aug 20 12:08:20 2026 +0200 Bug 43346: MarkIssueReturned with no userenv Since it is not clear what checkin_library signifies when marking an issue on a lost item as returned we might as well fallback on setting it to the issuing library when there is no userenv. Test plan * Run the unit test t/db_dependent/Koha/Account/Line.t Signed-off-by: David Nind Signed-off-by: Jason Robb Signed-off-by: Pedro Amorim commit 7dbc37e187a2a9cb88b096c43b347e8b55331b92 Author: Andreas Jonsson Date: Thu Aug 20 12:07:31 2026 +0200 Bug 43346: Unit test for payment without userenv MarkIssueReturned needlessly fails when called from a session with no logged in user such as a script or anonymous callback. A specific application where this is a problem when completing a payment transaction in a plugin for opac online payment wich may be done via polling or callback. This unit test verifies that a payment can be completed when paying a fee for a lost item with MarkLostItemsAsReturned set to onpayment and no userenv set. Signed-off-by: David Nind Signed-off-by: Jason Robb Signed-off-by: Pedro Amorim commit f8ef545ca478c3bbee6bc337ca2f5b26b5af12f2 Author: Owen Leonard Date: Fri Sep 4 10:18:11 2026 -0400 Bug 38638: Offer non-priority option when placing multiple holds This patch adds a checkbox for setting holds as non-priority when placing multiple holds at once. To test, apply the patch and make sure the DisplayMultiPlaceHold system preference is enabed. - Perform a catalog search in the staff client which will return multiple results. - Check the checkboxes for 2 or more titles in the results and click "Place hold" in the toolbar. - When confirming the holds, check the "Non priority hold" checkbox. - Confirm that the holds are saved as non priority holds. - You can check by viewing the list of holds on a title. The "Details" column for that hold should say "Non priority hold." Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind Signed-off-by: Andrew Fuerste Henry Signed-off-by: Pedro Amorim commit b8d19935825244a4720b8622b5ca599d129cd0e2 Author: David Nind Date: Tue Aug 4 22:00:58 2026 +0000 Bug 43225: Fix punctuation for renewal confirmation message A renewal confirmation message (when the AllowFineOverrideRenewing system preference is set to "Allow") is missing a period and space between the amount due and the second sentence. It currently reads: "The patron has a debt of [amount]Are you sure you want to renew checkout(s)?" Test plan: 1. Set the AllowFineOverrideRenewing system preference to "Allow". 2. Check out an item to a patron (for example, 39999000011418 to Mary Burton). 3. Add a $110 manual charge to the patron's account: - [Patron account] > Accounting > Create manual invoice - Should now have a message on the patron's page: Charges: Patron has outstanding charges of 110.00. Make payment Pay all charges 4. Attempt to renew the checked out item from the checkouts section: - Check out > Checkouts > Show checkouts - Below the checkouts table, select "Override fine restrictions" - Click "Renew all" 5. There is a pop-up message with incorrect punctuation: The patron has a debt of 110.00Are you sure you want to renew checkout(s)? 6. Click the cancel option. 7. Repeat steps 4 to 6 from the details section (Details > Checkouts > Show checkouts) and note the same incorrect punctuation. 8. Apply the patch. 9. Repeat steps 4 to 7. 10. The pop-up message now reads: The patron has a debt of 110.00. Are you sure you want to renew checkout(s)? 11. Sign off. Signed-off-by: David Nind Signed-off-by: Laura_Escamilla Signed-off-by: Andrew Fuerste Henry Signed-off-by: Pedro Amorim commit 448419f9189ee52735cc383dc7933b6c78fa1ad0 Author: David Cook Date: Fri Sep 11 00:52:38 2026 +0000 Bug 43401: (QA follow-up) tweak rspack.config.js comment and fix Makefile.PL Signed-off-by: David Cook Signed-off-by: Pedro Amorim commit 83393079619ebb975da6a459ad839abc013b8a8e Author: Paul Derscheid Date: Fri Aug 28 09:06:58 2026 +0200 Bug 43401: (follow-up) Note the Makefile.PL coupling in rspack.config.js - Add a file-level comment reminding that every shipped output.path needs a matching 'NONE' target-map entry and cp step in Makefile.PL Signed-off-by: Paul Derscheid Signed-off-by: David Cook Signed-off-by: Pedro Amorim commit 55f621fd140ce11866ff317aa1b21ff2d3bb1f26 Author: Lucas Gass Date: Thu Aug 27 22:00:44 2026 +0000 Bug 43401: Send compiled js vue for the OPAC to the right dir The OPAC vue bundle (koha-tmpl/opac-tmpl/bootstrap/js/vue/dist) was not handled like its intranet counterpart in Makefile.PL: exclude it from the generic target map and copy it explicitly into blib in move_compiled_js. Test plan: 1. In a KTD shell, from the koha checkout: perl Makefile.PL (accept the defaults, 'standard' install mode is fine) 2. make -n move_compiled_js | grep 'js/vue/dist' => without this patch only the intranet cp line is printed; with it there is also a line copying koha-tmpl/opac-tmpl/bootstrap/js/vue/dist into blib/OPAC_TMPL_DIR/bootstrap/js/vue/ 3. make 4. ls blib/INTRANET_TMPL_DIR/prog/js/vue/dist blib/OPAC_TMPL_DIR/bootstrap/js/vue/dist => both directories exist and contain the compiled bundles (e.g. islands.esm.js); no vue/dist directory is left anywhere else under blib. 5. git clean -xdf blib pm_to_blib Makefile Makefile.old && git checkout -- . to clean up. Signed-off-by: Paul Derscheid Signed-off-by: David Cook Signed-off-by: Pedro Amorim commit 374295c25c41ea6022a88bb8199b3e3c868ba9d1 Author: Jan Kissig Date: Tue Jul 14 11:55:48 2026 +0000 Bug 42296: auto tidy for follow-ups Signed-off-by: Tomás Cohen Arazi Signed-off-by: Pedro Amorim commit 0602877c31f211f858dfc027f819a2d821194bad Author: Jan Kissig Date: Mon Jul 13 11:27:11 2026 +0000 Bug 42296: (follow-up) Remove unused base_url on barcode-print The JS variable base_url on barcode-print is never referenced. The remaining JS block did not contain TT interpolation, so data-tt-allowed can be removed. Signed-off-by: Tomás Cohen Arazi Signed-off-by: Pedro Amorim commit 667c8883e6086e71492d5c75e96be2542b021a23 Author: Jan Kissig Date: Mon Jul 13 10:33:29 2026 +0000 Bug 42296: (follow-up) Split JS block in auth.tt Signed-off-by: Tomás Cohen Arazi Signed-off-by: Pedro Amorim commit 4a4843e4813c48febf6abccfc872f3530eb8f937 Author: Jonathan Druart Date: Tue Mar 31 12:17:21 2026 +0200 Bug 42296: Tidy all script tags - trivial occurrences In order to tidy all the script tags of the .tt files we isolate the interpolation of Template::Toolkit variables in a separate script tag. This patch only adds 'data-tt-allowed="true"' when needed. The work to move the JS variable to a separate script tag has been done already on bug 41324. Signed-off-by: Jan Kissig Signed-off-by: Tomás Cohen Arazi Signed-off-by: Pedro Amorim