commit c513dee502a0a65819adc9c5df70f5fc8e2b6a4e
Author: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Date:   Mon Mar 30 09:28:38 2026 +0100

    Bug 41368: Fix ManageMarcImport Cypress test timing issue
    
    Replace the no-op `#job_callback` existence check with a recursive
    `cy.wait('@jobPoll')` that loops through each `/api/v1/jobs/*` poll
    response (arriving every ~1s) until it sees `status: finished`. This
    avoids any fixed timeout — the test proceeds as soon as the API signals
    completion, however long that takes on a given machine.
    
    Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

commit 92b1c11e3c5939d074db179950af60969fb6983a
Author: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Date:   Fri Mar 27 16:16:19 2026 +0100

    Bug 40383: (follow-up) Fix insertSampleEdifactMessages for new schema
    
    We moved host/username/password out of vendor_edi_accounts into a
    separate file_transports table between PQA and Pushed. Update the
    Cypress test fixture to insert a file_transports record first and
    reference it via file_transport_id, and clean it up in
    deleteSampleEdifactMessages.
    
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit d35f76316d9be6fe03aa063fee8eb6290c0fabb1
Author: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Date:   Fri Mar 27 16:09:30 2026 +0100

    Bug 41980: (follow-up) Fix Cypress test ambiguous field code search
    
    Typing "CE" in the allow_fields dropdown now matches both
    "CE - Unused" and "AY - Sequence number" (case-insensitive
    match on "ce" in "Sequence"), causing the wrong option to be
    selected. Use "CE - " to uniquely target the intended option.
    
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit 35a1757c9739f27a51985ca917c46fb8fd26085f
Author: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Date:   Fri Mar 27 11:14:11 2026 +0100

    Bug 40383: (RM follow-up) Use csrf_token over csrfToken
    
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit 679afb31ec8d830bcab0f68a4506a4a406046147
Author: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Date:   Fri Mar 27 11:03:06 2026 +0100

    Bug 35380: (RM follow-up) Move TT to own script tag
    
    Adhere to JS19
    
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit 320e08a715b2b8bee9864506de659f212b8fc76e
Author: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Date:   Fri Mar 27 10:37:20 2026 +0100

    Bug 41462: (RM follow-up) Add koha_objects_class
    
    Add the missing plural class mapper to the OAI Sets schema file
    
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit b3163a009b7e2ed1c14a44b00f0e72ecdb6063a6
Author: Brendan Lawlor <blawlor@clamsnet.org>
Date:   Fri Mar 20 17:30:11 2026 +0000

    Bug 41638: (QA follow-up) Make label for alt contact city consistent with main and alt address city
    
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit ecbaf3b4d5cbafa2731f622562eda00bb823b3ca
Author: Owen Leonard <oleonard@myacpl.org>
Date:   Thu Jan 22 13:36:36 2026 -0500

    Bug 41638: (follow-up) Fix more instances, some markup errors
    
    I've added changes for member-alt-address-style.inc,
    member-alt-contact-style.inc, and member-main-address-style.inc.
    
    I've also made some related markup corrections: Missing ID on some
    inputs, incorrect "for" label on some labels. These fixes don't correct
    *all* validation errors but it's an improvement.
    
    Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit d8a24968880e5b50ac724909f528b03028c2f126
Author: Lisette Scheer <lisette@bywatersolutions.com>
Date:   Thu Jan 15 17:00:43 2026 +0000

    Bug 41638: Add IDs to labels on patron edit
    
    When targeting with jquery and css, labels on the patron edit screen
    can be fragile and complicated.
    This patch adds ids to all the labels that follow the following
    convention:
    
    <label for="surname" class="required" id="surname_label">
    
    Each id is the "for" with _label appended.
    
    To Test:
    1. Before applying the patch, go to add a new patron
    2. Right click on the page and use the browser inspector/inspect
       element.
    3. Observe there are no ids for the field labels.
    4. Apply patch
    5. Reload the page
    6. Observe there are now ids for the fields.
    7. Go through all the fields and confirm there is an id and that they
       follow the convention above.
    8. Change mandatory fields and confirm the labels are still correct.
    9. Edit an existing patron and confirm the ids are still present.
    10. Sign off!
    
    Signed-off-by: Owen Leonard <oleonard@myacpl.org>
    Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit ed3f0dcab2ee01ca19e825399b8b6cb3299f5d08
Author: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Date:   Sat Mar 14 16:06:47 2026 +0000

    Bug 41980: (Follow-up) Improve SIP2 field code descriptions
    
    - Use sentence case for all dropdown descriptions
    - Add 'Unused' descriptions for AR, AW, AX, BA, BB, BC, BJ, CE
    - Move SIP field codes outside translatable strings to avoid
      untranslatable codes being sent to translators
    - Update AE/AV/DA tooltip text: use 'Template Toolkit' (not
      'Template::Toolkit'), imperative form, and clearer object
      field descriptions
    
    Signed-off-by: John Vinke <jvinke@austinseminary.edu>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit 780ae2d3e3c96d856574fa3fe053102852c7dacd
Author: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Date:   Tue Mar 3 16:40:37 2026 +0000

    Bug 41980: Add more descriptive labels to SIP2 field codes
    
    - Add field name labels to all entries in getSIPFields() used by the
      Allow/Hide fields dropdowns (e.g. "CV - Alert Type" instead of "CV")
      sourced from C4::SIP::Sip::Constants field identifier names
    - Add tooltips to ae_field_template, av_field_template and
      da_field_template explaining what each SIP field represents and
      which Template::Toolkit objects are available
    - Improve ct_always_send tooltip to explain CT is Destination Location
    - Improve cv_send_00_on_success tooltip to explain CV alert type codes
    - Improve cv_triggers_alert tooltip to clarify the two alert behaviours
    - Improve cr_item_field tooltip to explain CR is Collection Code
    
    Signed-off-by: David Nind <david@davidnind.com>
    Signed-off-by: John Vinke <jvinke@austinseminary.edu>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit 560dd35740d06246aad053c6280083e98d933104
Author: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Date:   Thu Mar 26 14:14:25 2026 +0100

    Bug 40841: DBRev 25.12.00.040
    
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit 3c8746866927db3fd7a9a3fdbec12f32f84c4983
Author: Tomás Cohen Arazi <tomascohen@theke.io>
Date:   Wed Oct 29 10:01:27 2025 -0300

    Bug 40841: Add limits configuration UI
    
    This patch adds branch limits selection to the Z30.50/SRU configuration
    page.
    
    Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
    Signed-off-by: David Nind <david@davidnind.com>
    Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit d6aae094b47c9b9cc68e8ce6e4768e159cbd4b76
Author: Tomás Cohen Arazi <tomascohen@theke.io>
Date:   Wed Oct 29 17:05:52 2025 -0300

    Bug 40841: Implement library limits on Z39.50 searches
    
    This patchset implements Z39.50/SRU limits by branch in Koha.
    
    Key implementation notes:
    - Follows Koha's established pattern for library limits
    - A new table linking to library limits is added
    - The admin UI is adjusted so the form includes library limit selection
    - Z39.50/SRU search controllers use the `search_with_library_limits`
      methods to correctly constraint the offered servers.
    
    To test:
    1. Apply this patches
    2. Run:
       $ ktd --shell
      k$ updatedatabase
    => SUCCESS: Database upgrade goes well
    3. Re-run:
      k$ updatedatabase
    => SUCCESS: No explosions, DB update idempotent
    4. Restart everything:
      k$ restart_all
    5. POint your browser to the admin page:
       http://kohadev-intra.localhost/cgi-bin/koha/admin/z3950servers.pl
    => SUCCESS: A new column is displayed for library limits brief
    6. Edit `LIBRARY OF CONGRESS`
    => SUCCESS: The form includes the usual library limit selection UI
    7. Choose some branches, excluding your current one (KTD's default is
       'Centerville').
    8. Save
    => SUCCESS: It is saved correctly
    => SUCCESS: The table shows the edited library has the library limits
    set
    9. Edit again
    => SUCCESS: The selected limits are preserved when editing
    10. Pick some authorities Z39.50 target, and exclude your current branch
        for testing purposes.
    11. Go to Cataloguing, and choose 'New from Z39.50/SRU'
    => SUCCESS: Limits are respected!
    12. Go to Authorities, and choose 'New from Z39.50/SRU'
    => SUCCESS: Limits are respected!
    13. Same as 11 but with the advanced editor
    => SUCCESS: Limits are respected!
    14. Sign off :-D
    
    Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
    Signed-off-by: David Nind <david@davidnind.com>
    Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit e389129d6121b661f9ff4f2ad497ba1af4db2359
Author: Tomás Cohen Arazi <tomascohen@theke.io>
Date:   Wed Feb 25 09:32:17 2026 -0300

    Bug 40841: DBIC schema [DO NOT PUSH]
    
    Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit 1abd451c5db60344bef7c3a172375ecb70b0dbe5
Author: Tomás Cohen Arazi <tomascohen@theke.io>
Date:   Wed Oct 29 09:36:13 2025 -0300

    Bug 40841: Add Z39.50 library limits
    
    This patch adds the library limits mixin to the Z39.50 classes following
    a well established pattern in Koha.
    
    Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
    Signed-off-by: David Nind <david@davidnind.com>
    Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit 3169620db54a76147f52a673287d7978ca49f9f9
Author: Tomás Cohen Arazi <tomascohen@theke.io>
Date:   Wed Oct 29 09:35:15 2025 -0300

    Bug 40841: DB changes
    
    Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
    Signed-off-by: David Nind <david@davidnind.com>
    Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit 79ebdb9db7b592581c5c5f5c67bcd99613845973
Author: Kyle M Hall <kyle@bywatersolutions.com>
Date:   Fri Feb 27 07:45:28 2026 -0500

    Bug 41462: (QA follow-up) Add basic unit tests and koha_object_class methods
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit adcbd749e4c73a86bbd83e428bec76340516fc63
Author: Aleisha Amohia <aleisha@catalyst.net.nz>
Date:   Wed Dec 17 01:36:35 2025 +0000

    Bug 41462: Add Koha::OAI::Set(s) and Koha::OAI::Set::Biblio(s)
    
    This architectural changes makes these tables available to the Koha namespace, and therefore the REST APIs.
    
    To test: Confirm t/00-load.t tests pass and check for any syntax/tidy errors.
    
    Sponsored-by: Auckland University of Technology
    Signed-off-by: David Nind <david@davidnind.com>
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit da840f6c3fd4d5197e7d190a64a138173853933a
Author: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Date:   Thu Mar 26 14:08:45 2026 +0100

    Bug 40504: DBRev 25.12.00.039
    
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit 16aa1edccd1e46c1531074fa6162c28bc17e7f57
Author: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Date:   Thu Mar 26 14:07:02 2026 +0100

    Bug 40504: (QA follow-up) Fix QA script failures
    
    - Add POD for _limit_counter in Koha::ILL::Request
    - Add nonce attribute to <script> tag in select_manager.inc
    - Collapse multi-line template tags in ill-requests.tt and suggestion.tt
    
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit 6dfe1bf93aeb303f50c8c296bbcd2a96382c3208
Author: Lisette Scheer <lisette@bywatersolutions.com>
Date:   Wed Mar 11 16:54:19 2026 +0000

    Bug 40504: (QA follow-up) Tidy
    
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit c3b6df654e99ec3f02c1ad89df7e04fcff90a148
Author: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date:   Mon Mar 2 12:08:05 2026 +0100

    Bug 40504: Fix DB structure comparison
    
    Fix misc4dev/run_tests.pl --run-db-compare-only
    
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit f2bb65c4f96dc69a5cfe51bb8cd000c8b6708601
Author: Pedro Amorim <pedro.amorim@openfifth.co.uk>
Date:   Tue Jan 27 11:59:24 2026 +0000

    Bug 40504: (QA follow-up): Prevent exiting without considering managed_by
    
    Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit d997fc598190b0fadb7499fb0d9f1845bb57f082
Author: Pedro Amorim <pedro.amorim@openfifth.co.uk>
Date:   Mon Nov 3 14:19:45 2025 +0000

    Bug 40504: [DONT PUSH] dbic
    
    Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit eaf50203b2b605c3fe5849dc023177bb84b140aa
Author: Pedro Amorim <pedro.amorim@openfifth.co.uk>
Date:   Thu Oct 30 11:18:21 2025 +0000

    Bug 40504: (QA follow-up): Add 'managed by' filter
    
    This adds a 'Managed by:' filter input on the left side filters.
    
    Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk>
    Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit 2a9e51c9b24d4f7446dfdbab641fad4865d00059
Author: Pedro Amorim <pedro.amorim@openfifth.co.uk>
Date:   Wed Oct 15 11:12:44 2025 +0000

    Bug 40504: atomicupdate
    
    Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk>
    Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit 124a7bed651f45a704ac1f02ec4760186c7f4510
Author: Pedro Amorim <pedro.amorim@openfifth.co.uk>
Date:   Wed Oct 15 13:11:42 2025 +0000

    Bug 40504: Add tests
    
    Test plan, ktd, apply patches:
    1) Enable ILLModule
    2) Create a new ILL request, visit:
    <staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard
    3) Set a 'type', add a cardnumber e.g. '23529000035676', and a library. Click 'Submit'.
    4) Notice the new 'Managed by' field entry on the 'Manage request' page. This should be assigned to your logged in user.
    5) Click 'Edit request' from the top toolbar
    6) Notice the new 'Managed by' form entry. Click 'Select manager' and click 'Search'. Only the 'koha' user should be returned.
    7) Notice the message at the top 'Only staff with superlibrarian or ILL permissions are returned in the search results'.
    8) Let's give 'ill' permissions to Edna Acosta, visit:
    <staff_url>/cgi-bin/koha/members/member-flags.pl?member=5
    9) Search for 'ill' permission (Search for 'interlibrary' on the top right search bar) and set 'ill' permission to Edna Acosta. Save.
    10) Repeat 6). Notice that now when you use the patron search modal Edna Acosta is also returned. Select Edna. Click 'Submit' to edit the request.
    11) Edit again. Notice the 'Managed by' is showing 'You', with the message 'Previously was Edna Acosta'. This is the desired behavior mimicked from Suggestions i.e. the staff member that is editing the request details is assumed to becomes it's manager by default. The staff member must click 'Keep existing manager' if they want to submit changes without changing the request's manager. Test buttons, save, verify that it all works.
    12) Visit the ILL list table:
    <staff_url>/cgi-bin/koha/ill/ill-requests.pl
    13) Click 'columns' and pick 'Managed by'. Notice it shows correctly with the link to the patron and sorting also works.
    14) Create a new user without permissions (OPAC only user)
    15) Access the OPAC ILL and login as that user (preferably on a different browser session as we'll want to access the staff UI as staff member again), visit:
    <opac_url>/cgi-bin/koha/opac-illrequests.pl?op=add_form&backend=Standard
    16) Pick a type and click 'Create'
    17) Repeat 12) Notice the newly created request from OPAC is 'Managed by': Nobody. This is intentional as that request still needs to be assigned to a staff member.
    
    Suggestions testing:
    1) This testing is also important as the existing suggestions 'Managed by' functionality has been abstracted to be utilized by both the suggestions and ILL module.
    2) Access suggestions, visit:
    <staff_url>/cgi-bin/koha/suggestion/suggestion.pl
    3) Click 'New purchase suggestion'. Notice the select manager button is also there. Click it and click 'search'. On the modal, the following message should show 'Only staff with superlibrarian or full suggestions permissions are returned in the search results' and the patrons shown should reflect that.
    4) Do the same exercises here as we just did for the ILL module, i.e. create a staff member with permission 'suggestions.suggestions_manage' and ensure that shows on the modal, assign that patron as manager, edit again, verify that it defaults to 'You' and that the 'Keep existing manager' button works as before.
    5) Finally, test the suggestions list table, repeat 2) and notice the 'Update manager' action at the bottom, test that that works just as well, by checking a few suggestions boxes, selecting a manager to your selection and clicking the 'Submit' button under it.
    
    Run tests:
    prove t/db_dependent/Koha/ILL/Request.t
    prove t/db_dependent/api/v1/ill_users.t
    
    Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk>
    Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit 11ac1c48ec8c11716cfe4e7e4fd3908afa5e6301
Author: Pedro Amorim <pedro.amorim@openfifth.co.uk>
Date:   Wed Oct 15 11:00:30 2025 +0000

    Bug 40504: Auto functionality:
    
    - The staff member who creates a new ILL request is automatically assigned as its manager.
    - No manager is assigned to ILL requests made by users without 'ill' permission e.g. patrons using the OPAC.
    - When an ILL request without a manager has its status changed, the staff member making the change is automatically assigned as its manager e.g. by clicking 'confirm' or 'revert request'.
    - It is possible to manually update a request's manager by clicking the 'Edit request' toolbar button when viewing a request. The patron search modal, 'select manager' button and all its functionality is shared with the 'select manager' present in the suggestions module. This means that when editing an ILL request, the 'managedby' defaults to the staff member editing the request, unless 'Keep existing manager' is clicked, like it happens in suggestions.
    - This is fully core built, all backends will automatically hook into this functionality, because:
    -- Automatic 'managedby' happen on status change, regardless of backend
    -- All requests have access to 'edit request' page, regardless of backend
    - Only if a logged in staff member exists does the auto set manager. If no staff member is found, nothing happens e.g. an ILL request status
    was changed by a CLI command / cronjob
    
    Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk>
    Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit e9c3c47bd5374fda401a96ccf960ca2bbb1578c2
Author: Pedro Amorim <pedro.amorim@openfifth.co.uk>
Date:   Wed Oct 15 10:52:18 2025 +0000

    Bug 40504: UI improvements
    
    This turns the 'Select manager' and 'Restore manager' actions to proper buttons, well aligned in where they are displayed. The 'Select manager' functionality in the suggestions table page is also updated to make use of the same reusable button block
    
    Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk>
    Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit ade2934e2af1fc9b93fec9049b1a42957733ece4
Author: Pedro Amorim <pedro.amorim@openfifth.co.uk>
Date:   Wed Oct 15 09:10:40 2025 +0000

    Bug 40504: Add 'managedby' to illrequests
    
    This also includes a 'manager' accessor which returns the Koha::Patron
    object
    
    Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk>
    Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit b0714a0b22fe09d9f078ab0c5d9278285ed7cc42
Author: Pedro Amorim <pedro.amorim@openfifth.co.uk>
Date:   Wed Oct 15 09:09:28 2025 +0000

    Bug 40504: Add ill/users API endpoint
    
    Required to get users filtered by 'ill' permission for patron search modal
    
    prove t/db_dependent/api/v1/ill_users.t
    
    Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk>
    Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit 2c5bc2875c55f953fbe0d577866ddc3761e11f39
Author: Pedro Amorim <pedro.amorim@openfifth.co.uk>
Date:   Wed Oct 15 09:07:25 2025 +0000

    Bug 40504: Preparation: Disambiguation of .clear_search
    
    This is required, or clicking 'Clear' on the ILL patron search modal will trigger this event listener and cause a JS error, as the 'regular' ILL table is not shown/initialized when editing an ILL request
    
    Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk>
    Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit afa20faf24d5cc3b8ce7b216672e4f513b0c991b
Author: Pedro Amorim <pedro.amorim@openfifth.co.uk>
Date:   Wed Oct 15 09:06:29 2025 +0000

    Bug 40504: Preparation: Add empty_table_settings option to patron_search_js
    
    This is required for ILL 'select manager' functionality, as table_settings are already defined there and the user modal table will pick that up unless explicitly stated to not use it, thus empty_table_settings
    
    Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk>
    Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit 09742f82c77a585c72dbf27252b4e40dc95abf0d
Author: Pedro Amorim <pedro.amorim@openfifth.co.uk>
Date:   Wed Oct 15 08:56:40 2025 +0000

    Bug 40504: Preparation: Abstract 'managed by' functionality from suggestions
    
    Move 'managed by' and 'restore previous manager' form and show
    functionality to reusable .inc files
    
    Signed-off-by: Jeremy Evans <Jeremy.Evans@ukhsa.gov.uk>
    Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>

commit 59890fa4da89f5c9cc9991af2208845b49184dd2
Author: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Date:   Tue Mar 24 15:01:33 2026 +0100

    Bug 40383: (follow-up) Add nonce attribute to inline script in basket.tt
    
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit 631498e94e08227101c5cd1ab28d5f8f67f4afc4
Author: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Date:   Mon Mar 9 07:46:32 2026 +0000

    Bug 40383: (follow-up) Address code review concerns
    
    - Move TT interface/theme variables into a separate <script> tag to avoid
      mixing template variables with external JavaScript file scope
    - Replace local escapeHtml() functions in edifact_interchange.js and
      edifact_errors.js with String.prototype.escapeHtml already defined
      in staff-global.js
    
    Sponsored-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit e9045ddedc95c9d408f9dcb662a376fdefff636d
Author: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Date:   Mon Mar 2 11:06:20 2026 +0000

    Bug 40383: (QA follow-up) Update Cypress tests to follow current best practices
    
    Remove before()/after() DB hooks — all assertions already use cy.intercept
    mocks so no real database messages are needed. Extract repeated button
    injection into an openEDIModal() helper. Replace all cy.wait(N) fixed-time
    waits with assertion-based waits and cy.wait('@alias') for network sync.
    Fix a Bootstrap 5 race condition in the modal-close cleanup test where
    hidden.bs.modal fired after the backdrop animation, causing the re-opened
    modal's focus class to be removed mid-test.
    
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit 4da37cad60ebc2c875e6b97e8dec08a660db4d91
Author: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Date:   Tue Jul 22 14:18:30 2025 +0100

    Bug 40383: Add Cypress test coverage for EDIFACT modal
    
    This patch adds end-to-end testing for the EDIFACT modal interface,
    providing coverage of all user interactions and functionality.
    
    **Test Coverage:**
    - Modal display and initialization with proper Bootstrap navbar structure
    - View toggle functionality between tree and raw display modes
    - Search functionality including navigation, result counting, and highlighting
    - Focus functionality for basket and invoice contexts
    - Error handling for invalid message IDs and network failures
    - Accessibility features including keyboard navigation
    - Responsive behavior and modal interaction patterns
    
    **Test Plan:**
    1. Apply patch
    2. Ensure KTD environment is running with test data
    3. Run tests: `npx cypress run --spec "t/cypress/integration/Acquisitions/Edifact*"`
    4. **Verify Test Results:**
    5. **Manual Verification:**
       - All test scenarios reflect real user workflows
       - Test data requirements are clearly documented in spec file
       - Test data is cleaned up after the tests are run
    
    Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk>
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit d726a935184d1fcf6075d6133fe1122ac5baa330
Author: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Date:   Tue Jul 22 14:17:21 2025 +0100

    Bug 40383: Enhanced EDIFACT message modal with search and focus functionality
    
    This patch completely rebuilds the EDIFACT message modal interface, featuring:
    
    **Core Features:**
    - Modern Bootstrap 5 navbar with integrated search functionality
    - Tree view and raw view display modes for message structure
    - Real-time search with regex support and result navigation
    - Smart focus functionality that highlights relevant segments based on
      context (basket, invoice)
    
    **User Interface:**
    - Bootstrap navbar between modal header and body
    - Search form with previous/next navigation and live result counts
    - Clean separation between always-visible controls and view-specific toolbars
    - Accessibility conscious with proper ARIA labels and semantic markup
    - Streamlined DOM structure with direct modal-body scrolling
    
    **Test Plan:**
    1. Apply patch and run: yarn css:build to compile SCSS
    2. Navigate to Acquisitions > EDIFACT messages
    3. Click "View message" on any EDIFACT message
    4. **Modal Display Testing:**
       - Verify modal opens with Bootstrap navbar between header and body
       - Confirm tree view is active by default with segment structure visible
       - Click raw view button to verify plain text display
       - Test modal responsiveness by resizing window
    5. **Search Functionality Testing:**
       - Enter "UNH" in search field, verify navbar shows result count
       - Use previous/next buttons to navigate between results
       - Test search with terms like "ORDER", "NAD", "LIN" - all results should be found
       - Verify native browser clear button appears and works
       - Test case-insensitive search behavior
    6. **Focus Functionality Testing:**
       - From basket page, click enhanced view link - should highlight relevant segments
       - From invoice page, click enhanced view - should focus on invoice-related segments
       - Verify focus highlighting persists during search operations
    7. **Error Handling Testing:**
       - Test with invalid message ID, verify error display
       - Test network errors, confirm loading states work properly
    8. **Accessibility Testing:**
       - Verify keyboard navigation works with search controls
       - Test screen reader compatibility with ARIA labels
       - Confirm modal can be closed with Escape key
    
    Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk>
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit 1f5f91e649ee788f19327e17a97ddffbf8e46d7f
Author: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Date:   Tue Jul 22 14:08:59 2025 +0100

    Bug 40383: Add JSON representation to Koha::Edifact and JSON download to edimsg.pl
    
    This patch implements a JSON representation of EDIFACT interchanges for enhanced
    programmatic access and debugging capabilities.
    
    Backend Changes:
    - Add to_json() method to Koha::Edifact module
    - Structured JSON output with header, messages array, and trailer
    - Segment parsing with raw data, elements arrays, and line_id tracking
    - Line item grouping using LIN segment identifiers
    
    Frontend Changes:
    - Add JSON download button to edimsg.pl page
    - Support for ?format=json parameter and Accept: application/json header
    - Proper HTTP content-type handling for JSON responses
    - Error handling for missing messages in JSON format
    
    JSON Structure:
    {
      "header": "UNB+UNOC:3+...",
      "messages": [
        {
          "header": "UNH+1+QUOTES:D:93A:UN:EAN008'",
          "segments": [
            {
              "tag": "LIN",
              "raw": "LIN+1+1+9780552150040:EN'",
              "elements": ["1", "1", "9780552150040:EN"],
              "line_id": "1"
            }
          ],
          "trailer": "UNT+25+1'"
        }
      ],
      "trailer": "UNZ+1+1'"
    }
    
    Test plan:
    1. Apply this patch
    2. Ensure you have EDIFACT messages in your system
    3. Go to Acquisitions > EDIFACT messages
    4. Click "View message" for any message
    5. Click the new "JSON" button
    6. Verify JSON downloads with proper structure
    7. Verify direct URL access with ?format=json parameter works
    8. Test with Accept: application/json header
    
    Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk>
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit e8cdc4e9d5ebeb8fbf4602deae49c50a64904ab0
Author: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Date:   Tue Jul 22 13:54:18 2025 +0100

    Bug 40383: Add unit tests for Koha::Edifact to_json method
    
    This patch adds unit tests for the new to_json method being introduced
    in Koha::Edifact module in the next patch.
    
    The tests verify:
    - JSON output generation and validity
    - Proper structure with header, messages, and trailer fields
    - Message array structure with correct number of messages
    - Individual message structure (header, segments, trailer)
    - Segment data integrity including raw data and elements arrays
    - Line ID functionality for related segments (LIN, QTY, PRI, PIA)
    
    Test plan:
    1. Apply this patch and the next one
    2. Run: prove t/Edifact.t
    3. Verify all 63 tests pass
    4. Confirm the new JSON-related tests (22 tests) execute successfully
    
    Sponsored-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
    Signed-off-by: Hannah Dunne-Howrie <hdunne-howrie@westminster.gov.uk>
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit 11de56769b298ddd92a389f9a7c278c2b3d5df2c
Author: David Cook <dcook@prosentient.com.au>
Date:   Thu Mar 12 04:25:22 2026 +0000

    Bug 42072: Improve message about deleting bib records
    
    This patch clarifies which records will be deleted in
    the batch item deletion (when no items remain).
    
    Test plan:
    0. Apply the patch
    1. Go to "Reports" and click "Create from SQL"
    2. Create a report with the following SQL:
    select itemnumber from items limit 5
    3. Run the report and then click "Batch operations with 5 visible records"
    on the output page
    4. Near the bottom of the screen note that there is a checkbox that
    has a label reading "Delete bibliographic records if no items remain."
    5. C'est tout!
    
    Signed-off-by: David Nind <david@davidnind.com>
    Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit 0dc06596e25a8f3eaf55dc013e11e4764bd76244
Author: Janusz Kaczmarek <januszop@gmail.com>
Date:   Tue Feb 3 14:07:11 2026 +0000

    Bug 41759: The display of MARC 21 field 026 data (Fingerprint Identifier) is missing (both in intranet and OPAC)
    
    Test plan
    =========
    1. Make field 026 active for Editor in MARC framework section (e.g. in default
       framework).
    2. Edit any bibliographic record (with modified framework) adding 026 field data,
       e.g. 026 ## $a urdu esrt $b eses jecl $c 1790
    3. Verify in Normal view (intranet) and in OPAC that you are unable to
       see the inserted data.
    4. Apply the patch ; restart_all.
    5. Verify in Normal view (intranet) and in OPAC that you are now able to
       see the fingerprint information from 026 field.
    
    Sponsored-by: Ignatianum University in Cracow
    Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit 71af0f01d1b5e00c31616dd9c5b1a526ed41dbbb
Author: Janusz Kaczmarek <januszop@gmail.com>
Date:   Tue Feb 3 12:11:24 2026 +0000

    Bug 41758: Add Fingerprint Identifier data to Elasticsearch index mappings
    
    Libraries cataloguing older monographic resources request fingerprint indexing.
    
    In MARC 21, it would be the content of field 026, in UNIMARC - 012.
    
    Test plan
    =========
    1. Start up KTD with Elasticsearch: ktd --search-engine es8 up -d
    2. Make field 026 active for Editor in MARC framework section (e.g. in default
       framework).
    3. Edit any bibliographic record (with modified framework) adding 026 field data,
       e.g. 026 ## $a urdu esrt $b eses jecl $c 1790
    4. Verify that you are unable to find the record searching with fingerprint data.
    5. Apply the patch ; restart_all.
    6. Reindex with: koha-elasticsearch --rebuild -r -d kohadev
    7. Now you should be able to find the record searching with fingerprint data
       (performing a general search or prefixed with 'fingerprint-identifier:').
    
    Sponsored-by: Ignatianum University in Cracow
    Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
    Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit 4cdce0479c527070ea9844b4296ac4941d677b77
Author: Owen Leonard <oleonard@myacpl.org>
Date:   Thu Mar 19 07:26:20 2026 -0400

    Bug 42134: String displays incorrectly: words “notices” and “for” appear concatenated
    
    This patch changes the way the notices template checks for the existence
    of the TranslateNotices system preference in order to avoid a missing
    space in the corresponding label.
    
    To test you should have at least two languages enabled under the
    StaffInterfaceLanguages system preference.
    
    - Apply the patch and go to Administration -> System preferences..
    - Locate the TranslateNotices preference and set it to "Allow"
    - Go to Tools -> Notices and edit a notice.
    - The "Modify notice" page should have tabs each of your enabled
      languages as well as "Default."
    - Each tab should have a "Format" section. Expand it and check that the
      label for the checkbox at the bottom is correct, e.g. "Apply format
      settings to all notices for this language."
    - Return to system preferences and set TranslateNotices to "Don't
      allow."
    - Reload the notice edit screen and check the "Format" section. The
      label should now read "Apply format settings to all notices."
    
    Sponsored-by: Athens County Public Libraries
    Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
    Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit 3b75ede4fd4c125e2f23ebe3b000126147d36db2
Author: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Date:   Thu Mar 26 13:49:01 2026 +0100

    Bug 28884: DBRev 25.12.00.038
    
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit cc0e314f72516832c814a342f21e295b1a3adf7f
Author: Nick Clemens <nick@bywatersolutions.com>
Date:   Wed Mar 25 11:18:13 2026 +0000

    Bug 28884: (QA follow-up) Add some missing pod
    
    Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit 388bcec0ac22192e702c2b87fb69d40856900ecb
Author: Janusz Kaczmarek <januszop@gmail.com>
Date:   Wed Mar 4 15:31:24 2026 +0000

    Bug 28884: Add 'ElasticsearchEscapeCharacters' and 'OpacElasticsearchEscapeCharacters' system preferences
    
    Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
    Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit 3b1566b40208d6acab87ed10db25130dc5928a8b
Author: Janusz Kaczmarek <januszop@gmail.com>
Date:   Wed Mar 4 17:28:27 2026 +0000

    Bug 28884: Unit tests
    
    Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
    Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>