commit 6415b36695abb56fb6e62651db1e400bdb307505
Author: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Date:   Tue Mar 24 11:31:52 2026 +0100

    Bug 41439: Fix hidden column inputs resetting values on save
    
    When editing a rule while a column group is hidden, DataTables removes
    hidden <td> elements from the DOM. On form submit, restoring visibility
    with columns().visible(true) re-inserts those cells with empty inputs,
    causing the corresponding fields to be saved as empty (e.g. unlimited).
    
    Before making all columns visible, repopulate hidden column inputs from
    the highlighted display row using DataTables' cached cell nodes. Mirrors
    the same special-case logic used when clicking Edit (unlimited fields,
    hardduedate, no_auto_renewal_after_hard_limit, cap_fine_to_replacement_price).
    
    Also add CSP nonce to the <style> element to fix QA forbidden_patterns.

commit 027b7b47aa72cd59168cb97f630f5db42dbb51ba
Author: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Date:   Fri Dec 19 10:19:04 2025 +0000

    Bug 41439: Fix form submission for hidden column inputs
    
    When using the column visibility toggles, only inputs in the
    currently visible columns were being submitted with the form.
    This meant that if a user edited a value in "Checkouts" view,
    then switched to "Holds" view to edit another value, only the
    holds values would be saved.
    
    This patch adds a form submit handler that temporarily shows
    all columns before form submission, ensuring all input values
    are included regardless of which view is currently active.
    
    Test plan:
    1. Navigate to Administration > Circulation and fine rules
    2. Click "Checkouts" button
    3. Enter a value in "Current checkouts allowed" field
    4. Click "Holds" button
    5. Enter a value in "Holds allowed (total)" field
    6. Click Save
    7. Verify both values are saved (previously only the holds
       value would be saved)

commit e0ec9d6803f45db86c7ca106390ba4baa69d7d99
Author: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Date:   Fri Dec 12 11:29:16 2025 +0000

    Bug 41439: Add column visibility toggles to circulation rules table
    
    The circulation rules table has become excessively wide with 40+
    columns, making it difficult to navigate and use. This patch adds
    column visibility toggle buttons that allow users to focus on
    specific rule categories.
    
    Changes:
    - Add data-colname attributes to all table headers and footers
      for robust column identification
    - Add toggle buttons for: Checkouts, Due dates, Fines, Renewals,
      Holds, Article requests, Recalls, and Show all
    - Group columns into logical categories based on their function
    - Use column name selectors instead of fragile index-based
      selection for maintainability
    - Default to showing only Checkout columns on page load for a
      cleaner initial view
    - Highlight the active button to indicate current view
    - Disable search functionality (not appropriate for this table)
    - Handle dynamic column visibility based on system preferences
      (UnseenRenewals, ArticleRequests, UseRecalls)
    
    Test plan:
    1. Navigate to Administration > Circulation and fine rules
    2. Observe the table now shows only checkout-related columns by
       default with the "Checkouts" button highlighted
    3. Click different category buttons (Fines, Renewals, Holds, etc.)
       and verify only relevant columns are shown
    4. Verify the active button is highlighted in blue
    5. Click "Show all" to display all columns
    6. Verify the layout works with different system preference
       combinations (enable/disable ArticleRequests, UseRecalls,
       UnseenRenewals)
    7. Verify column visibility persists correctly when system
       preferences are changed

commit a12aac8957efad724ab5a30f3d221567b460967c
Author: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date:   Fri Jan 23 10:35:53 2026 +0100

    Bug 41521: Silent perlcritic warnings
    
    Stricture disabled at line 67, column 5.  See page 429 of PBP.  (Severity: 5)
    
    We should deal with that later instead of ignoring the warnings
    
    Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
    Signed-off-by: David Cook <dcook@prosentient.com.au>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit d0ee8f5a6e9cb4bebb209c05e938c8111273cdb2
Author: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date:   Fri Jan 23 10:31:32 2026 +0100

    Bug 41521: Fix forbidden patterns (trailing spaces and http)
    
    Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
    Signed-off-by: David Cook <dcook@prosentient.com.au>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit 8c46e76045046d66e10a18a340728c84e4bb1cca
Author: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date:   Fri Jan 23 10:28:27 2026 +0100

    Bug 41521: Fix spelling
    
    Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
    Signed-off-by: David Cook <dcook@prosentient.com.au>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit bbf43f465e6b4e7f2cf555ad3eecf830d9f1a0f0
Author: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date:   Fri Jan 23 10:22:23 2026 +0100

    Bug 41521: Exclude lib/WebService from pod xt tests
    
    Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
    Signed-off-by: David Cook <dcook@prosentient.com.au>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit f9788889f3866f687f0049d37133e5ad92e7dec8
Author: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date:   Fri Jan 23 10:06:23 2026 +0100

    Bug 41521: Remove deps from cpanfile
    
    Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
    Signed-off-by: David Cook <dcook@prosentient.com.au>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit b7b85b3eebfe101dd25db822a3689c419dc2226c
Author: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date:   Fri Jan 23 09:55:06 2026 +0100

    Bug 41521: Reject lib/ from tidy check
    
    Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
    Signed-off-by: David Cook <dcook@prosentient.com.au>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit b4b62d082073d8a312b25b78c37906ad05a6f87d
Author: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date:   Fri Jan 23 09:32:16 2026 +0100

    Bug 41521: Remove perl valid warnings
    
    % perl -wc Koha/ExternalContent/OverDrive.pm
    Possible precedence issue with control flow operator (die) at /kohadevbox/koha/lib/WebService/ILS/OverDrive/Patron.pm line 365.
    Possible precedence issue with control flow operator (die) at /kohadevbox/koha/lib/WebService/ILS/OverDrive/Patron.pm line 573.
    Possible precedence issue with control flow operator (die) at /kohadevbox/koha/lib/WebService/ILS/OverDrive/Patron.pm line 643.
    
    Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
    Signed-off-by: David Cook <dcook@prosentient.com.au>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit 5d516102c82feb4b5100acc05803b412e30c337f
Author: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date:   Fri Jan 23 09:29:51 2026 +0100

    Bug 41521: Add WebService::ILS to lib/
    
    Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
    Signed-off-by: David Cook <dcook@prosentient.com.au>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit 63a1924b271584c25b4a120c0318a5ca79c9f6d5
Author: Hammat Wele <hammat.wele@inlibro.com>
Date:   Thu Nov 13 13:23:55 2025 +0000

    Bug 33857: Avoid increasing file size while uploading image
    
    This patch prevents image size from increasing while uploading by
    keeping the original image format
    
    Test plan:
    
    1. Download the attached image large-image.jpg
      --> It should be ~170kB and 1000×1500 pixels
    2. Enable LocalCoverImages in System preferences
    3. Find a record in the staff interface
    4. Go to "Images" tab
    5. Upload large-image.jpg image
       5.1. Click on "Upload"
       5.2. Click on "Drop files here or click to select a file"
       5.3. Choose picture (large-image.jpg)
       5.4. Click on "Process images"
    6. Click on image for large image
    7. Right-click on the image and save it
      --> It is ~930kB and 600x900 pixels
    
    8. Apply the patch and flush browser cache (Crtl+F5) to update js files
    9. Detele the previous uploaded image
    10. Repeat step 3, 4, 5, 6, 7
       --> The image is ~92kB and 600x900 pixels
    11. prove t/db_dependent/Koha/CoverImages.t
       --> All tests should be successful
    
    Signed-off-by: Owen Leonard <oleonard@myacpl.org>
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit 699ba06eb70d3488fba0ba47f406ffe4fe96f4f9
Author: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Date:   Mon Mar 23 13:22:04 2026 -0400

    Bug 41386: (QA follow-up) Make sure charge is defined
    
    Check that $charge is defined before comparing, to avoid "argument isn't
    numeric" error if no charge is defined.
    
    Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit b33a7c1df45ff82c07a744a0b803641c111f8d8c
Author: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
Date:   Tue Dec 9 14:56:09 2025 +0200

    Bug 41386: Do not allow 0.00 values to be passed from Koha::Hold->cancel
    
    In method Koha::Hold->cancel in the section where we charge a cancel
    fee there is a if statement "if $charge" after calling sub add_debit.
    This allows value "0.00" to be passed to the add_debit and it then
    gets caught in statement "unless ( $amount > 0 )" which calls exception
    AmountNotPositive. This happens at least when syspref
    ExpireReservesMaxPickUpDelayCharge or circulation rule "Expired hold charge"
    has value 0.00 and cronscript cancel_expired_holds.pl is run. This patch
    fixes the if statement in Koha::Hold->cancel.
    
    To test:
    1. Enable syspref ExpireReservesMaxPickUpDelay.
    2. Set syspref ReservesMaxPickUpDelay value as 1.
    3. Set syspref ExpireReservesMaxPickUpDelayCharge value as 0.00.
    4. Make sure you have a waiting hold which has expiration date further
    in the past than ReservesMaxPickUpDelay value in your database. If not,
    create one.
    5. Run cronscript cancel_expired_holds.pl.
    => Exception 'Koha::Exceptions::Account::AmountNotPositive' thrown
    'Debit amount passed is not positive' is raised.
    6. Set syspref ExpireReservesMaxPickUpDelayCharge value as 0 and run
    cronscript again.
    => No exception is raised.
    7. Apply this patch and restart services if needed.
    8. Create a new waiting hold with expiration date in the past.
    9. Run cronscript again.
    => No exception is raised.
    => Confirm that no cancel fee was added for patron.
    
    Also prove t/db_dependent/Koha/Holds.t.
    
    Sponsored-by: Koha-Suomi Oy
    Signed-off-by: Bernard Scaife <bernard.scaife@openfifth.co.uk>
    Signed-off-by: David Nind <david@davidnind.com>
    Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit f26e9344b001f9c9c838b6dea1f242c0a69e5c20
Author: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Date:   Tue Mar 24 09:53:49 2026 +0100

    Bug 41479: DBRev 25.12.00.033
    
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit 2e853287f869b0ef7b3e0a92666f5062ed79b4fa
Author: Owen Leonard <oleonard@myacpl.org>
Date:   Wed Mar 18 08:41:44 2026 -0400

    Bug 41479: (follow-up) Remove bakertaylorimages.js
    
    Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit 41ea86bc27d660ed8c9dede89fd62c75d844d3eb
Author: Owen Leonard <oleonard@myacpl.org>
Date:   Thu Dec 18 08:49:32 2025 -0500

    Bug 41479: Remove Baker & Taylor integration
    
    This patch removes Baker & Taylor integration following the shutdown of
    the company.
    
    To test, apply the patch, run the database update, and restart all.
    
    - In the staff interface go to Administration -> System preferences and
      search for 'Baker.' There should be no results.
    - If necessary enable at least one cover image service, e.g.
      AmazonCoverImages, OpacCoce, GoogleJackets, etc.
    - Log in to the OPAC and confirm that cover images display correctly on
      these pages:
       - Search results
       - Bibliographic detail page
       - Shelf browser
       - Your summary -> Checked out
         - Checkout history
       - Recent comments
       - Lists
    
    Sponsored-by: Athens County Public Libraries
    Signed-off-by: David Nind <david@davidnind.com>
    Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit 101f292a5af8150cdb80e680e980cedbcb8410bd
Author: Pedro Amorim <pedro.amorim@openfifth.co.uk>
Date:   Fri Mar 13 11:54:45 2026 +0000

    Bug 41614: available options template params also needed for op=list
    
    Test plan, before applying patch:
    1) Visit additional contents for HTML customizations:
    <staff_url>/cgi-bin/koha/tools/additional-contents.pl?category=html_customizations
    2) Click the left side 'Display location' filter. No options show under OPAC or Staff interface
    3) Apply patch, restart plack, refresh. All options should now show (and working filter as expected) under OPAC and Staff interface
    
    Signed-off-by: David Nind <david@davidnind.com>
    Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit 46f618d3c4e36fd2723334b01a34739fe85bd52b
Author: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Date:   Mon Mar 23 13:01:25 2026 +0100

    Bug 40286: (RM follow-up) Make codespell happy

commit 50df5d5acaf8b21ee242318a8173c32c172c9ae5
Author: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Date:   Mon Mar 23 11:14:40 2026 +0100

    Bug 40136: (RM follow-up) Add missing pod coverage for private subs
    
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit 863b68b1356a27f1a023a53e7f57409bcef05f54
Author: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Date:   Mon Mar 23 11:05:36 2026 +0100

    Bug 40136: (RM follow-up) Fix logaction to JSON-encode plain hashref infos
    
    Commit 55689d41ba6 changed Koha::Patron::extended_attributes() and
    add_extended_attribute() to pass plain hashrefs to logaction() and
    updated tests to expect JSON in the info column. However, logaction()
    still had a code path that converted any non-CATALOGUING hashref $infos
    to a Dumper() string before the encode_json() at line 151 could fire,
    so JSON was never stored and the tests failed.
    
    Remove the catch-all Dumper branch; non-CATALOGUING hashref inputs now
    fall through to the existing encode_json() call. The CATALOGUING/MODIFY
    biblio-Dumper special case is preserved.
    
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit 25b7068b497b0014c910f3b3d8af164f6943a3eb
Author: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Date:   Thu Mar 12 09:23:14 2026 +0000

    Bug 40136: (follow-up) Log newly-filled fields when editing a patron
    
    Previously, _unblessed_for_log strips undef/empty fields, so fields
    that were blank before an edit were absent from $from_storage. Because
    @keys was built only from keys %{$from_storage}, any field that
    transitioned from empty to a value was never iterated and the change
    went unlogged.
    
    Fix by unioning keys from both old and new state so that added,
    changed, and cleared fields are all detected.
    
    Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit f4db130ad4f9a956dfee804711bb2134b8905f6c
Author: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Date:   Wed Mar 11 12:49:05 2026 +0000

    Bug 40136: (follow-up) Unify patron log entries when attributes change with patron data
    
    Three issues were reported with patron action logging:
    
    1. CREATE followed by extended_attributes() produced two log entries
       (CREATE for patron fields + MODIFY for attributes) instead of one.
    2. MODIFY that changed both regular fields and patron attributes produced
       two separate MODIFY entries instead of one unified entry.
    3. DELETE log did not include the patron's extended attribute values.
    
    Fix:
    - logaction() now explicitly returns the stored Koha::ActionLog object so
      callers can capture the action_id.
    - Koha::Patron::store() saves the action_id of the CREATE or MODIFY log it
      writes into $self->{_patron_log_id}.
    - Koha::Patron::extended_attributes() setter checks for _patron_log_id. If
      set, it calls _merge_attribute_log() to fold the attribute changes into
      the existing log entry (updating its info and diff JSON) instead of
      creating a new MODIFY entry. This covers both the CREATE and MODIFY cases.
    - Koha::Patron::delete() now iterates extended_attributes before deletion
      and adds attribute.CODE keys to the patron_data snapshot, so the DELETE
      diff includes the removed attributes.
    - New private helper _merge_attribute_log() decodes an existing action log
      entry's info/diff JSON, merges in the attribute change data using
      Struct::Diff, and saves the updated entry.
    - Tests added to t/db_dependent/Koha/Patrons.t covering all three scenarios.
    
    Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit 7287b091a45691ff8f01d23229be388bf88ff340
Author: Lisette Scheer <lisette@bywatersolutions.com>
Date:   Tue Mar 10 14:27:44 2026 +0000

    Bug 40136: (QA follow-up) Fix tests
    
    Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit 543ebdc2ff6fd5b7678f1988409203454e05cd0d
Author: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Date:   Tue Mar 10 09:39:18 2026 +0000

    Bug 40136: (follow-up) Strip undef and empty fields from patron log data
    
    Exclude fields with undef or empty string values from _unblessed_for_log
    so that CREATE and DELETE log diffs only show fields with meaningful values.
    
    Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit 55689d41ba6d6e6feabc6b19ebd9ada869d338c7
Author: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Date:   Mon Mar 9 22:15:08 2026 +0000

    Bug 40136: (follow-up) Fix extended_attributes logaction to populate diff column
    
    The extended_attributes setter and add_extended_attribute both logged
    attribute changes using the old custom {before, after} format passed as
    the info string, with no $original argument, so the diff column was never
    populated.
    
    Split the existing $change->{before}/$change->{after} into separate
    $log_from/$log_to hashrefs and call logaction with the standard signature,
    so Struct::Diff generates the diff column as with other MEMBERS/MODIFY
    entries.
    
    Update tests to reflect the new info column format (after-state only)
    and remove a stray debug Data::Dumper/print left in the test.
    
    Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit 9ae4911704082121ac18b13491272b68809db4e0
Author: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Date:   Mon Mar 9 22:05:08 2026 +0000

    Bug 40136: (follow-up) Refactor MODIFY log to use _unblessed_for_log
    
    Replace the manual unblessed + skip_fields + blessed-stringify logic in
    the MODIFY actionlog section with calls to _unblessed_for_log, which
    already handles all three concerns. This removes the need for @skip_fields,
    the dateexpiry normalisation workaround, and the inline blessed checks.
    
    Also restrict the log_from/log_to hashrefs to only the changed keys, so
    the diff column contains only fields that actually changed rather than
    the full patron state.
    
    Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit f83424d3dd92b7ed03fded2a4725d3043eb65e3c
Author: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Date:   Fri Mar 6 17:02:26 2026 +0000

    Bug 40136: Populate diff column for patron CREATE, MODIFY and DELETE logs
    
    Previously MEMBERS/CREATE and MEMBERS/DELETE logged empty info with no
    diff, and MEMBERS/MODIFY stored a custom {field:{before,after}} JSON in
    the info column with no diff column entry.
    
    This updates all three to use the standard logaction pattern:
    - CREATE: diff({}, patron_data) — all fields shown as added
    - MODIFY: diff(old_state, new_state) via Struct::Diff; info column now
      holds the full updated patron state (consistent with other modules)
    - DELETE: diff(patron_data, {}) — all fields shown as removed
    - MODIFY_CARDNUMBER: likewise uses standard pattern with diff column
    
    Password, lastseen and updated_on are excluded from all log payloads.
    DateTime objects (inflated date/datetime columns) are stringified to
    their ISO representation before JSON serialisation.
    
    Tests updated to verify changes via the diff column rather than the
    former custom info format.
    
    Signed-off-by: David Nind <david@davidnind.com>
    Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit 9d20ea636ad1780beeb4086904632a8fe1775984
Author: Lisette Scheer <lisette@bywatersolutions.com>
Date:   Fri Mar 6 18:05:08 2026 +0000

    Bug 20956: (QA follow-up) Restore info pretty
    
    I restored the pretty code for the info file because the page needs to be able to wrap, like it does for other logs.
    
    Signed-off-by: David Nind <david@davidnind.com>
    Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit f528142daa322796c9848e2baf7def12298f7d79
Author: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Date:   Fri Mar 6 16:55:28 2026 +0000

    Bug 20956: (follow-up) Nest permissions data under 'permissions' key in MEMBERS/MODIFY log
    
    Changes to patron permissions via member-flags.pl are logged as MEMBERS/MODIFY,
    indistinguishable from regular patron field edits. This patch wraps the
    before/after permission hashes under a 'permissions' key so that the diff
    renderer displays changes as 'permissions.cataloguing' etc., making it clear
    the diff relates to permissions rather than first-level patron fields.
    
    Signed-off-by: David Nind <david@davidnind.com>
    Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit 182ccd1c0b363c3f0497000f9ea42662e1950b4a
Author: Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com>
Date:   Wed Feb 4 17:07:08 2026 -0500

    Bug 20956: Fix test failures
    
    Signed-off-by: David Nind <david@davidnind.com>
    Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit cd34882803ea78b285bf811dc3c05ac74e136594
Author: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Date:   Mon Dec 22 17:06:31 2025 +0000

    Bug 20956: (QA follow-up) Match getuserflags() return structure
    
    This patch changes Koha::Patron->permissions() to return the same
    structure as C4::Auth::getuserflags() for architectural consistency.
    
    Previously, permissions() only returned granted permissions:
    {
      catalogue => 1,
      circulate => { override_renewals => 1 }
    }
    
    Now it returns ALL flags (matching getuserflags()):
    {
      superlibrarian => 0,
      catalogue => 1,
      circulate => { override_renewals => 1 },
      borrowers => 0,
      ...
    }
    
    This provides several benefits:
    
    1. Consistency - Matches established C4::Auth::getuserflags() pattern
    2. Simpler checks - Can use "if ($flags->{module})" instead of
       "if (exists $flags->{module})"
    3. Future compatibility - Enables eventual deprecation of getuserflags()
       in favor of the ORM-based $patron->permissions()
    4. Helper compatibility - Works with existing _dispatch() logic
    
    The logging functionality still works correctly - the diff will now
    show explicit changes from 0 to 1 rather than absence to presence.
    
    Test plan:
    1. prove t/db_dependent/Koha/Patron.t
    2. prove t/db_dependent/Log.t
    3. Verify all tests pass
    4. Confirm permissions() now returns all flags with 0/1 values
    
    Signed-off-by: David Nind <david@davidnind.com>
    Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit ae60527f91422b053fc55018b35f161362e0fa14
Author: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Date:   Mon Dec 22 16:38:42 2025 +0000

    Bug 20956: (QA follow-up) Fix tests and refactor to use ORM
    
    This patch addresses several QA concerns:
    
    1. Fixed duplicate subtest name - renamed second "is_superlibrarian() tests"
       to "permissions() tests" which accurately reflects what it tests
    
    2. Fixed incorrect hash assignment - permissions() returns a hashref,
       not a hash. Changed `my %permissions` to `my $permissions`
    
    3. Improved test coverage - expanded from 2 to 8 assertions covering:
       - Hashref return type verification
       - Single flag permission
       - No permissions
       - Multiple flags
       - Granular subpermissions from user_permissions table
    
    4. Refactored permissions() method to use DBIx::Class ORM instead of
       raw SQL queries, following Koha::Object architecture principles
    
    All tests now pass without warnings.
    
    Test plan:
    1. prove t/db_dependent/Koha/Patron.t
    2. prove t/db_dependent/Log.t
    3. Verify all tests pass
    4. Confirm the test now properly validates the intended behavior
    
    Signed-off-by: David Nind <david@davidnind.com>
    Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit c092059a7756b8074d6f27d9de41806f2677da7f
Author: Hammat Wele <hammat.wele@inlibro.com>
Date:   Tue Oct 21 20:45:58 2025 +0000

    Bug 20956: (follow-up) Tidyness and fix no pod coverage in Koha/Patron.pm
    
    Signed-off-by: Hammat Wele <hammat.wele@inlibro.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
    Signed-off-by: David Nind <david@davidnind.com>
    Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit 489f19a410376847eed3fd2eba4b7352404b62c1
Author: Kyle M Hall <kyle@bywatersolutions.com>
Date:   Wed Oct 8 13:41:33 2025 -0400

    Bug 20956: (QA follow-up) Move subs to Koha::Patron, add unit tests
    
    Subroutines in members/member-flags.pl are combined and moved to Koha::Patron
    
    Removed the html-based english description of each permission from the logging
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
    Signed-off-by: David Nind <david@davidnind.com>
    Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit 553a18da0984215767a954cab937e0307f0a9dd4
Author: Hammat Wele <hammat.wele@inlibro.com>
Date:   Fri Sep 12 19:14:59 2025 +0000

    Bug 20956: BorrowersLog is not logging permission changes
    
    Changes to permissions are not logged in the Koha action_logs, making it impossible to trace changes to staff permissions. This patch ensures that all changes to permissions are logged.
    
    Test plan:
    
        1. Go to a staff interface
        2. Search for a patron and change their permissions (note their borrowernumber)
        3. Go to tools/Log viewer
        4. Filter by Module = Patrons, Object = <borrowernumber>.
        5. Click on submit
           ==> No permission changes are logged.
        6. Apply the patch
        7. Repeat step 1, 2, 3, 4, 5
           ==> Permission changes are now logged
        8. Check that the diff column contains the change:
           select diff from action_logs where object= <borrowernumber> order by action_id desc limit 1;
    
    Signed-off-by: David Nind <david@davidnind.com>
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
    Signed-off-by: David Nind <david@davidnind.com>
    Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit 983792537973060c258c0097113ed4c58a4c0dbf
Author: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Date:   Thu Mar 12 10:51:09 2026 +0000

    Bug 40135: (follow-up) Add tests for Koha::Biblio::_unblessed_for_log
    
    Add a '_unblessed_for_log() tests' subtest to t/db_dependent/Koha/Biblio.t
    that verifies:
    - the method returns a plain hashref
    - fields with real values (biblionumber, title, author) are present
    - timestamp is excluded
    - undef fields are excluded
    - empty-string fields are excluded
    - the ADD action log diff column is populated and does not contain timestamp
    
    Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit a8578c93f0f8ac01d1630520412b681d9a762ed8
Author: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Date:   Thu Mar 12 10:48:13 2026 +0000

    Bug 40135: (follow-up) Strip undef and empty fields from biblio log data
    
    Add _unblessed_for_log to Koha::Biblio, mirroring the same method in
    Koha::Patron (bug 40136). It excludes undef/empty-string columns and the
    auto-updated timestamp field so that biblio diffs only contain meaningful
    values.
    
    Update AddBiblio, ModBiblio and DelBiblio in C4/Biblio.pm to use
    _unblessed_for_log instead of raw unblessed when building the hashrefs
    passed to logaction, eliminating noise from null columns in ADD/MODIFY/DELETE
    diffs.
    
    Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit ef7dde45f773d7ec06c749935f3e359728429d7b
Author: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Date:   Mon Mar 9 21:46:09 2026 +0000

    Bug 40135: Fix info column prefix for biblio MODIFY logs
    
    The MODIFY path in logaction received the updated biblio as a plain
    hashref (not a Koha::Object), so the info column was populated with
    raw Dumper output instead of the expected "biblio ..." prefix.
    
    This broke two things: the 'Modification Log' link from the bib record
    sidebar (which filters on info LIKE 'biblio%'), and the Object column
    in the log viewer (which detects biblio entries via info.substr(0,6)).
    
    Following the same pattern as the Koha::Item MODIFY special case, add
    a parallel branch for CATALOGUING MODIFY with a hashref \$infos that
    sets the info column to "biblio " . Dumper(\$original). This restores
    backward-compatible detection while keeping the diff column correctly
    populated from the before/after hashrefs (including _marc changes).
    
    Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit f8f653f71ef9674c5753956aacc1a5499bf60ba5
Author: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Date:   Mon Mar 9 16:26:42 2026 +0000

    Bug 40135: Include MARC field changes in CATALOGUING diff logs
    
    The previous commit populated the diff column for biblio ADD/MODIFY/DELETE
    logs with changes to biblio table columns (title, author, frameworkcode,
    etc.), but lost the MARC-level change tracking that previously stored a
    pre-change MARC dump in the info column.
    
    This follow-up extends the diff to also capture MARC field changes by
    including a synthetic _marc key in the before/after hashrefs passed to
    logaction. MARC fields are represented as tag => array-of-formatted-strings
    (e.g. "10 $a Title" for data fields, scalar for control fields), allowing
    Struct::Diff to produce readable field-level diffs.
    
    The _marc entries appear alongside biblio column changes in the existing
    diff table in the log viewer, using dotted keys like _marc.245.0.
    
    A helper _marc_record_to_diffable() converts a MARC::Record to this
    diffable hashref. All three functions (AddBiblio, ModBiblio, DelBiblio)
    use record_strip_nonxml (wrapped in eval) to safely capture the MARC even
    for records with invalid XML characters, without producing warnings or
    affecting the success of the main operation.
    
    C4/Log.pm is also updated to Dumper() a plain hashref passed as $infos,
    so the info column contains useful data rather than a stringified ref.
    
    Tests are extended to verify that the diff column is populated and that
    _marc changes are captured when MARC content actually changes.
    
    Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit f16d5f3ad4c0a39dc6014db1f3056eba69179f5d
Author: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Date:   Fri Mar 6 16:35:08 2026 +0000

    Bug 40135: Populate diff column for biblio ADD/MODIFY/DELETE logs
    
    Previously the CATALOGUING action log entries for biblio operations
    stored minimal data: ADD and DELETE logged just the string "biblio",
    while MODIFY logged a raw MARC-formatted dump of the pre-change record
    as a plain text string. None of these populated the diff column.
    
    This follow-up updates AddBiblio, ModBiblio and DelBiblio in C4/Biblio.pm
    to follow the same pattern as Koha::Item::store, passing the Koha::Biblio
    object and an original unblessed hashref to logaction so that the diff
    column is automatically populated with Struct::Diff JSON reflecting the
    changes to the biblio table columns (title, author, frameworkcode, etc.).
    
    For ADD, logaction diffs an empty hashref against the new biblio state,
    producing added-field entries for all columns. For DELETE, it diffs the
    pre-deletion state against an empty hashref, producing removed-field
    entries. For MODIFY, the before-state is captured prior to the update and
    the after-state is read back once ModBiblioMarc and _koha_modify_biblio
    have completed, so the diff reflects the actual committed changes.
    
    The test for ModBiblio on an invalid MARC record is updated to reflect
    that the MARC decoding error is no longer logged in the info column;
    the biblio table data is now logged instead.
    
    Signed-off-by: David Nind <david@davidnind.com>
    Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit 788d1b455fd7b816cb9899fa7d17b0a9dc8471b4
Author: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Date:   Fri Mar 6 16:16:23 2026 +0000

    Bug 36698: Expand nested object values in diff table
    
    When the diff column contains a value that is itself an object (e.g.
    a set of granular subpermissions such as
    {"override_renewals":1,"manage_curbside_pickups":1}), the previous
    renderer would JSON.stringify it into a single unreadable cell.
    
    This follow-up makes fmt() recurse into objects, rendering them as
    an indented <ul> list of key: value pairs instead. The <del>/<ins>
    colour wrapper then highlights the entire expanded block, making it
    clear at a glance which subpermissions were added or removed.
    
    null values (e.g. suspend_until transitioning to/from null) are
    rendered as empty, letting the red/green cell background convey
    the presence or absence of the value.
    
    Signed-off-by: David Nind <david@davidnind.com>
    Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit 56a8a9a9346e78fd7ee927a9aa54881b12a73eab
Author: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Date:   Fri Mar 6 15:54:46 2026 +0000

    Bug 36698: Render diff column as a human-readable table in the log viewer
    
    Previously the diff column in the log viewer displayed raw Struct::Diff
    JSON (e.g. {"D":{"superlibrarian":{"N":1,"O":0}}}), which was not
    useful to end users.
    
    This follow-up adds a JavaScript renderer (renderStructDiff) to
    viewlog.js that parses the Struct::Diff JSON and presents it as a
    compact Field / Before / After table, reusing the existing <del>/<ins>
    colour styling already present for the jsdiff compare feature. Nested
    diffs (e.g. granular subpermissions) are flattened using dot-separated
    key names. Non-Struct::Diff content falls back gracefully to a <pre>
    block so that entries from other modules are not affected.
    
    The change benefits all modules that currently populate the diff column:
    HOLDS (MODIFY/SUSPEND/RESUME/CANCEL/FILL), CATALOGUING (MODIFY),
    APIKEYS (MODIFY/REVOKE/ACTIVATE), and MEMBERS (MODIFY for permissions).
    
    Signed-off-by: David Nind <david@davidnind.com>
    Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit bf0c748315301bda5b8794542eb06c25e4e04237
Author: Kyle M Hall <kyle@bywatersolutions.com>
Date:   Fri Feb 20 15:58:51 2026 +0000

    Bug 41107: (QA follow-up) Tidy status.t
    
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit f64051cddb875b7c87f6e877af6ad1c2bf4d4699
Author: Tomás Cohen Arazi <tomascohen@theke.io>
Date:   Wed Nov 5 11:28:59 2025 -0300

    Bug 41107: (follow-up) Use Koha::Status in Koha::Template::Plugin::Koha
    
    This patch makes the template plugin used for rendering the Koha version
    use the introduced method.
    
    I did this checks:
    
    ```shell
    cd koha-tmpl
    git grep Koha.Version
    ```
    
    The places Koha.Version is used, it is used as:
    
    * `Koha.Version.maintenance`
    * `Koha.Version.release`
    * Assigned to a variable like this `SET koha_version = Koha.Version`
    
    All occurences of the `koha_version` template variable are:
    
    * `koha_version.development`
    * `koha_version.major`
    * `koha_version.minor`
    
    This implies the newly added `.version` attribute has no undesired side
    effects in templates.
    
    Note: plugins-home.tt has a different use of a variable named the same,
    which is unrelated.
    
    To test:
    1. Apply this patch
    2. Run:
       $ ktd --shell
      k$ prove t/Koha_Template_Plugin_Koha.t
    => SUCCESS: Tests pass!
    3. Sign off :-D
    
    Signed-off-by: David Nind <david@davidnind.com>
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit 68c8b8f13fad886b3d516fbfdc17a3b2198a0bdf
Author: Tomás Cohen Arazi <tomascohen@theke.io>
Date:   Wed Nov 5 10:20:48 2025 -0300

    Bug 41107: Add /status/version API endpoint
    
    Adds a new REST API endpoint to retrieve Koha version information.
    
    This implementation includes:
    - Koha::Status class for instance status information
    - /status/version endpoint returning structured version data
    - OpenAPI specification with koha_version definition
    - REST controller for handling the endpoint
    
    The returned version object includes:
    - version: full version string (e.g., '25.06.00.029')
    - major: major version number
    - minor: minor version number
    - release: major.minor version
    - maintenance: major.minor.maintenance version
    - development: development version (if applicable)
    
    This prepares the foundation for a future /status endpoint that will
    include all information displayed in the about page.
    
    To test:
    1. Apply the patch
    2. Run:
       $ ktd --shell
      k$ yarn api:bundle
    3. Run the tests:
      k$ prove t/Koha/Status.t \
               t/db_dependent/api/v1/status.t
    => SUCCESS: Tests pass!
    4. Sign off :-D
    
    Signed-off-by: David Nind <david@davidnind.com>
    Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit 7929a1198edb30519c5519e1d85400508e18290c
Author: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Date:   Mon Mar 23 09:30:12 2026 +0100

    Bug 41814: DBRev 25.12.00.032
    
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit 41e729baba99c23da452cb287f5966f8446093e0
Author: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Date:   Mon Mar 23 09:15:11 2026 +0100

    Bug 41814: (RM follow-up) Add PatronAgeRestriction to UsageStats
    
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit 8948d7117ad6fc2fe1532ff722b7734774c04343
Author: Katrin Fischer <katrin.fischer@bsz-bw.de>
Date:   Fri Feb 20 14:59:00 2026 +0000

    Bug 41814: (QA follow-up) Add bug number to atomic update and some style fixes
    
    Sponsored-by: Cheshire West and Chester Council
    Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>

commit c1f0d97e8b8318ab479960294db7188ecf931b96
Author: Jake Deery <jake.deery@openfifth.co.uk>
Date:   Wed Feb 11 09:16:49 2026 +0000

    Bug 41814: Add PatronAgeRestriction syspref and code
    
    This patch adds a new PatronAgeRestriction, which acts in the same way
    PatronSelfRegistrationAgeRestriction (a restriction on the maximum age
    of a borrower), except for the intranet. It will also act as the
    maximum age restrictor on the OPAC, in the event that the
    PatronSelfRegistrationAgeRestriction is not set.
    
    To test:
    == APPLY PATCH ==
    a)  updatedatabase
    b)  Set the PatronAgeRestriction syspref to 20, set the
        PatronSelfRegistrationAgeRestriction to 30
    c)  On the OPAC, try to create or modify a patron whose age is 35 years
        *)  Note the error message presented, suggesting the age exceeds the
        maximum
    d)  On the OPAC, try to create or modify a patron whose age is 25 years
        *)  Note the submission succeeds
    e)  On the staff client, try to create or modify a patron whose age is
        25 years *)  Note the error message presented, suggesting the age
        exceeds the maximum
    f)  Set the PatronSelfRegistrationAgeRestriction to empty
    g)  On the OPAC, try to create or modify a patron whose age is 25 years
        *)  Note the error message presented, suggesting the age exceeds
        the maximum
    h)  On the OPAC, try to create or modify a patron whose age is 19 years
        *)  Note the submission succeeds
    i)  Set the PatronAgeRestriction to empty
    j)  On the staff client, try to create or modify a patron whose age is
        75 years
        *)  Note the submission succeeds
    k)  On the OPAC, try to create or modify a patron whose age is 75 years
        *)  Note the submission succeeds
    == SIGN OFF ==
    
    Sponsored-by: Cheshire West and Chester Council
    Signed-off-by: Owen Leonard <oleonard@myacpl.org>
    Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
    Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>