commit fa8bc948987010a309c9a6e2081d5f0c65738843 Author: Pedro Amorim Date: Wed Apr 16 12:19:16 2025 +0000 Bug 37901: Add Tests Example reports that can be written for ILL pseudonymized data: --Total of requests of a given request type (article)-- SELECT COUNT(*) AS count FROM pseudonymized_transactions pt WHERE EXISTS ( SELECT 1 FROM pseudonymized_metadata_values pmv WHERE pmv.transaction_id = pt.id AND pmv.key = 'type' AND pmv.value = 'article' ); --Add backend info to listing-- SELECT pt.*, (SELECT pmv.value FROM pseudonymized_metadata_values pmv WHERE pmv.transaction_id = pt.id AND pmv.key = 'type') AS type, (SELECT pmv.value FROM pseudonymized_metadata_values pmv WHERE pmv.transaction_id = pt.id AND pmv.key = 'backend') AS backend FROM pseudonymized_transactions pt; --List all pseudonymized transactions and respective metadata values-- SELECT pt.*, table1.metadata AS borrower_attributes, table2.metadata AS illrequestattributes FROM pseudonymized_transactions pt LEFT JOIN ( SELECT transaction_id, GROUP_CONCAT(DISTINCT CONCAT(`key`, ':', value)) AS metadata FROM pseudonymized_metadata_values WHERE tablename = 'borrower_attributes' GROUP BY transaction_id ) table1 ON pt.id = table1.transaction_id LEFT JOIN ( SELECT transaction_id, GROUP_CONCAT(DISTINCT CONCAT(`key`, ':', value)) AS metadata FROM pseudonymized_metadata_values WHERE tablename = 'illrequestattributes' GROUP BY transaction_id ) table2 ON pt.id = table2.transaction_id; commit c2f118ca8ef5b159e06635a49448eff9934fef1a Author: Pedro Amorim Date: Wed Mar 5 12:45:52 2025 +0000 Bug 37901: Add updatedatabase information This warning will display if there are existing reports that contain 'pseudonymized_borrower_attributes', informing that these reports need to be updated commit 8c2f44f34c6f5d770f295f287ba2b8554ba99add Author: Pedro Amorim Date: Mon Mar 3 15:32:08 2025 -0100 Bug 37901: UpdateStats after new ILL request is created or completed commit fe2a7c309a79fe71bfcd5120d897e6822ec64890 Author: Pedro Amorim Date: Mon Mar 3 15:31:30 2025 -0100 Bug 37901: Update Statistic.pm Consider 'ill' as a category and 'illreq_created' and 'illreq_comp' as allowed types commit d69d830b6469389a8a9bba41753326a0866e13e2 Author: Pedro Amorim Date: Mon Mar 3 15:30:11 2025 -0100 Bug 37901: Consider illrequest_id when creating or completing When a new PseudonymizedTransaction is created, consider the presence of illrequest_id and act on it accordingly. commit 0b79cdf1ac1f1af112fde0a0580e30246c682fcb Author: Pedro Amorim Date: Mon Mar 3 15:27:50 2025 -0100 Bug 37901: atomicupdate: Add 'illrequest_id' column to statistics commit 5e06be15567c7e18ad93b66391f416703943211c Author: Pedro Amorim Date: Mon Mar 3 15:26:58 2025 -0100 Bug 37901: [DONT PUSH] dbic commit 6209a755888a79c7b1867c2f93cf857101c26201 Author: Pedro Amorim Date: Mon Mar 3 15:26:16 2025 -0100 Bug 37901: Add 'illrequest_id' column to statistics commit 6a71f32f256fa891ebb3703acd67ce49787ec8f5 Author: Pedro Amorim Date: Wed Mar 5 10:36:00 2025 +0000 Bug 37901: Preparation: Update tests commit 89fdd446c87ac8b01a64b34d3f0c8d7e385279c2 Author: Pedro Amorim Date: Mon Mar 3 15:38:32 2025 -0100 Bug 37901: Preparation: Update borrower attribute types logic This now conforms to the new pseudonymized_metadata_values instead of pseudonymized_borrower_attributes commit 0812ea0bb8bbfadac3ea4c259176164bf26548a8 Author: Pedro Amorim Date: Mon Mar 3 10:10:08 2025 -0100 Bug 37901: Preparation: atomic update Rename the table pseudonymized_borrower_attributes to pseudonymized_metadata_values This is so that pseudonymizing other 'extended_attributes' type of data, such as illrequestsattributes, becomes possible. commit f9e8357d172ee2e9165155fdd704d2dc5ca3cf96 Author: Pedro Amorim Date: Mon Mar 3 10:09:58 2025 -0100 Bug 37901: Preparation: db changes commit c4397a21117b5ead5a78f42f7419a0f063e8648f Author: Pedro Amorim Date: Mon Mar 3 10:07:14 2025 -0100 Bug 37901: Preparation: [DONT PUSH] automated dbic commit 22df1785833afff9665c71b0d808c70571523de5 Author: Pedro Amorim Date: Wed Apr 16 11:45:27 2025 +0000 Bug 39652: store PseudonymizedTransaction before adding related entries Test plan: Run the tests before and after applying this patch: perl t/db_dependent/Koha/Pseudonymization.t They should fail before this patch and pass after applying patch. commit fe45ef4fe1a69652b8fdafd1d48de69daf764c24 Author: Pedro Amorim Date: Wed Apr 16 11:00:49 2025 +0000 Bug 39652: Add tests These tests prove the bug: perl t/db_dependent/Koha/Pseudonymization.t commit 8f39014d50127935f48cfb9d1c67300b268e0198 Author: Marcel de Rooy Date: Fri Mar 14 08:40:30 2025 +0000 Bug 37784: (QA follow-up) Add few tables to Koha::Database::Columns This resolves exceptions like: Invalid table name accountlines at /usr/share/koha/C4/Reports/Guided.pm line 216. Test plan: Go to reports/dictionary.pl Try to add a new definition for Serials. Without this patch, you would crash (status 500). Run t/Koha/Database/Columns.t Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer commit 7738fcbb88dd83d24d10d3fe6db62da343168ee4 Author: Marcel de Rooy Date: Fri Mar 14 09:31:57 2025 +0000 Bug 37784: (QA follow-up) Bail out to new definition The code went back to step 3 but the error message is not there. It is easier to go back to the start: no need to fetch columns. And this is now an exception; it will only come up when trying malicious things. Also turned foreach and unless forbidden around. No need to go into the loop when we found a forbidden field. Test plan: See first patch. You should see the message now. Signed-off-by: Katrin Fischer commit 8a86f5e7cd342aa6877ae23c00ef2895192993a1 Author: Aleisha Amohia Date: Fri Aug 30 02:04:48 2024 +0000 Bug 37784: Do not show forbidden columns in reports dictionary This patch prevents forbidden columns from being selected using the reports dictionary. To test: 1. Go to Reports -> View dictionary 2. Choose 'new dictionary' 3. After providing a name and description, select the 'patrons' table 4. Select the 'password' column and go Next 5. Notice it is possible to see a list of all the password hashes in the 'choose' selection box when asked to specify a value 6. Apply patch and restart services 7. Repeat steps 1-3 8. Notice the 'password' column and other forbidden columns are not available to be selected 9. Open the Inspector / developer tools in your browser and find the code for the columns selection 10. Change the value of one of the options in the code to "borrowers.password". So it may end up looking like this: 11. Choose that option from the dropdown and click Next. 12. Confirm you are redirected back to this page and warned about the column being used. 13. Ensure tests pass t/db_dependent/Reports/Guided.t Sponsored-by: Reserve Bank of New Zealand Signed-off-by: David Cook Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer commit c24969a20867ccaba018035adec8c9c92a2a2e57 Author: David Cook Date: Wed Nov 20 01:09:00 2024 +0000 Bug 31165: Scrub "Public note" field for Course Reserves When displaying the "Public note" for Course Reserves, we scrub the HTML using the "note" scrubber type. Test plan: 0. Apply the patch 1. Go to http://localhost:8081/cgi-bin/koha/course_reserves/course-reserves.pl 2. Click "New course" 3. Fill in required fields 4. In staff note and public note add the following:

Hello!

5. Click Save 6. Click "Add reserves" 7. Add "39999000001310" to Item barcode 8. Click "Submit" 9. Fill in all required fields 10. Add the following for Staff note and Public note:

Item!

11. Click "Save" 12. Go back to your course reserve 13. Note the HTML is scrubbed on "Public note" 14. Go to http://localhost:8081/cgi-bin/koha/course_reserves/course-reserves.pl 15. Note the HTML is scrubbed on "Public note" 16. Go to http://localhost:8080/cgi-bin/koha/opac-course-reserves.pl 17. Note the HTML is scrubbed on "Notes" 18. Click on your course reserves 19. Note the HTML is scrubbed on "Notes" Signed-off-by: Brendan Lawlor Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer commit 58bd633d8efeeb9c2298ea13c35b019fa8b603c7 Author: Jonathan Druart Date: Tue Mar 18 13:41:52 2025 +0100 Bug 39319: Improve pod_checker.t It was not failing when warnings were found Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 15a030bc7601ed04d14a1d107706f1afdbec2151 Author: Jonathan Druart Date: Thu Mar 13 16:28:11 2025 +0100 Bug 39319: Fixes for Pod::Checker Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 9d51a95037457969576c88625d91166ece4445ef Author: Jonathan Druart Date: Thu Mar 13 16:27:39 2025 +0100 Bug 39319: Add test using Pod::Checker podchecker is used by the QA script and catch more than Test::Pod Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 7e160cf6a2ac4f952a5ec997ddeda013c967da14 Author: Jonathan Druart Date: Thu Mar 13 09:52:10 2025 +0100 Bug 39319: Fix POD for misc/migration_tools/koha-svc.pl Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 278de79e4aaf2f29258a0e19adfe6ee652964931 Author: Jonathan Druart Date: Thu Mar 13 09:47:27 2025 +0100 Bug 39319: Make podcorrectness.t test controller and test perl files It only tested files within C4 and Koha directories. Now we test all the perl files that are in the git index. Test plan: 0. Do not apply those patches 1. prove xt/author/podcorrectness.t Notice "Tests=1208" meaning that 1208 files are tested 2. Apply this patch (not the second one) It fails, and more files are being tested (3254) xt/author/podcorrectness.t .. 1994/3254 xt/author/podcorrectness.t .. 2726/3254 # Looks like you failed 1 test of 3254. 3. Apply the second patch => It passes! Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 64e51d89e1307008f04bd8d6888260b5d6399151 Author: Jonathan Druart Date: Thu Mar 20 16:51:15 2025 +0100 Bug 35560: historical => past Signed-off-by: Baptiste Wojtkowski Signed-off-by: Katrin Fischer commit 963424d7c77f1d8c4347c9414790a6ba19144b39 Author: Owen Leonard Date: Tue Mar 4 12:38:42 2025 +0000 Bug 35560: (follow-up) Changes to classes and ids; BS5 follow-ups This follow-up changes the "selected" class to "select_hold_status" to avoid possible future collisions with other CSS. IDs are added to the checkbox containers because I can already tell that some libraries will want to hide the "Processing" checkbox which is only relevant to some setups. The patch also makes a couple corrections to "alerts" to update them with BS5 classes. Signed-off-by: Baptiste Wojtkowski Signed-off-by: Katrin Fischer commit 86b4fcf656bf1de0418fac6344938d972ec49e5d Author: Owen Leonard Date: Thu Mar 28 17:17:26 2024 +0000 Bug 35560: (follow-up) Add in-page links to jump between tables Also a terminology change: I think "Past holds" reads better than "Historical holds." Signed-off-by: Lucas Gass Signed-off-by: Jonathan Druart Signed-off-by: David Nind Signed-off-by: Owen Leonard Signed-off-by: Baptiste Wojtkowski Signed-off-by: Katrin Fischer commit 605ca6176e3ff1c8bc5885100517f0cee7b268f0 Author: Jonathan Druart Date: Mon Mar 25 16:27:23 2024 +0100 Bug 35560: Add filter on status Signed-off-by: Lucas Gass Signed-off-by: Jonathan Druart Signed-off-by: David Nind Signed-off-by: Owen Leonard Signed-off-by: Baptiste Wojtkowski Signed-off-by: Katrin Fischer commit d581f067d6e8f39a856d10c1f7672be5772cc343 Author: Jonathan Druart Date: Mon Mar 25 17:23:00 2024 +0100 Bug 35560: Use the REST API for holds This patch uses the new REST API endpoint to retrieve the old holds. We can now have 2 tables, one for the current holds and one for the old ones. Test plan: Have several holds with several statuses. Notice that you see the holds in the respective tables. Test the usual sorting filtering DT feature and confirm that everything works as expected. Signed-off-by: Lucas Gass Signed-off-by: Jonathan Druart Signed-off-by: David Nind Signed-off-by: Owen Leonard Signed-off-by: Baptiste Wojtkowski Signed-off-by: Katrin Fischer commit 6881b674e6f9fa3664a05969f3630f3c333a024b Author: Tomás Cohen Arazi Date: Fri Mar 21 12:07:22 2025 -0300 Bug 36365: (follow-up) Indexing should be done async and in chunks Signed-off-by: Tomas Cohen Arazi Signed-off-by: Thomas Klausner Signed-off-by: Katrin Fischer commit 3669cb0eed97cdc0c8bcb324ead34dfab6a3b0c9 Author: Tomás Cohen Arazi Date: Fri Feb 14 22:35:41 2025 +0000 Bug 36365: Add a way for compare_es_to_db.pl to fix problems This patch adds a new option switch `--fix` (or `-f`) to make the script try to fix the problems it found. Bonus: `--help` option switch added. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ perl -MKoha::SearchEngine -MKoha::SearchEngine::Indexer -e 'my $i = Koha::SearchEngine::Indexer->new({index => $Koha::SearchEngine::BIBLIOS_INDEX}); $i->delete_index([1]);' => SUCCESS: Bibliographic record #deleted from ES index 3. Run: k$ koha-mysql kohadev > DELETE FROM biblio WHERE biblionumber=2 OR biblionumber=3; => SUCCESS: Bibliographic records 2 and 3 deleted directly from the database, no reindex triggered by Koha. 4. Run: k$ perl misc/maintenance/compare_es_to_db.pl => SUCCESS: The results from (2) and (3) are explained. [1] 5. Run: k$ perl misc/maintenance/compare_es_to_db.pl --fix => SUCCESS: It says it is gonna fix things 6. Repeat 4 => SUCCESS: The problems we generated are no longer reported! They've been fixed! 7. Sign off :-D [1] Note KTD ships some broken records on purpose so devs need to deal with a not-perfect DB everyday, and catch misses in the code. Signed-off-by: Andrew Fuerste Henry Signed-off-by: Lisette Scheer Signed-off-by: Thomas Klausner Signed-off-by: Katrin Fischer commit 5986c6649c7958565b221268f8e72c791a01189a Author: Katrin Fischer Date: Mon Apr 14 06:50:40 2025 +0000 Bug 37211: DBRev 24.12.00.024 Signed-off-by: Katrin Fischer commit c273ba3150529c02ba1d37fa3e68ec49431001cc Author: Lucas Gass Date: Mon Mar 31 10:18:50 2025 +0000 Bug 37211: Use HTML textarea for the notes Signed-off-by: Katrin Fischer commit 519df374729a032823cc39d852d4571ee5f67b76 Author: Lucas Gass Date: Mon Mar 31 09:58:15 2025 +0000 Bug 37211: Update permission name to edit_accountline_notes Signed-off-by: Katrin Fischer commit 73568a081c49d2112f381e423689ffd84c10a05d Author: Lucas Gass Date: Mon Mar 31 09:50:47 2025 +0000 Bug 37211: Tidy Signed-off-by: Katrin Fischer commit b49d15c984f86d55c2ee419d6a6fca0bae72fb21 Author: Lucas Gass Date: Tue Mar 11 19:42:04 2025 +0000 Bug 37211: (QA follow-up) Update for bootstrap5 and remove copy/paste Signed-off-by: Katrin Fischer commit 763ed3eaba98a6b6fa3462ae10b1af84b4d6a39a Author: Martin Renvoize Date: Tue Jan 28 10:01:17 2025 +0000 Bug 37211: (QA follow-up) Update database update to be idempotent Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 38777f025a786772c135754044cdd48c130d597d Author: Sam Lau Date: Thu Jun 27 18:53:09 2024 +0000 Bug 37211: Add new subpermission in updatecharge 'edit_notes' Signed-off-by: Roman Dolny Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 8a77899cf067dab6ddb8fa4a406f5e44b189260f Author: Lucas Gass Date: Tue Mar 11 19:23:06 2025 +0000 Bug 37211: Make notes in patron transactions table editable Signed-off-by: Katrin Fischer commit 79e1f87a16e9f3b1d23777e90662c759eb56e73b Author: Pedro Amorim Date: Fri Dec 20 12:05:20 2024 +0000 Bug 38761: Don't pass the 'all' param when getting plugins Test plan: 1) Apply tests patch. Run. Notice it fails 2) Apply this patch. Run tests patch. Notice if passes. UI: 1) Enable ILLModule and install a backend plugin e.g.: https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.5 2) Create an ILL request: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl 3) Notice when you click 'New ILL request', 'PluginBackend' is listed even if the plugin is disabled. This patch fixes that. If there are existing requests and then their respective backend is disabled, no error occurs as plugins are loaded in the background even if disabled Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 3c9e78bc49778a6a88cdafbf72f6fc01fb98a81d Author: Pedro Amorim Date: Fri Dec 20 12:00:33 2024 +0000 Bug 38761: Add tests prove t/db_dependent/Koha/ILL/Request/Config.t Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 46e57842619943bdb19e539b95f2017fdd7bd70d Author: Katrin Fischer Date: Mon Apr 14 06:50:37 2025 +0000 Bug 35604: DBRev 24.12.00.023 Signed-off-by: Katrin Fischer commit 7a990de29d651ca9b230c40fb50b1e64e2548e27 Author: Tomás Cohen Arazi Date: Thu Apr 3 10:50:07 2025 +0200 Bug 35604: Move available_backends() to Koha::ILL::Request::Config This patch removes the the Koha::ILL::Backends class as it is not actually a Koha::Objects-based class as it claims, and also internally instantiates the config class, which could just hold the only defined method. This method is only used in the preferences.pl page, and its occurence is fixed by this patch. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer commit ba03de5f954b1eeb9272525b61b5c5d3e3dbd24a Author: Pedro Amorim Date: Wed Apr 2 13:02:56 2025 +0000 Bug 35604: (QA follow-up): Remove remaining 'automatic' occurrences From Hackfest QA session Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer commit c083d6e690c8703af49d5844b82c0fa9aab27dcb Author: Pedro Amorim Date: Tue Mar 25 16:43:11 2025 +0000 Bug 35604: Multiple QA followups Multiple fixes: - File permmissions - Capitalization - Translatability - Use of console.log - Atomic update description typo fix - Remove occurrences of 'auto' and 'automatic': User testing reported that making a UI distinction between 'regular' and 'automatic' ILL requests is redundant. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer commit 1afd6c124d10c77b2a595da634b3d2619a931788 Author: Pedro Amorim Date: Thu Jan 16 13:54:27 2025 +0000 Bug 35604: (QA follow-up): Prevent more than one 'op' in form This may happen if for example getting to the automatic backend screen from the ILL availability screen. 'op' is already being added, skip it if already exists in ported metadata Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer commit d39e9f3fc32a2cb40011842a9f2a8e49b645c5c8 Author: Pedro Amorim Date: Wed Jan 15 13:37:22 2025 +0000 Bug 35604: (QA follow-up): Fix find-missing-op-in-forms.t prove xt/find-missing-op-in-forms.t Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer commit 3357a4deca3776458a7f712036abaf5c1f6b06c1 Author: Pedro Amorim Date: Tue Dec 31 15:27:18 2024 +0000 Bug 35604: (QA follow-up): Cosmetic improvements These are improvements to the confirm auto backend stage screen on the Staff UI. Result of a chat with Tomas about this development. Sponsored-by: NHS England Sponsored-by: PTFS Europe Ltd Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer commit 8dbbc3bcd4076d0aeb3a088dfffb04f5452dc0e8 Author: Pedro Amorim Date: Tue Nov 19 15:07:43 2024 +0000 Bug 35604: Display success message Consider success message from backend and present it. Add btn-primary class to auto ILL screen Sponsored-by: NHS England Sponsored-by: PTFS Europe Ltd Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer commit debac6ac3c7271d48b8e726f3f244ffebb854a11 Author: Pedro Amorim Date: Wed Apr 3 15:51:33 2024 +0000 Bug 35604: Add tests Test plan: Apply patches Staff: 1) Visit the ILL sysprefs page: /cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loans 2) Enable ILLModule 3) Check the new AutoILLBackendPriority syspref. Notice it shows "No available backends" 4) Install 2 backend plugins from here: https://github.com/PTFS-Europe/koha-ill-backend-plugin/releases/tag/v2.0.5 https://github.com/PTFS-Europe/koha-ill-reprintsdesk/releases/tag/rc-v3.0.0 5) Repeat 1. Notice the backends now show. 6) Enable both for AutoILLBackendPriority by ticking each respective checkbox. Save. 7) Visit ILL requests: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl 8) Press "New auto ILL request" 9) You are presented the "Standard" create form. Pick type "journal" and put '123' on DOI. Enter '42' on cardnumber and pick a library. Click Create. 10) Notice you are now shown the "Confirm auto backend" stage screen. 11) PluginBackend has a 50% chance of being available or not for testing purposes. If it is, it'll suggest PluginBackend, if not, it'll default to Standard. ReprintsDesk will always error because it's missing credentials. 12) Pick any of the backends or accept the suggested one, click 'Create'. The request has been placed in that specific backend. OPAC: 1) Following from the previous test plan, visit OPAC ill requests: http://localhost:8080/cgi-bin/koha/opac-illrequests.pl 2) Click "Create a new auto request" and repeat the same inputs as before. Click 'Create'. 3) Notice you're directed to "Confirming your request" screen. It's doing the same as it does in the Staff UI, except it does not allow the patron to pick a different backend, it'll always selected the first available backend in the priority. 4) Create more requests, you'll notice some of them will land on PluginBackend, others will land on 'Standard' because PluginBackend will sometimes be available and others not. Do more testing: - Reorder the backends in the AutoILLBackendPriority syspref and save, notice they're shown and suggested accordingly after creating a request. - Disable all backends from AutoILLBackendPriority. Notice the original behaviour of requiring the user to select a backend before creating the request is restored on both opac and staff. Run unit tests: prove t/db_dependent/Illrequest/ConfirmAuto.t prove t/db_dependent/Koha/ILL/Backends.t Sponsored-by: NHS England Sponsored-by: PTFS Europe Ltd Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer