commit 300cb1d03d9bda6a1bfe8e385e612812519ee76d Author: Lucas Gass Date: Wed Apr 30 15:58:30 2025 +0000 Bug 39582: Syndetics support for UPC and OCLC numbers on OPAC results page To test: 1. Enable Syndetics 2. Have a record with an 024 and 1st indicator. 3. Do a search to return the record from step 3. 4. The image does not display. 5. APPLY PATCH 6. Try step 3 again, this time the cover image should display properly on the OPAC results page. Signed-off-by: Barbara Johnson commit 234b7259075e49df29627b72f93a336667ab14ac Author: Tomás Cohen Arazi Date: Tue Apr 29 10:01:15 2025 -0300 Bug 39600: Fix spec to include invalid query handling Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer commit a5f671330e5dec3ed561c3b27652a52a1958b69a Author: Jonathan Druart Date: Tue Apr 29 15:16:01 2025 +0200 Bug 39323: Fix selenium/update_child_to_adult.t This test is not really needed. It the new window opens correctly the next test will pass. And should fail if it does not. Signed-off-by: Katrin Fischer commit 60442a85734955d9015b29cc7c985ba41c62656e Author: Owen Leonard Date: Mon Apr 28 18:23:13 2025 +0000 Bug 39761: OPAC DataTables responsive table controls style broken by Bug 39600 This patch copies and adapts some CSS from the default DataTables CSS in order to add to the OPAC the required styles for new features added by the updated ILL request page: Paging, table information, and the "Processing" message shown while the table loads. To test, apply the patch and rebuild the OPAC CSS. You should have ILL enabled and configured. - Log in to the OPAC as a user who has submitted multiple ILL requests. - From the user summary page, click "Interlibrary loan requests" in the left-hand sidebar. - The table of ILL requests should look correct with legible information and controls. - All the DataTable features should work: Paging, showing different numbers of entries per page, sorting. - Go to the user summary page and confirm that the tables on that page still display correctly: Checkouts, overdues, holds, etc. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer commit 33311daea5ecec7b72450f0cab117815fac07408 Author: Tomás Cohen Arazi Date: Mon Apr 28 09:45:14 2025 -0300 Bug 39762: Add server-side rendering to OPAC datatables This patch ports the staff side feature into the OPAC. To be used by bug 39600. To test: 1. Apply and verify no behavior change in OPAC tables => SUCCESS: They work the same 2. Verify 39600 still works after bug 39739 iis reverted. => SUCCESS: It does 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer commit 877f1fdf79a69a2edeee8033ac239e5d327ab6d1 Author: Jonathan Druart Date: Tue Apr 29 15:29:33 2025 +0200 Bug 38842: Add a op=cud-null to the form This will make xt/find-missing-op-in-forms.t pass But also enforce the use of a op=cud- parameter. It is at the end of the form element, so if another is passed in the modal body the one passed will get retrieved properly by CGI->param Signed-off-by: David Nind Signed-off-by: Katrin Fischer commit 37538b22a07d503401a13a10caf18debcea05241 Author: Matt Blenkinsop Date: Mon Apr 28 09:44:48 2025 +0100 Bug 39752: Check for biblio existence when matches are found Currently when adding to a basket from a new/staged file, we don't check whether a matched record still exists when importing. This patch changes the conditional check to be based on the existence of the biblio record rather than just on the biblionumber from the match Test plan: 1) Stage and import a record into Koha 2) Stage the same record again, this time matching on ISBN 3) Check that the match has been found in the batch details 4) Delete the original record that you imported in step 1 5) Find a basket, and add to it from a staged file 6) Choose the file/record you imported in stage 2 7) Select the record and save to add the orders 8) You will get a 500 error 9) Apply patch and restart_all 10) Refresh the page to re-submit the form 11) The form should submit correctly Signed-off-by: David Nind Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer commit 08da4b33b01ae6da83c419835c576bb8c6d70049 Author: Nick Clemens Date: Tue Apr 29 13:13:27 2025 +0000 Bug 39752: (QA follow-up) Unit test Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer commit d7fb4a93fcddb66abb8f9085cea688176644b631 Author: Tomás Cohen Arazi Date: Mon Apr 28 14:41:18 2025 -0300 Bug 39765: Centralize loaded plugin caching Signed-off-by: Tomas Cohen Arazi Signed-off-by: Pedro Amorim Signed-off-by: Katrin Fischer commit 3d44cfa0b18bdd2fca9f8c9f5c9782763a843f93 Author: Jonathan Druart Date: Tue Apr 29 14:57:16 2025 +0200 Bug 39325: Fix t/Makefile.t Signed-off-by: Katrin Fischer commit e0b408df962ac805b4143ce062b08fcd8c836407 Author: Jonathan Druart Date: Tue Apr 29 09:26:20 2025 +0200 Bug 39325: (follow-up) Adjust DB commit 68325b37e2e8bc680935217ae3176085b8c1ff55 Author: Caroline Cyr La Rose Date: Tue Apr 8 09:52:25 2025 -0400 Bug 39565: Move OPACVirtualCard system preferences to features section This patch moves the OPACVirtualCard and OPACVirtualCardBarcode system preferences from the Suggestions subsection of the OPAC preferences to the Features subsection. To test: 1. Apply patch 2. Go to Administration > System preferences > OPAC 3. Search the page (Ctrl + F) for OPACVirtualCard --> The two preferences (OPACVirtualCard and OPACVirtualCardBarcode) should be in the Features section Signed-off-by: Aude Charillon Signed-off-by: David Nind Signed-off-by: Katrin Fischer commit c3dbb1876f16f5229900be444a538a8144f7acdd Author: Katrin Fischer Date: Mon Apr 28 16:48:12 2025 +0000 Bug 38441: DBRev 24.12.00.036 Signed-off-by: Katrin Fischer commit 72fe5765ecc719b4dbd6c2f4c483c9f3a8ff7e09 Author: Tomás Cohen Arazi Date: Thu Apr 17 15:14:30 2025 -0300 Bug 38441: (QA follow-up) Minor change Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer commit d9c6a1de11c8012a8737596839c0e042a9080065 Author: Pedro Amorim Date: Thu Apr 17 13:05:16 2025 +0000 Bug 38441: (QA follow-up): Only look for matchin requests if patron Previous commit 'HistoryCheck now only considers same patron' added the following regression: HistoryCheck is performed and shown in the OPAC even if no user is authenticated (using ILLOpacUnauthenticatedRequest). This fixes that. History check is skipped unless a user exists. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer commit 4da60d16699fddf03f3e323f53069565910440bd Author: Pedro Amorim Date: Mon Apr 14 11:11:48 2025 +0000 Bug 38441: (QA follow-up): Hackfest feedback This commit addresses all Hackfest QA related feedback: 1) Update of all strings that required update, including UI messages and sys pref description 2) Moved the history check information from staffnotes to its own pipe-separated illrequestattribute 'historycheck_requests' 3) Fix display of ILL request information on the history check screen (Staff), including proper label naming (e.g. branchcode -> library), show status description instead of code, uppercase labels. 4) Updated OPAC display to match Staff UI's display of matching history requests 5) Removed ISSN criteria for matching requests check 6) Update tests accordingly Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer commit 9a90757e257a82a40fde4874357a96415cc525f8 Author: Pedro Amorim Date: Mon Jan 20 16:07:40 2025 +0000 Bug 38441: (QA follow-up): HistoryCheck now only considers same patron Initial implementation checked existing ILLs for same patron and other patrons. User testing reported ILLs for other patrons are not helpful, and makes this stage screen show up much more frequently than it should. This patch simplifies the original implementation to only consider the patron of the request being placed for an ILL history check. It also changes the ID matching to only 'DOI' or only 'Pubmed ID' if any of those is set. This is to minimize scenarios where different articles from the same journal come up as matching results e.g. same ISSN but different DOI. It is also updating tests accordingly. Other QA improvements Improve HistoryCheck request list: - Make link external and show icon (to prevent staff member from clicking away from the historyCheck screen unintentionally) - Show requests' status - Show requests' placed date - Add id_prefix to request ID if possible Signed-off-by: Lisette Scheer Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer commit a358fcdb69fa071353a7800656e652a6af2dd62b Author: Pedro Amorim Date: Wed Jan 15 13:54:52 2025 +0000 Bug 38441: (QA follow-up): Fix find-missing-filters.t prove xt/find-missing-filters.t Signed-off-by: Lisette Scheer Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer commit fcf9c6597732d23c08c76cf4e1ddfc4269db1dd9 Author: Pedro Amorim Date: Wed Jan 15 13:15:40 2025 +0000 Bug 38441: (QA follow-up): Fix find-misplaced-executables.t It appears the atomic update had wrong permissions: prove xt/find-misplaced-executables.t Signed-off-by: Lisette Scheer Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer commit 8a51e156160bd99b5e2e9f411bd44a0412a972ec Author: Pedro Amorim Date: Wed Jan 15 11:33:38 2025 +0000 Bug 38441: (QA follow-up): Handle undef userenv C4::Context->userenv may be undef (after a reset_all, trying to place an unauthenticated request without being logged). This change prevents a nasty 500 error trying use undefined as hash Signed-off-by: Lisette Scheer Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer commit d0348b5319891e20985bf58e81e453b091e93566 Author: Pedro Amorim Date: Thu Nov 14 13:55:16 2024 +0000 Bug 38441: Add tests Test plan: 1) Apply patches 2) Run (ignore if using a sandbox): $ reset_all 3) Visit ILL system preferences: /cgi-bin/koha/admin/preferences.pl?tab=interlibrary_loans 4) Enable ILLModule and ILLHistoryCheck system preferences -- STAFF testing -- 5) Create a new ILL request, visit: /cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 6) Pick type = 'Journal article', enter '123' for DOI, '42' for cardnumber and any library. Click create. 7) Repeat 5) and 6). Notice you're now on the 'Request history check' screen. Verify your previous ILL request is listed. Click 'Submit anyway'. 8) Repeat 5) and 6). But pick a different patron cardnumber this time e.g. '23529000035676'. 9) Verify you're not shown the 'Request history check' screen as its a different patron. -- OPAC testing -- 10) Place a new request through the OPAC, visit: /cgi-bin/koha/opac-illrequests.pl?op=add_form&backend=Standard 11) Pick type = 'Journal article', enter '123' for DOI. Click 'Create'. Notice it shows the 'history check' screen listing the existing requests. Click 'Submit anyway'. 12) Return to the Staff UI: /cgi-bin/koha/ill/ill-requests.pl 13) Click on the latest ILL request. Verify 'History check requests' is displayed and contains information relating to the already existing ILL requests. -- Bonus testing -- 16) Play around with ILLModuleDisclaimerByType and ILLOpacUnauthenticatedRequest enabled at the same time as HistoryCheck (easy) 17) Play around with ILLCheckAvailability and AutoILLBackendPriority enabled at the same time as HistoryCheck (reach out for help using these preferences) Run tests: $ prove t/db_dependent/Koha/ILL/Request/Workflow/HistoryCheck.t Signed-off-by: Lisette Scheer Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer commit a63c3fd42f4f007c0c1004a33e83cbb6e3be2640 Author: Pedro Amorim Date: Fri Nov 15 11:19:00 2024 -0100 Bug 38441: Style updates for staffnotes - Use pre for staffnotes in staff illview - Ensure 
 has same font-family as rest of the page
    - Render html for staff notes in list. Truncate to 100 chars max
    
    Signed-off-by: Lisette Scheer 
    Signed-off-by: Tomas Cohen Arazi 
    Signed-off-by: Katrin Fischer 

commit ec9d72079c4a10d4c11cd1403132e1723b7af326
Author: Pedro Amorim 
Date:   Thu Nov 14 16:51:30 2024 +0000

    Bug 38441: Allow / render HTML in ILL staff notes
    
    Signed-off-by: Lisette Scheer 
    Signed-off-by: Tomas Cohen Arazi 
    Signed-off-by: Katrin Fischer 

commit f9a97918bc81c608dcfd01642f078addd3bc8500
Author: Pedro Amorim 
Date:   Thu Nov 14 10:27:27 2024 -0100

    Bug 38441: ILLHistoryCheck: OPAC
    
    Signed-off-by: Lisette Scheer 
    Signed-off-by: Tomas Cohen Arazi 
    Signed-off-by: Katrin Fischer 

commit cb4ecb4e77c5cb3c2594e8eed45b5469bc0442d5
Author: Pedro Amorim 
Date:   Thu Nov 14 09:54:20 2024 -0100

    Bug 38441: ILLHistoryCheck: Staff UI
    
    Signed-off-by: Lisette Scheer 
    Signed-off-by: Tomas Cohen Arazi 
    Signed-off-by: Katrin Fischer 

commit e9ca22088407cf37c149c8f0d2a3e799dd439307
Author: Pedro Amorim 
Date:   Thu Nov 14 09:53:58 2024 -0100

    Bug 38441: HistoryCheck Koha class
    
    Signed-off-by: Lisette Scheer 
    Signed-off-by: Tomas Cohen Arazi 
    Signed-off-by: Katrin Fischer 

commit 09f5af791b994c27b4537770a466438242e9f639
Author: Pedro Amorim 
Date:   Thu Nov 14 09:52:28 2024 -0100

    Bug 38441: atomicupdate
    
    Signed-off-by: Lisette Scheer 
    Signed-off-by: Tomas Cohen Arazi 
    Signed-off-by: Katrin Fischer 

commit 35e3cb5476332fda702756fba161d3ca44136f38
Author: Pedro Amorim 
Date:   Thu Nov 14 09:53:32 2024 -0100

    Bug 38441: New 'ILLHistoryCheck' system preference
    
    Signed-off-by: Lisette Scheer 
    Signed-off-by: Tomas Cohen Arazi 
    Signed-off-by: Katrin Fischer 

commit 6811106bda39622e8851034c4188da8640ed246c
Author: Katrin Fischer 
Date:   Mon Apr 28 16:42:21 2025 +0000

    Bug 39325: DBIC schema update
    
    Signed-off-by: Katrin Fischer 

commit f12bfe8f2b297357e4b4c9badf22e8695ae384b9
Author: Katrin Fischer 
Date:   Mon Apr 28 16:34:38 2025 +0000

    Bug 39325: DBRev 24.12.00.035
    
    Signed-off-by: Katrin Fischer 

commit a0fdb5630722c7086cda139ac55caf2d4a14c21a
Author: Katrin Fischer 
Date:   Mon Apr 28 16:29:03 2025 +0000

    Bug 39325: (QA follow-up) Fix file permissions for codespell.t
    
    Signed-off-by: Katrin Fischer 

commit b805f5ff995d8cb723c4b05f10cd9365aad2eb99
Author: Nick Clemens 
Date:   Tue Apr 1 11:28:45 2025 +0000

    Bug 39325: (QA follow-up) Adjust some issues
    
    connexion is a product, added to ignore file
    
    tablee -> tables
    
    a few other small corrections
    
    Signed-off-by: Nick Clemens 
    Signed-off-by: Katrin Fischer 

commit 5fd9743c8a28391ee5be981ae1417812e6ab2ce7
Author: Owen Leonard 
Date:   Thu Mar 20 11:44:53 2025 +0000

    Bug 39325: (follow-up) A few minor corrections
    
    Signed-off-by: Nick Clemens 
    Signed-off-by: Katrin Fischer 

commit 7436eb8ca57fa6037ed90fc108de843e84ed4345
Author: Jonathan Druart 
Date:   Thu Mar 20 11:13:26 2025 +0100

    Bug 39325: Exclude atomic update
    
    TODO: We will need to adjust this path with the db_rev one
    Signed-off-by: Owen Leonard 
    Signed-off-by: Nick Clemens 
    
    Adjusted path.
    
    Signed-off-by: Katrin Fischer 

commit 4f7d00eaed36bc6a420450578ab6881a146215d1
Author: Jonathan Druart 
Date:   Thu Mar 20 10:48:08 2025 +0100

    Bug 39325: Tidy
    
    Some files need to be tidy after the automatic commit
    
    Signed-off-by: Owen Leonard 
    Signed-off-by: Nick Clemens 
    Signed-off-by: Katrin Fischer 

commit 72a876a39e8df5bced74d10e89568a3630d2fcab
Author: Jonathan Druart 
Date:   Thu Mar 20 10:15:30 2025 +0100

    Bug 39325: Revert dbic schema files
    
    We need the md5sum to be adjusted. This should be done by the RM.
    
    Signed-off-by: Owen Leonard 
    Signed-off-by: Nick Clemens 
    Signed-off-by: Katrin Fischer 

commit a82f7d19cb4551b45448bb37acf72760f3a0162e
Author: Jonathan Druart 
Date:   Thu Mar 20 09:54:46 2025 +0100

    Bug 39325: Adjust DB
    
    We need to adjust kohastructure.sql, sysprefs.sql and the DB itself.
    
    Signed-off-by: Owen Leonard 
    Signed-off-by: Nick Clemens 
    Signed-off-by: Katrin Fischer 

commit 9d097917dc2784b3680144ba682ca1b8bd80cd34
Author: Jonathan Druart 
Date:   Thu Mar 20 09:19:50 2025 +0100

    Bug 39325: manual - suggestion - no one => no_one
    
    It has been changed (automatically) from "noone" to "no one", which was
    wrong.
    
    Signed-off-by: Owen Leonard 
    Signed-off-by: Nick Clemens 
    Signed-off-by: Katrin Fischer 

commit ca32afe46d9234bd32a99e63981831d49b604998
Author: Jonathan Druart 
Date:   Wed Mar 19 20:59:57 2025 +0100

    Bug 39325: manual - hilighted => highlighted
    
    All the other occurrences have been updated.
    
    Signed-off-by: Owen Leonard 
    Signed-off-by: Nick Clemens 
    Signed-off-by: Katrin Fischer 

commit 786c637ab036717c10aa6ec7005f88a6f7b49bca
Author: Jonathan Druart 
Date:   Wed Mar 19 20:57:22 2025 +0100

    Bug 39325: manual - reserv => reserve
    
    because of automatic changes in circ/transferstoreceive.tt
    
    Signed-off-by: Owen Leonard 
    Signed-off-by: Nick Clemens 
    Signed-off-by: Katrin Fischer 

commit 69b8341a8ce333a9b6ed8630ab1e7af1ffa31b83
Author: Jonathan Druart 
Date:   Wed Mar 19 16:28:58 2025 +0100

    Bug 39325: Manual fixes
    
    Signed-off-by: Owen Leonard 
    Signed-off-by: Nick Clemens 
    Signed-off-by: Katrin Fischer 

commit 1d844a7d2fdf84586b7bcaf4fea8b9fbd7dad0b8
Author: Jonathan Druart 
Date:   Thu Mar 20 10:26:41 2025 +0100

    Bug 39325: Automatic fix
    
    Signed-off-by: Owen Leonard 
    Signed-off-by: Nick Clemens 
    Signed-off-by: Katrin Fischer 

commit ea832ff246da0d6120dd24c8bb3bba865acd88e5
Author: Jonathan Druart 
Date:   Thu Mar 13 15:49:11 2025 +0100

    Bug 39325: Add test
    
    We certainly want to improve this test and run it in parallel.
    
    Signed-off-by: Owen Leonard 
    Signed-off-by: Nick Clemens 
    Signed-off-by: Katrin Fischer 

commit 81869ff48d7f833e4a8012ece0183fefbe27ad72
Author: Jonathan Druart 
Date:   Thu Mar 13 15:47:57 2025 +0100

    Bug 39325: .codespell-ignore
    
    List of words to ignore
    
    Signed-off-by: Owen Leonard 
    Signed-off-by: Nick Clemens 
    Signed-off-by: Katrin Fischer 

commit 7fdd4316829aa72d8cbfd246f8d776049d055101
Author: Nick Clemens 
Date:   Wed May 15 16:27:27 2024 +0000

    Bug 36867: Update preference description
    
    This lists the new syntax for allowing all IPs in the preference
    
    Signed-off-by: Martin Renvoize 
    Signed-off-by: Katrin Fischer 

commit b6763d622e6bd23e8c2580d8d60384c69795c96a
Author: Nick Clemens 
Date:   Wed May 15 16:10:05 2024 +0000

    Bug 36867: Do not allow access to ILS-DI for IPs not explicitly listed in ILS-DI:AuthorizedIPs
    
    This patch forces a check of authorized IPs against the Koha system preference, if nothing is present, no access is allowed
    
    To test:
     1 - Enable ILS-DI, leave  ILS-DI:AuthorizedIPs blank
     2 - In another window:
        http://localhost:8080/cgi-bin/koha/ilsdi.pl?service=GetAvailability&id=1+2+99999&id_type=item
     3 - You get a response
     4 - Apply patch and restart all
     5 - Reload ilsdi page, 'Not authorized'
     6 - Copy the IP listed as refused and paste into ILS-DI:AuthorizedIPs
     7 - Reload the page, you get a response again
     8 - Change ILS-DI:AuthorizedIPs to:
        0:0:0:0/0
     9 - You still have access
    10 - Paste your specific IP again, and add a second made up IP (comma separated)
    11 - Reload and confirm you still have access
    
    Signed-off-by: Martin Renvoize 
    Signed-off-by: Katrin Fischer 

commit 2b288d4274d4b4c7af349d4bbc3f3c10ec75e697
Author: David Cook 
Date:   Tue Mar 25 22:50:39 2025 +0000

    Bug 38969: (QA follow-up) fix tidy
    
    Signed-off-by: Katrin Fischer 

commit 77a53e2c6f5afea1399aa15eaf7f4075f3c69e39
Author: Jonathan Druart 
Date:   Mon Jan 27 09:56:30 2025 +0100

    Bug 38969: Prevent JS error when adding tags with quote at the OPAC
    
    Uncaught SyntaxError: missing ) after argument list
    
    There are way more to fix in this controller...
    
    Signed-off-by: Baptiste Wojtkowski 
    Signed-off-by: David Cook 
    Signed-off-by: Katrin Fischer 

commit ba58e5f0d43f80a513ed893cf3abdd0c8002a12c
Author: Jonathan Druart 
Date:   Mon Jan 27 09:56:10 2025 +0100

    Bug 38969: Prevent XSS in tags/review.pl
    
    Signed-off-by: Baptiste Wojtkowski 
    Signed-off-by: David Cook 
    Signed-off-by: Katrin Fischer 

commit b16582b963c78a4361c14887e4fbecfcc632382a
Author: Nick Clemens 
Date:   Fri Apr 25 16:21:43 2025 +0000

    Bug 39750: Ignore limits when updating WrongTransfer
    
    This patch ignores limits when updating a wrong transfer to ensure we can return a book
    home when checked in at the wrong branch
    
    To test:
    1 - Enable  UseBranchTransferLimits based on 'Collection code'
    2 - Disable transfers for FIC from:
        CPL -> FFL
        CPL -> IPT
        FFL -> CPL
        FFL -> IPT
        IPT -> CPL
        IPT -> FFL
    3 - Set library to IPT
    4 - Checkin an FFL item
    5 - It generates a transfer home
    6 - Set library to CPL
    7 - Check the item in
    8 - 500 error, and in logs:
        ==> /var/log/koha/kohadev/plack-error.log <==
    Exception 'Koha::Exceptions::Item::Transfer::Limit' thrown 'Transfer not allowed'
    9 - Apply patch, restart all
    10 - Check item in again
    11 - Success! Transfer updated
    
    Signed-off-by: Roman Dolny 
    Signed-off-by: Martin Renvoize 
    Signed-off-by: Katrin Fischer