commit 4700993ef3daba71cf6523abbda9a135fa2b13e4 Author: Owen Leonard Date: Fri Jun 13 15:02:35 2025 +0000 Bug 37773: Show search term in cataloging search results This patch updates the cataloging search results page so that the search term is shown in the page title, breadcrumb, and headings. To test, apply the patch and go to Cataloging in the staff interface. - Perform searches which will return varying results: - A search which returns records in both the catalog and the reservoir (perform some Z39.50 searches if the reservoir is empty). - A search which returns records in the catalog but not the reservoir. - A search which returns records in the reservoir but not the catalog. - A search which returns no results at all. - In all cases, check the page title, breadcrumbs, and headings. Your search term should appear as expected. - Test that the correct strings are translatable. In this example I'm testing fr-FR: - Update a translation: > gulp po:update > cd misc/translator > perl translate update fr-FR - Open the corresponding .po file for the strings pulled from the template e.g. misc/translator/po/fr-FR-messages.po - Locate strings pulled from addbooks.tt for translation, e.g.: #: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt:93 #: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbooks.tt:207 #, fuzzy, perl-brace-format msgid "No catalog search results for '{query}'" msgstr "Résultats de recherche pour '{query}'" - Delete the line starting with "#, fuzzy" - Edit the "msgstr" string however you want (it's just for testing) - Install the updated translation: > perl translate install fr-FR - Switch to your updated translation in the staff interface and perform the same tests as above. The translations should appear as expected. Sponsored-by: Athens County Public Libraries commit 1886165eaea54347d91a332bdc6a5ec9f4fb6325 Author: Tomás Cohen Arazi Date: Mon Jun 2 18:09:10 2025 -0300 Bug 40055: Make MoveReserve be passed objects instead of ids The `MoveReserve` method is called once, in `AddIssue`. The latter has the related `Koha::Item` object already fetched from the DB, but it passed the `itemnumber` which is used by `MoveReserve` to fetch the item from the DB. This should not happen. To test: 1. Run: $ ktd --shell k$ prove t/db_dependent/Reserves* \ t/db_dependent/Koha/Hold* \ t/db_dependent/Hold* \ t/db_dependent/Circulation* => SUCCESS: Tests pass 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests still pass! 4. Sign off :-D Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Lucas Gass commit 235ecfca70f2186d2a36afaad0cc0e91e4ca2d8e Author: Tomás Cohen Arazi Date: Tue May 20 15:19:51 2025 -0300 Bug 39948: Simplify unauthenticated ILL submission detail page for the OPAC This patch tweaks the unauthenticated ILL request details page so it doesn't display 'Unauthenticated ...' more than really needed. To test: 1. Enable ILLModule 2. Enable ILLOpacUnauthenticatedRequest 3. Set ILLOpacbackends to 'Standard' 4. Make a search in the OPAC (not logged in) 5. At the bottom of the page, follow the 'Make an interlibrary loan request' link. 6. Place a request, you are redirected to the request details page => FAIL: There are some strings that could go away: * Unauthenticated first name * Unauthenticated last name * Unauthenticated email 7. Apply this patch 8. Reload the page => SUCCESS: It looks more polished, with no 'Unauthenticated' all over the place. You still see 'Status: Unauthenticated' anyway 9. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Nind Signed-off-by: Pedro Amorim Signed-off-by: Lucas Gass commit d4450cdd5f1955a0a67c1a18c40d44db4667cab3 Author: Emily Lamancusa Date: Fri May 23 11:15:43 2025 -0400 Bug 36020: (QA follow-up) A few minor corrections Remove unneeded
in RECALL_REQUESTER_DET Add IFs to RECALL_REQUESTER_DET to avoid displaying empty lines if there is no phone, email, and/or callnumber to display Use checkout.date_due instead of item.onloan due to bug 39985 Signed-off-by: Emily Lamancusa Signed-off-by: Lucas Gass commit 98c0cf26488cef6f1aab1bd907c7c0293646b976 Author: Lisette Scheer Date: Wed May 21 21:26:38 2025 +0000 Bug 36020: Port default recall notices to Template Toolkit The following notices relating to recalls all need to be updated to use Template Toolkit syntax: RETURN_RECALLED_ITEM PICKUP_RECALLED_ITEM RECALL_REQUESTER_DET To test: 1) Observe the default notice contains <<>> tags 2) Apply the patch 3) reset_all 4) Check that the notice is now all in template toolkit [% %] tags with html selected 5) Enable recalls 6) Enable SMS 7) Check an item out to a patron 8) Make sure the patron has a primary email, sms, and recall notices enabled 9) Make sure a secondary patron has a primary email, sms, and recall notices enabled 10) Generate a recall on the checked out item for the second patron 11) Check the first patron's notices tab to confirm the return recalled item notice generated properly. 12) Check the item back in and generate the recall slip and confirm it generated correctly. 13) Check the second patron's notices tab to confirm the pickup recalled item notice generated properly. Signed-off-by: Aleisha Amohia Signed-off-by: Emily Lamancusa Signed-off-by: Lucas Gass commit 10dd01174a42ee1ebb720ac223240c97aaa09108 Author: Owen Leonard Date: Thu Jun 5 16:10:33 2025 +0000 Bug 39434: (follow-up) Fix a few more instance Signed-off-by: Owen Leonard Signed-off-by: Lucas Gass commit 28bbadcd49405b7aada89cd08add8f8a84dd08f7 Author: Nina Martinez Date: Thu Mar 27 17:07:43 2025 +0100 Bug 39434: Change the div tags that represent the header and main regions to semantic tags. This patch updates the OPAC page structures to add
and
tags to them. Test plan : 1- On the opac of koha, check if the pages contain the basic semantic elements (header, nav, main, and footer ) 2- If they do, the test succeeds. Signed-off-by: Claire Hernandez Signed-off-by: Owen Leonard Signed-off-by: Lucas Gass commit a35af961f883b51f5cf4eb920ff2e496c93b7b7d Author: Owen Leonard Date: Mon May 19 15:31:03 2025 +0000 Bug 39925: Table columns missing headings for bibliographic search history in OPAC This patch updates the OPAC search history page to make table headings consistent with each other. To test, apply the patch and log in to the OPAC, ideally as a user who has performed catalog searches on previous occasions. - On the patron's search history page, each table should have the same heading configuration: An unsorted first column with an information icon at the top. The icon should display a tooltip on mouse-over. - Check the Catalog current session, catalog previous sessions, Authority current session, and authority previous sessions. Sponsored-by: Athens County Public Libraries Signed-off-by: Roman Dolny Signed-off-by: Laura_Escamilla Signed-off-by: Lucas Gass commit 45c70202200e5440264824bc1c8b93b46d69a72b Author: Laura Escamilla Date: Tue Apr 22 16:27:50 2025 +0000 Bug 33440: Tests Test Plan 1. Staff member A creates a public list. 2. Staff member A transfers this public list to another staff member (staff member b) without list permissions. 3. Staff Member B now has the ability to edit this public list and add/remove items from this list. 4. Apply the patch 5. Repeat steps 1 and 2. An error message should now appear stating that the “Transfer not allowed: You or the selected user do not have the required permissions.” 6. Provide the correct permissions to Staff Member B. Initiate the transfer again. The transfer should be successful. 7. Test these steps in the OPAC as well. 8. Prove t/db_dependent/Virtualshelves.t 9. Sign off and have a wonderful day! :D Signed-off-by: Roman Dolny Signed-off-by: Baptiste Wojtkowski Signed-off-by: Lucas Gass commit 7a98edf4273fc4bdf66d66bb5b62ef14423a1c6d Author: Laura Escamilla Date: Tue Apr 22 15:58:41 2025 +0000 Bug 33440: Updated wording for unauthorized_transfer OPAC message Signed-off-by: Roman Dolny Signed-off-by: Baptiste Wojtkowski Signed-off-by: Lucas Gass commit e7b790e3a6c9c870473d068397efedd34c8780d0 Author: Laura Escamilla Date: Tue Apr 22 15:57:59 2025 +0000 Bug 33440: Updated wording for unauthorized_transfer error message Signed-off-by: Roman Dolny Signed-off-by: Baptiste Wojtkowski Signed-off-by: Lucas Gass commit 0edf68987014e535241421c106d7d326789cf771 Author: Laura Escamilla Date: Tue Apr 22 15:57:22 2025 +0000 Bug 33440: Added permission requirements to unauthorized_transfer Signed-off-by: Roman Dolny Signed-off-by: Baptiste Wojtkowski Signed-off-by: Lucas Gass commit 01526ef545b28a79555756e9ae9b02f8a63cd525 Author: Marcel de Rooy Date: Thu Jun 12 11:15:09 2025 +0200 Bug 40119: (QA follow-up) Small additional comment The reference to this bug report may be helpful to understand later why we did so. Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass commit 5eeb04be97190dec4e1f84067248d70f37ff21e8 Author: Janusz Kaczmarek Date: Wed Jun 11 14:18:59 2025 +0000 Bug 40119: Unit tests Signed-off-by: Roman Dolny Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass commit bd43ebdc5e216388f2eb2abe39beb8b33cfa515b Author: Janusz Kaczmarek Date: Wed Jun 11 14:14:25 2025 +0000 Bug 40119: Merge should not leave empty 6XX subfield $2 (MARC 21) Currently, when removing 040 $f from authority record with 008/11 = 'z' (MARC 21), merge function removes the content of $2 subfield in linked 6XX fields, leaving the 6XX $2 subfield empty. This is not correct. We should not have empty subfields in a MARC record. Instead, the old content of the $2 subfield should be retained (if auth 008/11 is still = 'z'). Test plan: ========== 1. Have an authority record with 008/11 = 'z' and 040 $f = 'whatever'. 2. Link the record to a bibliographic 6XX. 3. Edit the authority record, removing 040 $f. 4. Go to bibliographic record and in modal "MARC preview" from Normal view notice that 6XX $2 exists but is empty. This is wrong. 5. Apply the patch ; restart all. 6. Repeat p. 1.-4. Note that the content of 6XX $2 has not been removed. Sponsored-by: Ignatianum University in Cracow Signed-off-by: Roman Dolny Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass commit 9a4fd4facb81f75aa47e5412e9e1bf5269a24672 Author: Tomás Cohen Arazi Date: Fri Jun 13 15:21:12 2025 -0300 Bug 39911: Remove redundant warn Following the original test plan you notice, `THIS IS A TEST` is printed twice: * In the logs. * In STDERR for the SIP server. The latter is redundant, and also problematic for `xt/author/pod_coverage.t` which fails the `no warnings` tests because of that. To test: 1. Run: $ ktd --shell k$ prove xt/author/pod_coverage.t => FAIL: Scary errors, lots of them 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests pass! 4. Follow the original bug test plan => SUCCESS: There's `THIS IS A TEST` in the logs, which was the author's goal in the first place. 5. Sign off :-D 6. Visit bug 40144 :-P Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lucas Gass commit 702d1d2792c00431f657cd5b4cff409997375d7c Author: Kyle M Hall Date: Thu Jun 12 08:43:03 2025 -0400 Bug 39911: Add POD Signed-off-by: Lucas Gass commit b0ee8a675cd6a6deb8138e0a52612396fbcbbb36 Author: Jonathan Druart Date: Mon May 12 09:45:14 2025 +0200 Bug 38899: Fix cypress tests Signed-off-by: Jonathan Druart Signed-off-by: Lucas Gass commit 87a522e46358ce1bd2adda772dad132d73d96e22 Author: Matt Blenkinsop Date: Mon May 19 11:10:11 2025 +0100 Bug 38899: Restore id attribute to the form Signed-off-by: Jonathan Druart Signed-off-by: Lucas Gass commit b44c08eb4fcc44ad55c3b33264936b7a4d8d69a5 Author: Jonathan Druart Date: Wed May 14 16:04:30 2025 +0200 Bug 38899: Remove code duplication Signed-off-by: Jonathan Druart Signed-off-by: Lucas Gass commit 56eb4a685086af0de506a4958b41f9b3492bf0de Author: Matt Blenkinsop Date: Mon May 12 11:43:06 2025 +0100 Bug 38899: Improve HTML consistency Signed-off-by: Jonathan Druart Signed-off-by: Lucas Gass commit f24e0d52e23ba860140198b11c06ad486849a153 Author: Jonathan Druart Date: Mon May 12 09:57:46 2025 +0200 Bug 38899: Move the toolbar out of the form Signed-off-by: Jonathan Druart Signed-off-by: Lucas Gass commit 4fc93fee00f19a7193fe8c47845ba1dadc06f4b1 Author: Matt Blenkinsop Date: Tue May 6 11:34:38 2025 +0100 Bug 38899: (QA follow-up) Match buttons to patron toolbar Signed-off-by: Jonathan Druart Signed-off-by: Lucas Gass commit 57bd44ae0fe2b71bd1ae93519d1229fa6b09fda0 Author: Matt Blenkinsop Date: Wed Jan 15 10:42:19 2025 +0000 Bug 38899: Add a cypress test Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Lucas Gass commit 716980ce2f1e397ce226b07acd4c51a6e03e3a4c Author: Matt Blenkinsop Date: Wed Jan 15 10:40:07 2025 +0000 Bug 38899: Add a sticky toolbar This patch adds a sticky toolbar to the vendors form Test plan: N.B: This patchset will not work on a sandbox 1) Navigate to Acquisitions and click New vendor 2) The toolbar should appear at the top of the page underneath Add vendor 3) Scroll down, the toolbar should stick and be given the 'floating' class 4) Scroll back up and the toolbar should unstick and lose the 'floating' class Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Lucas Gass commit 9cdf597a8313231332adee65312d0d1f6d011c9f Author: Laura Escamilla Date: Fri Jun 6 20:10:09 2025 +0000 Bug 40080: QA Follow-up - Code tidy-up based on QA tool feedback Signed-off-by: Lucas Gass commit 32242f438ab57459ff19b3a92b322a12b75cd4cf Author: Martin Renvoize Date: Thu Jun 5 10:54:14 2025 +0100 Bug 40080: Fix search position on course reserves page This patch corrects the position of the table search box on the course reserves details pages by warpping the presented table in a 'rows' class div. We also update the search box dom configuration in the datatable itself to match that of other opac tables. Test plan 1) Add some course reserves to a course 2) View that course on the OPAC 3) Note that the search box for the table is aligned to the top of the main section of the page and over to the far right almost off screen. 4) Apply this patch 5) Confirm that the display of the search box is now nested just above the table in the same location as the course reserves list page Signed-off-by: David Nind Signed-off-by: Lucas Gass commit f214db14dd5191dc53eb7bb89e7832b121761e96 Author: Kyle M Hall Date: Thu May 15 13:25:18 2025 -0400 Bug 39911: Trap DIE signals in SIP server At some point our SIP server stopped logging fatal errors to either logs or standard error. We should restore this vital functionality. Test Plan: 1) Apply the first patch which will cause the patron information request to fail 2) Stop the SIP server 3) Start it again with: perl /kohadevbox/koha/C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml 4) Trigger the failure with the following command: ./misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su koha -sp koha -l MPL --patron koha -m patron_information 5) Note "THIS IS A TEST" is not found in logs or stderr 6) Apply the second patch 7) Repeat steps 2-4 8) Note the error message is now visible from stderr at the command line and also in the SIP log Signed-off-by: Magnus Enger Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lucas Gass commit 1d10d8b8c9c6f4a0dddc174fa8fea53ffa6b5d2e Author: David Cook Date: Fri Jun 6 03:22:39 2025 +0000 Bug 40087: Fix t/Scrubber.t unit test Remove "tag" and "staff" and add the missing "note" Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass commit e846abeeb7eda58cba4b43520483279ecc1006c9 Author: David Cook Date: Fri Jun 6 01:24:25 2025 +0000 Bug 40087: Remove "tag" and "staff" scrubber profiles This patch removes unused "tag" and "staff" scrubber profiles. Test plan: 0. Apply the patch 1. prove t/Koha/Plugins/HtmlScrubber.t 2. prove t/Scrubber.t 3. Grep around the code for C4::Scrubber and make sure "tag" and "staff" aren't used as arguments for C4::Scrubber Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass commit dfd028871ae0e35c177d0598e4e398db5c5f3975 Author: Pedro Amorim Date: Fri Jun 6 09:44:23 2025 +0000 Bug 39875: (QA follow-up): Correct historycheck ui_context This ui_context is supposed to be opac, not staff. For the purposes of these tests, this is not important, as the ui_context is only needed for the template params and this is testing if the history check stage is supposed to show or not. Reckon this was a copy paste without consequences hence missed, but the code is now semantically more correct. prove t/db_dependent/Koha/ILL/Request/Workflow/HistoryCheck.t Signed-off-by: Lucas Gass commit 6a0fcefa22a86d0177f87bbf9f3bf80efdc5d373 Author: Pedro Amorim Date: Mon May 12 13:30:12 2025 +0000 Bug 39875: Dont show history check Unless there is a cardnumber or an authenticated user Test plan: 1) Apply only the the tests file highlighting the issue: prove t/db_dependent/Koha/ILL/Request/Workflow/HistoryCheck.t 2) Notice it fails. 3) Apply this patch. 4) Run tests again. Notice it passes. Signed-off-by: David Nind Signed-off-by: Lin Wei Li Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass commit ae2e9e23de0d68874563b55ea3a7a816d8b5fb41 Author: Pedro Amorim Date: Mon May 12 13:29:23 2025 +0000 Bug 39875: Add tests Signed-off-by: David Nind Signed-off-by: Lin Wei Li Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass commit 28cf1da6ea0c8b7e6066c8a8628e30d5ddbc5074 Author: Owen Leonard Date: Fri May 16 12:21:10 2025 +0000 Bug 39919: Overdues with fines report has incorrect title, breadcrumbs, etc. This patch corrects the "Overdues with fines" page so that the page title, breadcrumbs, and main heading match the name used in navigation menus. To test, apply the patch and go to Circulation -> Overdues with fines. Confirm that the page title, breadcrumb menu, and page heading are correct: "Overdues with fines at [library]" Sponsored-by: Athens County Public Libraries Signed-off-by: Lin Wei Li Signed-off-by: Baptiste Wojtkowski Signed-off-by: Lucas Gass commit d2ffae92a7d13eea9698a353bbb5c0508719600a Author: Tomás Cohen Arazi Date: Wed May 21 16:48:01 2025 -0300 Bug 39961: (follow-up) Make `koha-disable` stop all queues This patch applies the same logic to `koha-disable`. Signed-off-by: Magnus Enger Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass commit 45089704fa86c3038e54f5b9aeee73553e374eae Author: Tomás Cohen Arazi Date: Wed May 21 16:40:40 2025 -0300 Bug 39961: Make `koha-create` start all queues Taking advantage of the `get_worker_queues` function introduced in bug 31124, this patch makes `koha-create` start all defined queues. To test: 1. Run: $ ktd --shell k$ sudo -s k$ koha-create --create-db test => FAIL: No mention of `long_tasks` 2. Apply 31124 and then this patch 3. Run: k$ cp debian/scripts/koha-functions.sh \ /usr/share/koha/bin/koha-functions.sh k$ debian/scripts/koha-create --create-db test1 => SUCCESS: `long_tasks` worker is started 4. Sign off :-D Signed-off-by: Magnus Enger Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass commit 576c49644219ad391fd28c65f798ebab1d1dfb7c Author: Tomás Cohen Arazi Date: Wed May 21 16:26:31 2025 -0300 Bug 31124: Make koha-remove stop all workers This patch makes two things: * Adds a `get_worker_queues` function to koha-functions.sh * Makes `koha-remove` loop through all the defined queues to stop all the running workers before trying to remove the unix user for the instance. To test: 1. Run: $ ktd --shell k$ sudo -s k$ koha-create --create-db test1 k$ service koha-common restart k$ koha-remove test1 => FAIL: There's an error about not being able to drop the instance user 2. Run: k$ ps -ef | grep test1 => FAIL: There's a running process for the 'long_tasks' queue worker. 3. Apply this patch 4. Run: k$ cp debian/scripts/koha-functions.sh \ /usr/share/koha/bin/koha-functions.sh 5. Repeat 1 naming the instance `test2` => SUCCESS: The instance is removed correctly. No error about running processes => SUCCESS: No process is running for `test2` 6. Sign off :-D Signed-off-by: Magnus Enger Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass commit 04ebdd4ac140b5cd4a0333340bd1422edf7d92e4 Author: Andreas Jonsson Date: Thu May 22 11:00:35 2025 +0200 Bug 38974: Fix error in OPAC patron update Test plan: 1) Make sure Patron category is checked in the system preference PatronSelfModificationBorrowerUnwantedField 2) Log in to the opac 3) Go to "Personal details" 4) Select any value for "Date of birth" 5) Click save 6) This must not yield error 500. (But may be a successful save or a validation error). Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass commit c4f7b1490604c7c46ca4e9b3385aab2e9cf39433 Author: Jonathan Druart Date: Tue May 27 10:40:15 2025 +0200 Bug 40003: Add a test Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass commit 0ba11f98f99dee947c087cdd9b92838b772a7918 Author: Jonathan Druart Date: Tue May 27 10:40:33 2025 +0200 Bug 40003: Remove warning from log when creating a new bib record Test plan: Hit cataloguing/addbiblio.pl?frameworkcode=FA Without this patch you get warnings in the Koha log file: Use of uninitialized value in string eq at /kohadevbox/koha/cataloguing/addbiblio.pl line 572. Use of uninitialized value in substitution (s///) at /kohadevbox/koha/Koha/UI/Form/Builder/Biblio.pm line 55. with this patch applied: no warning Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass commit db655799ad97a33c89246010734cb187188407ae Author: Jonathan Druart Date: Wed May 28 16:57:55 2025 +0200 Bug 40021: Remove warnings from Koha/Plugins/Recall_hooks.t Test plan: prove t/db_dependent/Koha/Plugins/Recall_hooks.t should return green Signed-off-by: Roman Dolny Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass commit eaaabf66dd935ff52f5c6fece8294ccf3c858b45 Author: Jonathan Druart Date: Wed May 28 16:37:45 2025 +0200 Bug 40018: Remove warnings from Koha/Template/Plugin/Koha.t Because we still use CGI::Session (bug 17427), we need to mock CGI::Session to remove those 2 warnings rollback ineffective with AutoCommit enabled Test plan: Run the tests after this patch, it should be green Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass commit 35baa3ec465306a7e6d6a9ccebe13acedf0b507f Author: Lucas Gass Date: Fri May 30 14:28:23 2025 +0000 Bug 40036: Add reason back to status column and add classes/data attributes To test: 0. APPLY PATCH 1. Make a few AVs for SUGGEST ( reason ) and SUGGEST_STATUS ( status ). 2. Make some new suggestions and give them new statues w/ a reason. 3. The reason should display, in parentheses, in the status column. 4. There should be a status class and a reason class for each. Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass commit c695e6ce4c43113d86413cf0676ce18e2dd8cfcd Author: Jonathan Druart Date: Wed May 28 16:48:15 2025 +0200 Bug 40019: Remove warnings from Koha/Auth/Client.t Test plan: prove t/db_dependent/Koha/Auth/Client.t should return green Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass commit 827ad2124410df96a45290b1c7778f247889df9b Author: Jonathan Druart Date: Wed May 28 16:51:37 2025 +0200 Bug 40020: Remove warnings from Koha/AdditionalContents.t Test plan: prove t/db_dependent/Koha/AdditionalContents.t should return green Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass commit 854783c8362a93e55fa379712ae6e04b24cf552c Author: Tomás Cohen Arazi Date: Mon Jun 2 09:50:19 2025 -0300 Bug 40034: Only check notforloan on itemtype if it exists This patch makes the code in `CheckReserves` survive the non-existence of the referenced item type in the `items` table for the passed item. To test: 1. Apply the regression tests 2. Run: $ ktd --shell k$ prove t/db_dependent/Reserves.t => FAIL: Tests explode like this: ``` Can't call method "notforloan" on an undefined value at /kohadevbox/koha/C4/Reserves.pm line 870. ``` 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass commit 6c26ce01d39b434d05f3bdd13fc584a4c7ac1c77 Author: Tomás Cohen Arazi Date: Mon Jun 2 09:46:30 2025 -0300 Bug 40034: Regression tests Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass commit 0d39336f7111f91560ce23c727c362ddeca0d251 Author: Fridolin Somers Date: Mon Jun 2 10:00:32 2025 +0200 Bug 40042: Add default value 0 for index var in search_indexes.inc In koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc some calls do not set 'index' var generating idx="idx_". Set 0 has default value. Test plan : 1) Enable system preference 'IntranetCatalogSearchPulldown' 2) Go to catalogue advanced search 3) Look HTML source and check you see: Without patch you see: