commit b0ee8a675cd6a6deb8138e0a52612396fbcbbb36 Author: Jonathan Druart Date: Mon May 12 09:45:14 2025 +0200 Bug 38899: Fix cypress tests Signed-off-by: Jonathan Druart Signed-off-by: Lucas Gass commit 87a522e46358ce1bd2adda772dad132d73d96e22 Author: Matt Blenkinsop Date: Mon May 19 11:10:11 2025 +0100 Bug 38899: Restore id attribute to the form Signed-off-by: Jonathan Druart Signed-off-by: Lucas Gass commit b44c08eb4fcc44ad55c3b33264936b7a4d8d69a5 Author: Jonathan Druart Date: Wed May 14 16:04:30 2025 +0200 Bug 38899: Remove code duplication Signed-off-by: Jonathan Druart Signed-off-by: Lucas Gass commit 56eb4a685086af0de506a4958b41f9b3492bf0de Author: Matt Blenkinsop Date: Mon May 12 11:43:06 2025 +0100 Bug 38899: Improve HTML consistency Signed-off-by: Jonathan Druart Signed-off-by: Lucas Gass commit f24e0d52e23ba860140198b11c06ad486849a153 Author: Jonathan Druart Date: Mon May 12 09:57:46 2025 +0200 Bug 38899: Move the toolbar out of the form Signed-off-by: Jonathan Druart Signed-off-by: Lucas Gass commit 4fc93fee00f19a7193fe8c47845ba1dadc06f4b1 Author: Matt Blenkinsop Date: Tue May 6 11:34:38 2025 +0100 Bug 38899: (QA follow-up) Match buttons to patron toolbar Signed-off-by: Jonathan Druart Signed-off-by: Lucas Gass commit 57bd44ae0fe2b71bd1ae93519d1229fa6b09fda0 Author: Matt Blenkinsop Date: Wed Jan 15 10:42:19 2025 +0000 Bug 38899: Add a cypress test Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Lucas Gass commit 716980ce2f1e397ce226b07acd4c51a6e03e3a4c Author: Matt Blenkinsop Date: Wed Jan 15 10:40:07 2025 +0000 Bug 38899: Add a sticky toolbar This patch adds a sticky toolbar to the vendors form Test plan: N.B: This patchset will not work on a sandbox 1) Navigate to Acquisitions and click New vendor 2) The toolbar should appear at the top of the page underneath Add vendor 3) Scroll down, the toolbar should stick and be given the 'floating' class 4) Scroll back up and the toolbar should unstick and lose the 'floating' class Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Lucas Gass commit 9cdf597a8313231332adee65312d0d1f6d011c9f Author: Laura Escamilla Date: Fri Jun 6 20:10:09 2025 +0000 Bug 40080: QA Follow-up - Code tidy-up based on QA tool feedback Signed-off-by: Lucas Gass commit 32242f438ab57459ff19b3a92b322a12b75cd4cf Author: Martin Renvoize Date: Thu Jun 5 10:54:14 2025 +0100 Bug 40080: Fix search position on course reserves page This patch corrects the position of the table search box on the course reserves details pages by warpping the presented table in a 'rows' class div. We also update the search box dom configuration in the datatable itself to match that of other opac tables. Test plan 1) Add some course reserves to a course 2) View that course on the OPAC 3) Note that the search box for the table is aligned to the top of the main section of the page and over to the far right almost off screen. 4) Apply this patch 5) Confirm that the display of the search box is now nested just above the table in the same location as the course reserves list page Signed-off-by: David Nind Signed-off-by: Lucas Gass commit f214db14dd5191dc53eb7bb89e7832b121761e96 Author: Kyle M Hall Date: Thu May 15 13:25:18 2025 -0400 Bug 39911: Trap DIE signals in SIP server At some point our SIP server stopped logging fatal errors to either logs or standard error. We should restore this vital functionality. Test Plan: 1) Apply the first patch which will cause the patron information request to fail 2) Stop the SIP server 3) Start it again with: perl /kohadevbox/koha/C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml 4) Trigger the failure with the following command: ./misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su koha -sp koha -l MPL --patron koha -m patron_information 5) Note "THIS IS A TEST" is not found in logs or stderr 6) Apply the second patch 7) Repeat steps 2-4 8) Note the error message is now visible from stderr at the command line and also in the SIP log Signed-off-by: Magnus Enger Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lucas Gass commit 1d10d8b8c9c6f4a0dddc174fa8fea53ffa6b5d2e Author: David Cook Date: Fri Jun 6 03:22:39 2025 +0000 Bug 40087: Fix t/Scrubber.t unit test Remove "tag" and "staff" and add the missing "note" Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass commit e846abeeb7eda58cba4b43520483279ecc1006c9 Author: David Cook Date: Fri Jun 6 01:24:25 2025 +0000 Bug 40087: Remove "tag" and "staff" scrubber profiles This patch removes unused "tag" and "staff" scrubber profiles. Test plan: 0. Apply the patch 1. prove t/Koha/Plugins/HtmlScrubber.t 2. prove t/Scrubber.t 3. Grep around the code for C4::Scrubber and make sure "tag" and "staff" aren't used as arguments for C4::Scrubber Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass commit dfd028871ae0e35c177d0598e4e398db5c5f3975 Author: Pedro Amorim Date: Fri Jun 6 09:44:23 2025 +0000 Bug 39875: (QA follow-up): Correct historycheck ui_context This ui_context is supposed to be opac, not staff. For the purposes of these tests, this is not important, as the ui_context is only needed for the template params and this is testing if the history check stage is supposed to show or not. Reckon this was a copy paste without consequences hence missed, but the code is now semantically more correct. prove t/db_dependent/Koha/ILL/Request/Workflow/HistoryCheck.t Signed-off-by: Lucas Gass commit 6a0fcefa22a86d0177f87bbf9f3bf80efdc5d373 Author: Pedro Amorim Date: Mon May 12 13:30:12 2025 +0000 Bug 39875: Dont show history check Unless there is a cardnumber or an authenticated user Test plan: 1) Apply only the the tests file highlighting the issue: prove t/db_dependent/Koha/ILL/Request/Workflow/HistoryCheck.t 2) Notice it fails. 3) Apply this patch. 4) Run tests again. Notice it passes. Signed-off-by: David Nind Signed-off-by: Lin Wei Li Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass commit ae2e9e23de0d68874563b55ea3a7a816d8b5fb41 Author: Pedro Amorim Date: Mon May 12 13:29:23 2025 +0000 Bug 39875: Add tests Signed-off-by: David Nind Signed-off-by: Lin Wei Li Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass commit 28cf1da6ea0c8b7e6066c8a8628e30d5ddbc5074 Author: Owen Leonard Date: Fri May 16 12:21:10 2025 +0000 Bug 39919: Overdues with fines report has incorrect title, breadcrumbs, etc. This patch corrects the "Overdues with fines" page so that the page title, breadcrumbs, and main heading match the name used in navigation menus. To test, apply the patch and go to Circulation -> Overdues with fines. Confirm that the page title, breadcrumb menu, and page heading are correct: "Overdues with fines at [library]" Sponsored-by: Athens County Public Libraries Signed-off-by: Lin Wei Li Signed-off-by: Baptiste Wojtkowski Signed-off-by: Lucas Gass commit d2ffae92a7d13eea9698a353bbb5c0508719600a Author: Tomás Cohen Arazi Date: Wed May 21 16:48:01 2025 -0300 Bug 39961: (follow-up) Make `koha-disable` stop all queues This patch applies the same logic to `koha-disable`. Signed-off-by: Magnus Enger Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass commit 45089704fa86c3038e54f5b9aeee73553e374eae Author: Tomás Cohen Arazi Date: Wed May 21 16:40:40 2025 -0300 Bug 39961: Make `koha-create` start all queues Taking advantage of the `get_worker_queues` function introduced in bug 31124, this patch makes `koha-create` start all defined queues. To test: 1. Run: $ ktd --shell k$ sudo -s k$ koha-create --create-db test => FAIL: No mention of `long_tasks` 2. Apply 31124 and then this patch 3. Run: k$ cp debian/scripts/koha-functions.sh \ /usr/share/koha/bin/koha-functions.sh k$ debian/scripts/koha-create --create-db test1 => SUCCESS: `long_tasks` worker is started 4. Sign off :-D Signed-off-by: Magnus Enger Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass commit 576c49644219ad391fd28c65f798ebab1d1dfb7c Author: Tomás Cohen Arazi Date: Wed May 21 16:26:31 2025 -0300 Bug 31124: Make koha-remove stop all workers This patch makes two things: * Adds a `get_worker_queues` function to koha-functions.sh * Makes `koha-remove` loop through all the defined queues to stop all the running workers before trying to remove the unix user for the instance. To test: 1. Run: $ ktd --shell k$ sudo -s k$ koha-create --create-db test1 k$ service koha-common restart k$ koha-remove test1 => FAIL: There's an error about not being able to drop the instance user 2. Run: k$ ps -ef | grep test1 => FAIL: There's a running process for the 'long_tasks' queue worker. 3. Apply this patch 4. Run: k$ cp debian/scripts/koha-functions.sh \ /usr/share/koha/bin/koha-functions.sh 5. Repeat 1 naming the instance `test2` => SUCCESS: The instance is removed correctly. No error about running processes => SUCCESS: No process is running for `test2` 6. Sign off :-D Signed-off-by: Magnus Enger Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass commit 04ebdd4ac140b5cd4a0333340bd1422edf7d92e4 Author: Andreas Jonsson Date: Thu May 22 11:00:35 2025 +0200 Bug 38974: Fix error in OPAC patron update Test plan: 1) Make sure Patron category is checked in the system preference PatronSelfModificationBorrowerUnwantedField 2) Log in to the opac 3) Go to "Personal details" 4) Select any value for "Date of birth" 5) Click save 6) This must not yield error 500. (But may be a successful save or a validation error). Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass commit c4f7b1490604c7c46ca4e9b3385aab2e9cf39433 Author: Jonathan Druart Date: Tue May 27 10:40:15 2025 +0200 Bug 40003: Add a test Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass commit 0ba11f98f99dee947c087cdd9b92838b772a7918 Author: Jonathan Druart Date: Tue May 27 10:40:33 2025 +0200 Bug 40003: Remove warning from log when creating a new bib record Test plan: Hit cataloguing/addbiblio.pl?frameworkcode=FA Without this patch you get warnings in the Koha log file: Use of uninitialized value in string eq at /kohadevbox/koha/cataloguing/addbiblio.pl line 572. Use of uninitialized value in substitution (s///) at /kohadevbox/koha/Koha/UI/Form/Builder/Biblio.pm line 55. with this patch applied: no warning Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass commit db655799ad97a33c89246010734cb187188407ae Author: Jonathan Druart Date: Wed May 28 16:57:55 2025 +0200 Bug 40021: Remove warnings from Koha/Plugins/Recall_hooks.t Test plan: prove t/db_dependent/Koha/Plugins/Recall_hooks.t should return green Signed-off-by: Roman Dolny Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass commit eaaabf66dd935ff52f5c6fece8294ccf3c858b45 Author: Jonathan Druart Date: Wed May 28 16:37:45 2025 +0200 Bug 40018: Remove warnings from Koha/Template/Plugin/Koha.t Because we still use CGI::Session (bug 17427), we need to mock CGI::Session to remove those 2 warnings rollback ineffective with AutoCommit enabled Test plan: Run the tests after this patch, it should be green Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass commit 35baa3ec465306a7e6d6a9ccebe13acedf0b507f Author: Lucas Gass Date: Fri May 30 14:28:23 2025 +0000 Bug 40036: Add reason back to status column and add classes/data attributes To test: 0. APPLY PATCH 1. Make a few AVs for SUGGEST ( reason ) and SUGGEST_STATUS ( status ). 2. Make some new suggestions and give them new statues w/ a reason. 3. The reason should display, in parentheses, in the status column. 4. There should be a status class and a reason class for each. Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass commit c695e6ce4c43113d86413cf0676ce18e2dd8cfcd Author: Jonathan Druart Date: Wed May 28 16:48:15 2025 +0200 Bug 40019: Remove warnings from Koha/Auth/Client.t Test plan: prove t/db_dependent/Koha/Auth/Client.t should return green Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass commit 827ad2124410df96a45290b1c7778f247889df9b Author: Jonathan Druart Date: Wed May 28 16:51:37 2025 +0200 Bug 40020: Remove warnings from Koha/AdditionalContents.t Test plan: prove t/db_dependent/Koha/AdditionalContents.t should return green Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass commit 854783c8362a93e55fa379712ae6e04b24cf552c Author: Tomás Cohen Arazi Date: Mon Jun 2 09:50:19 2025 -0300 Bug 40034: Only check notforloan on itemtype if it exists This patch makes the code in `CheckReserves` survive the non-existence of the referenced item type in the `items` table for the passed item. To test: 1. Apply the regression tests 2. Run: $ ktd --shell k$ prove t/db_dependent/Reserves.t => FAIL: Tests explode like this: ``` Can't call method "notforloan" on an undefined value at /kohadevbox/koha/C4/Reserves.pm line 870. ``` 3. Apply this patch 4. Repeat 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass commit 6c26ce01d39b434d05f3bdd13fc584a4c7ac1c77 Author: Tomás Cohen Arazi Date: Mon Jun 2 09:46:30 2025 -0300 Bug 40034: Regression tests Signed-off-by: David Nind Signed-off-by: Marcel de Rooy Signed-off-by: Lucas Gass commit 0d39336f7111f91560ce23c727c362ddeca0d251 Author: Fridolin Somers Date: Mon Jun 2 10:00:32 2025 +0200 Bug 40042: Add default value 0 for index var in search_indexes.inc In koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc some calls do not set 'index' var generating idx="idx_". Set 0 has default value. Test plan : 1) Enable system preference 'IntranetCatalogSearchPulldown' 2) Go to catalogue advanced search 3) Look HTML source and check you see: Without patch you see: