commit 958ff7427c4d0c700b255c59231febb634efdabe Author: Jonathan Druart Date: Thu Jun 19 11:11:18 2025 +0200 Bug 40179: Add maxLength to patron_category spec file Test plan: Apply the "tests" patch first prove xt/api.t => fail Apply this patch => pass Signed-off-by: David Nind Signed-off-by: Lucas Gass commit 6b50274e5a13b82a373b5fdb5e94d561adc1b23b Author: Jonathan Druart Date: Thu Jun 19 11:16:13 2025 +0200 Bug 40179: Adjust tests Signed-off-by: David Nind Signed-off-by: Lucas Gass commit 8f6b15f4bbe0d3c21b22ac4594abb2b73520a845 Author: Jonathan Druart Date: Thu Jun 19 11:11:11 2025 +0200 Bug 40178: Add maxLength to patron spec file Test plan: Apply the "tests" patch first prove xt/api.t => fail Apply this patch => pass Signed-off-by: David Nind Signed-off-by: Matt Blenkinsop Signed-off-by: Lucas Gass commit 05fef548bc7dc2cb448a4bde4b10217c1a8d74b0 Author: Jonathan Druart Date: Thu Jun 19 11:09:56 2025 +0200 Bug 40178: Adjust tests Signed-off-by: David Nind Signed-off-by: Matt Blenkinsop Signed-off-by: Lucas Gass commit 25dfe5e5da360f127b66e14a8cce28f132ac98c0 Author: Jonathan Druart Date: Thu Jun 19 11:11:01 2025 +0200 Bug 40177: Add maxLength to library spec file Test plan: Apply the "tests" patch first prove xt/api.t => fail Apply this patch => pass Signed-off-by: David Nind Signed-off-by: Matt Blenkinsop Signed-off-by: Lucas Gass commit c1f359249135994d952f7fdad165cdc9c0f60c58 Author: Jonathan Druart Date: Thu Jun 19 11:09:26 2025 +0200 Bug 40177: Adjust tests Signed-off-by: David Nind Signed-off-by: Matt Blenkinsop Signed-off-by: Lucas Gass commit f461b4d4190f06fb1d2dfe4f3d23bc426ee6a5b3 Author: Jonathan Druart Date: Thu Jun 19 11:10:53 2025 +0200 Bug 40176: Add maxLength to item spec file Test plan: Apply the "tests" patch first prove xt/api.t => fail Apply this patch => pass Signed-off-by: David Nind Signed-off-by: Matt Blenkinsop Signed-off-by: Lucas Gass commit 40ad33852defbb000c00478f15152460ff6868d3 Author: Jonathan Druart Date: Thu Jun 19 11:10:47 2025 +0200 Bug 40176: Add tests This patch adds a new subtest to xt/api.t It ensures that maxLength will appear in the rest api spec file when there is a size constraint at the DB level Signed-off-by: David Nind Signed-off-by: Matt Blenkinsop Signed-off-by: Lucas Gass commit 22cd54f1a443a57e848f0e21cb5eec752ecd368a Author: Owen Leonard Date: Fri Mar 21 16:57:37 2025 +0000 Bug 39448: Layout improvement for search filter administration This patch makes a few minor changes to the search filter administration template. To test, apply the patch and rebuild the staff interface CSS. - If the SavedSearchFilters system preference is not enabled, go to Administration -> System preferences and enable it. - Perform a catalog search. - From the search results page, click "Save as search filter" at the top of the results. - Save your filter. - Go to Administration -> Search filters. - The table of filters should be wrapped in a "page-section" div with the heading above it. - In the "Actions" column the buttons should be aligned in a row with space between each. - Click "Edit filter" - In the modal the form fields should be well laid out. Sponsored-by: Athens County Public Libraries Signed-off-by: Felicie Signed-off-by: Lisette Scheer Signed-off-by: Lucas Gass commit f8fd672602b75e0d24d468c1ae8c6ea1b3c5d3a8 Author: Jonathan Druart Date: Mon Jul 7 13:58:37 2025 +0200 Bug 40317: Remove warnings from Auth_with_shibboleth.t output t/db_dependent/Auth_with_shibboleth.t .. 1/5 GetPreparedLetter called at t/db_dependent/Auth_with_shibboleth.t line 73. EnqueueLetter called at t/db_dependent/Auth_with_shibboleth.t line 80. SendQueuedMessages called with message_id: 42 at t/db_dependent/Auth_with_shibboleth.t line 90. Not sure what exactly is going on here, but warnings_are is not supposed to show the warnings in the output. I think it's because of the logger mock. A workaround is to use a variable we increment then compare to see if we reach the sub. Test plan: % prove t/db_dependent/Auth_with_shibboleth.t should return green without warnings Signed-off-by: Martin Renvoize Signed-off-by: Lucas Gass commit 5f44a5ef5a9471aa4387f50e394ca0786e4aa779 Author: Jonathan Druart Date: Mon Jul 7 13:32:11 2025 +0200 Bug 40316: Remove warnings from selenium/regressions.t Wide character in print at /usr/share/perl/5.36/Test2/Formatter/TAP.pm line 156. Test plan: Confirm that % prove t/db_dependent/selenium/regressions.t still passes and does not generate warnings Signed-off-by: Martin Renvoize Signed-off-by: Lucas Gass commit 79060544a4ca1a013811ab4b3898b9f56b934289 Author: Jonathan Druart Date: Thu Jun 12 15:42:17 2025 +0200 Bug 40170: Replace cypress-mysql with mysql2 - Cypress tests This patch suggests to replace cypress-mysql with mysql2 cypress-mysql provides a custom Cypress command (cy.query) that run within the browser context. This approach mixes test-side and server-side and is limited in flexibility and error handling. mysql2 runs inside Cypress plugins (Node process) via cy.task calls, which are executed server-side (outside the browser) This is needed for the follow-up bug reports where we need to request the DB from other plugins Test plan: Run `yarn install` to install the mysql2 All the Cypress tests modified by this patch must still pass The new test t/cypress/integration/t/db.ts must also pass Signed-off-by: David Nind Signed-off-by: Pedro Amorim Signed-off-by: Lucas Gass commit 6096d986d5b7079fdeb009a6498b6755d911fd39 Author: Jonathan Druart Date: Wed Jun 18 22:12:25 2025 +0200 Bug 40168: Remove cleanup() call from afterEach Signed-off-by: David Nind Signed-off-by: Pedro Amorim Signed-off-by: Lucas Gass commit b83df697de67261e83c0aa6ae3a13a3df2770010 Author: Jonathan Druart Date: Mon Jun 16 16:06:57 2025 +0200 Bug 40168: Restore afterEach in KohaTable Cypress tests We defined an anonymous function inside an arrow function, and Cypress does not call it. Test plan: Set AlwaysShowHoldingsTableFilters to "Do not" Run t/cypress/integration/KohaTable/Holdings_spec.ts: yarn cypress run --spec t/cypress/integration/KohaTable/Holdings_spec.ts When done, have a look at the value of AlwaysShowHoldingsTableFilters => without this patch it has been modified (not restored) and is set to "Do" => With this patch applied the original value is restored at the end of the tests (actually the end of each test) Signed-off-by: David Nind Signed-off-by: Pedro Amorim Signed-off-by: Lucas Gass commit f0b4bd4fa2112f355348f80cce5604ac22ebeeb2 Author: Jonathan Druart Date: Tue Jul 8 11:10:09 2025 +0200 Bug 39876: Make build-git-snapshot pass codespell Signed-off-by: Lucas Gass commit 85b65afd1df0bc2867d90e91fc64e39f729c3e41 Author: Tomás Cohen Arazi Date: Fri Jun 27 14:18:14 2025 -0300 Bug 39876: Add build-git-snapshot type resolution Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lucas Gass commit 35c4a6eb071f39e91549efebb43a4b689921ace5 Author: Tomás Cohen Arazi Date: Fri Jun 27 14:22:32 2025 -0300 Bug 39876: Make find-missing-op-in-forms.t test TT files Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lucas Gass commit 09bfbd50600f5de8bb2f6ffe951e71946a5279de Author: Jonathan Druart Date: Tue May 13 21:59:19 2025 +0200 Bug 39876: Get TT files for tt_tidy Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lucas Gass commit 48263039afa38cfcda671ec9a259d2e19b5f6ee8 Author: Jonathan Druart Date: Mon May 12 14:34:01 2025 +0200 Bug 39876: Apply module to other tests We are ready to reuse Koha::Devel::Files in other places where `git ls-files` is used. Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lucas Gass commit e7e42c5e88adabe50f64ac4da31ccb6210a531fd Author: Jonathan Druart Date: Mon May 12 12:35:43 2025 +0200 Bug 39876: Add context for tidy With this patch we adjust what's needed to make misc/devel/tidy.pl run identically as before Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lucas Gass commit 1d4071298ca8b686b7560f1fe0c83337695f0fea Author: Jonathan Druart Date: Mon May 12 12:30:55 2025 +0200 Bug 39876: Move `git ls-files` to Koha::Devel::Files This patch introduces a new Koha::Devel namespace. It clearly shows that its purpose is for development and will not contain any business logic. Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lucas Gass commit b5a077425e6b593db73362d7576e078837be3321 Author: Tomás Cohen Arazi Date: Thu Jul 3 14:11:01 2025 -0300 Bug 40164: (follow-up) Update debian/control Signed-off-by: Tomas Cohen Arazi Signed-off-by: Lucas Gass commit 25951ea83f0e1512394f00d8b274086edf9ec230 Author: Tomás Cohen Arazi Date: Wed Jun 18 11:45:55 2025 -0300 Bug 40164: Add Template::Plugin::JSON dependency Signed-off-by: Tomas Cohen Arazi Signed-off-by: David Cook Signed-off-by: Lucas Gass commit 8a5a0ab39ef64e6d3bb5416198e2a27dcad7b1ac Author: Jonathan Druart Date: Mon Jul 7 10:52:08 2025 +0200 Bug 38899: Fix Cypress tests Signed-off-by: Lucas Gass commit d538261fd429934bc3f4512e064db2c7b315c8b7 Author: Jonathan Druart Date: Fri Jul 4 12:51:41 2025 +0200 Bug 40129: Fix selenium tests Signed-off-by: Lucas Gass commit 1c7cb4d43ba380a61f084e09008684498350f250 Author: Jonathan Druart Date: Mon Jul 7 15:00:12 2025 +0200 Bug 40277: Add a test Signed-off-by: Jonathan Druart Signed-off-by: Lucas Gass commit d60deb348c534162854e8d4637860499c2f81d65 Author: Fridolin Somers Date: Mon Jun 30 17:04:12 2025 +0200 Bug 40277: Remove warn in C4::Koha::GetAuthorisedValues() When using the OPAC and you are not logged in, there are warnings in the logs: [WARN] Use of uninitialized value $branch_limit in concatenation (.) or string It comes from C4::Koha::GetAuthorisedValues() : my $branch_limit = C4::Context->userenv ? C4::Context->userenv->{"branch"} : ""; my $cache_key = "AuthorisedValues-$category-$opac-$branch_limit"; C4::Context->userenv->{"branch"} can be undef The patch fixes using C4::Context::mybranch(). Test plan: 1. Set the OpacAdvancedSearchTypes system preference to something other than "itemtypes", for example "loc". 2. Go to OPAC without logging in, and perform a search. 3. Check the /var/log/koha/kohadev/plack-opac-error.log and note the warnings in the log: [WARN] Use of uninitialized value $branch_limit in concatenation (.) or ... (Alternative, tail the logs: tail -f /var/log/koha/kohadev/*.log 4. Apply the patch. 5. Repeat step 2 and check that there are no longer any warnings. 6. Sign off. Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Lucas Gass commit 1e81401295ba3dea6513bc967536c19104c19466 Author: Jonathan Druart Date: Mon Mar 10 16:21:12 2025 +0100 Bug 39289: Display all checkouts in the batch extend due date tools When paginate is false, pageLength is still used. If more than 20 checkouts should be displayed, only 20 will. Test plan: Have more than 20 checkouts, use the batch extend due date tool and notice that all checkouts are displayed when this patch is applied. Signed-off-by: Magnus Enger Tested on top of bug 39081. Signed-off-by: Baptiste Wojtkowski Signed-off-by: Lucas Gass commit 0802e46e18f805c622e84999ea6b814c1a37d3c2 Author: Jonathan Druart Date: Thu Jun 12 13:35:42 2025 +0200 Bug 40046: Use xml and auto-select it Absolutely no idea why the previous code was not selecting MARCXML (MARC was passed and so the import failed) cy.get('select[name="format"]') .select("MARCXML", { force: true }) .should("have.value", "MARCXML"); But I found a bug in the JS code: we are supposed to auto-detect .xml file and pre-select MARCXML. So let's rely on that behaviour! sample.mrc is actually an xml file so it makes sense to rename it Signed-off-by: Paul Derscheid Signed-off-by: Lucas Gass commit 9ebfd8d462587f4a1a1d11c6de34c854fcafaea8 Author: Jonathan Druart Date: Tue Jun 3 16:12:32 2025 +0200 Bug 40046: Prevent random failures when verifying select's values Commands like .select() are queued. We need to prevent the should to happen before the select is executed. Signed-off-by: Paul Derscheid Signed-off-by: Lucas Gass commit f12bbbf01083ff3cf780c47ad46b1b98a18cafdb Author: Jonathan Druart Date: Wed Apr 23 11:15:33 2025 +0200 Bug 40046: (bug 39606 follow-up) Remove waits and screenshots From bug 39606: """ Why are you taking screenshots? The wait statements will certainly cause random failures. cy.wait(5000); cy.wait(2000); Notice the following couple of lines: cy.get("#fileuploadstatus").contains("100%"); cy.get("legend").contains("Look for existing records in catalog?").should('be.visible'); It makes Cypress wait 10s until "100%" appears (ie. the file is updated), then the block with the dropdown lists you are going to interact with to be visible. You should almost never use cy.wait. """ Test plan: yarn cypress run --spec t/cypress/integration/Tools/ManageMarcImport_spec.ts should still pass Signed-off-by: David Nind Signed-off-by: Paul Derscheid Signed-off-by: Lucas Gass commit 32860c2778bcd39bf2b212829f3102037885814b Author: Martin Renvoize Date: Thu Jul 3 13:55:09 2025 +0100 Bug 37305: (follow-up) Only add control number subfield when defined The previous commit introduced a bug where the control number subfield 'w' was being added to the MARC field even when undefined, causing test failures. This patch adds a condition to only push the control number subfield when the value is actually defined, matching the pattern used for other subfields in the method. Signed-off-by: Martin Renvoize Signed-off-by: Lucas Gass commit 3e627d7a77fdd3bd47519ae887807a5fbb80ddcd Author: Martin Renvoize Date: Wed Jul 17 11:04:47 2024 +0100 Bug 37305: Remove C4::Biblio::prepare_host_field This patch updates the only use of prepare_host_field to use the well tested Koha::Biblio->generate_marc_host_field method instead and then removes the aforementioned prepare_host_field method from C4::Biblio. Test plan 1) Ensure the "enhanced workflow" for creating analytics still functions as expected. Sponsored-by: Open Fifth Signed-off-by: Heather Hernandez Signed-off-by: Martin Renvoize Signed-off-by: Lucas Gass commit 3d9778b2cd472a520afe4074e09f6c76fa5d7907 Author: Martin Renvoize Date: Wed Jul 17 10:51:01 2024 +0100 Bug 37305: Subfield order matters This patch updates the use of a hash to store and then pass subfields to the MARC::Field new method to an array with key/value pairs using fat comma's. This allows us to maintain the integrity check that we're passing string as the first arguament in each pair whilst also allowing us to ensure fields are passed in the order they are found. Sponsored-by: Open Fifth Signed-off-by: Heather Hernandez Signed-off-by: Martin Renvoize Signed-off-by: Lucas Gass commit da12f995075bd3d8a5e0e8a529697f34384f965f Author: Owen Leonard Date: Fri Jun 27 18:22:42 2025 +0000 Bug 20601: Untranslatable strings in circulation statistics This patch makes some updates to the circulation statistics wizard in order to make more information translatable. The patch also adds some template plugins to the output of filter options in order to be able to show descriptions instead of codes, and corrects the markup for the 'Patron library' dropdown which wasn't working. To test apply the patch and go to Reports -> Statistics wizards -> Circulation. - Test setting some or all options in the "Filter column" and running the report. - Confirm that the "Patron library" dropdown works. - At the top of the results there should be a list of the filter options you selected and their values. - All the filter labels should be correct, and the filter values should should be in their full/description form rather than in code form (e.g. library, item type, collection code, sorting field, etc.) Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind Signed-off-by: Aleisha Amohia Signed-off-by: Lucas Gass commit dc11fbdc5b1f49cd5e611b2cd964ce3890f3d711 Author: Tomás Cohen Arazi Date: Fri Jun 27 14:12:41 2025 +0000 Bug 40261: Tidy debian/build-git-snapshot Signed-off-by: David Flater Signed-off-by: Martin Renvoize Signed-off-by: Lucas Gass commit a7ed3b91747c32cb006b7e8ff2284f54d4ea6b61 Author: Lucas Gass Date: Thu Jul 3 14:55:03 2025 +0000 Revert "Bug 40164: Add Template::Plugin::JSON dependency" This reverts commit d3783f8859cbcdd3dce01f37c41bf47981200eea. Signed-off-by: Lucas Gass commit d4647c95238ae22ecbbea4130a1cbc06fac9187b Author: Lucas Gass Date: Mon Jun 30 21:58:22 2025 +0000 Bug 34561: DBRev 25.06.00.002 Signed-off-by: Lucas Gass commit c1a1b85c874e95ed9839fff206a3609f3d0fd858 Author: Lisette Scheer Date: Wed Jun 25 15:11:00 2025 +0000 Bug 34561: (QA follow-up) Rename to StaffReportsHome to match othe html customizations I noticed the rest of the html customizations don't have html in the option name, so I renamed for consistency. Signed-off-by: Lucas Gass commit 20caaf611a422d03b2a6135627a2f26540c6b09d Author: Owen Leonard Date: Tue Jun 10 14:41:39 2025 +0000 Bug 34561: Move IntranetReportsHomeHTML to HTML customizations This patch moves the IntranetReportsHomeHTML system preference into HTML customizations, making it possible to have language- and library-specific content. To test you should have some content in the IntranetReportsHomeHTML system preference before applying the patch. Apply the patch and run the database update process. - In the staff client, go to Tools -> HTML customizations and verify that the content from IntranetReportsHomeHTML is now stored there. - The HTML customization entry form should offer IntranetReportsHomeHTML as a choice under "Display location." - Update and reinstall active translations (for instance fr-FR): - perl misc/translator/translate update fr-FR - perl misc/translator/translate install fr-FR - Enable the translation if necessary under Administration -> System preferences -> language. - Edit the IntranetReportsHomeHTML HTML customization and add unique content to the "fr-FR" tab. - Go to the reports home page. You should see the content you added to the IntranetReportsHomeHTML HTML customization. - Switch to your updated translation and confirm that the content you added for your translation shows up correctly. - Go to Administration -> System preferences and search for "IntranetReportsHomeHTML." It should return no results. Sponsored-by: Athens County Public Libraries Signed-off-by: Ray Delahunty Signed-off-by: Lisette Scheer Signed-off-by: Lucas Gass commit 3622664b919a48b430bf2a6edc30e214be17d9b6 Author: David Nind Date: Mon Jun 30 18:29:19 2025 +0000 Bug 40281: Hide the type column on the patron circulation history page This fixes the patron circulation history page so that the type column is hidden. The type column on a patron's circulation history page was hidden by Bug 38954 - Hide checkout type using colvis. However, the commit for Bug 37273 - Add ID column to Agreements table in the ERM, inadvertently reversed hiding the column. Test plan: 1. Check out an item to a patron (for example, 39999000011418 to Mary Burton). 2. Look at the patron's circulation history page (Patrons > Mary Burton > Circulation history), and note there is a 'Type' column shown with a value of 'standard_checkout'. 3. Note that you can't hide the column, from either selecting the 'Columns' or 'Configure' options for the table. 4. Apply the patch, restart everything (restart_all), and clear your browser cache. 5. Repeat step 2. Note that there is now no 'Type' column shown and it is not configurable, from either selecting the 'Columns' or 'Configure' options for the table. Signed-off-by: David Nind Signed-off-by: Laura_Escamilla Signed-off-by: Lucas Gass commit 0c074c694edd4582c0b47d52e8d27553d8955136 Author: Owen Leonard Date: Fri May 23 16:52:00 2025 +0000 Bug 39441: Some staff interface templates have div.container instead of div.container-fluid This patch updates a few templates so that div.container is replaced with div.container-fluid. div.container gives us a fixed maximum width that isn't consistent the rest of Koha. To test, apply the patch and go to the staff interface. - Perform a catalog search which will return multiple results. - In the search results, check multiple results and click "Add to cart." - Click the cart icon in the top menu to trigger the cart popup. - The contents of the cart popup should fill the whole width of the window. - The other instances of this are less noticeable because of how the pages work. These changes are more about consistency: - The OPAC place hold page - The club enrollment process (both in the OPAC and the staff interface) - As long as these interactions work correctly all is good. Sponsored-by: Athens County Public Libraries Signed-off-by: Lisette Scheer Signed-off-by: Lucas Gass commit 81859ce66292170af79d41905fe93127932984d1 Author: Lucas Gass Date: Tue Feb 11 21:27:14 2025 +0000 Bug 38939: Add reservenote column to members/holdshistory.pl To test: 1. APPLY PATCH, restart_all 2. Make some holds for patrons in both the staff client and the OPAC. ( For OPAC turn on OpacHoldNotes ) 3. Make sure you add some notes to each of these holds. 4. Go to the patron account and click on the 'Holds history' tab. 5. Make sure the hold note is there and looks correct. 6. Ensure you can hide the coluimn properly via Table settings. Signed-off-by: Andrew Auld Signed-off-by: Martin Renvoize Signed-off-by: Lucas Gass commit f8a1e44f5cc07b9eebba4d4a63608fd488d9547f Author: Martin Renvoize Date: Wed Jun 25 14:44:34 2025 +0000 Bug 33729: (QA follow-up) Tidy Signed-off-by: Martin Renvoize Signed-off-by: Lucas Gass commit 6169b9cdf13fcf1bddb648b25a705d7434e69415 Author: Laura Escamilla Date: Fri Apr 11 14:55:24 2025 +0000 Bug 33729: Added datacolumn for date accessioned Signed-off-by: Emmanuel Bétemps Signed-off-by: Martin Renvoize Signed-off-by: Lucas Gass commit 4b18fba00743e1a545d7ce77cfada78ad90e6c38 Author: Laura Escamilla Date: Wed Apr 2 14:34:46 2025 +0000 Bug 33729: Added dateaccessioned to column_settings.yml Signed-off-by: Andrew Auld Signed-off-by: Emmanuel Bétemps Signed-off-by: Martin Renvoize Signed-off-by: Lucas Gass commit 5875adce836fd9127a3d4b42b61982051697bf93 Author: Laura Escamilla Date: Wed Apr 2 07:15:59 2025 +0000 Bug 33729: Added date accessioned to items search table Test plan: 1. Apply patch 2. Go to item search 1. Notice that there is now a date accessioned column 2. Export the table into a CSV and notice that there is also a date accessioned column there 3. Sign off and have an amazing day :D Signed-off-by: Emmanuel Bétemps Signed-off-by: Martin Renvoize Signed-off-by: Lucas Gass commit 8436f799c1e15879264407ade761314b10f26c51 Author: Emily Lamancusa Date: Wed Dec 4 10:49:32 2024 -0500 Bug 31632: (QA follow-up) Align behavior with order from suggestion If an order is added from a suggestion in the first place, the suggestion automatically changes status to ORDERED, and a notice is sent out to the patron. If a suggestion is linked to the order after the fact, it should move to ORDERED and notify the patron as well. Signed-off-by: Emily Lamancusa Signed-off-by: Aleisha Amohia Signed-off-by: Lucas Gass commit ef271e8bd5a3ffa2a93846404b7ba7690344fe5e Author: Emily Lamancusa Date: Wed Dec 4 10:43:43 2024 -0500 Bug 31632: (QA follow-up) Adjust TT filters and remove extra form-submit.js Signed-off-by: Emily Lamancusa Signed-off-by: Aleisha Amohia Signed-off-by: Lucas Gass commit 73de7c716e809843ee86b38c2c4b753823468342 Author: Aleisha Amohia Date: Mon Sep 2 23:55:00 2024 +0000 Bug 31632: (follow-up) CSRF protection for linking order to suggestion Signed-off-by: Andrew Fuerste Henry Signed-off-by: Emily Lamancusa Signed-off-by: Lucas Gass